From: Andy King <acking@vmware.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: George Zhang <georgezhang@vmware.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, pv-drivers@vmware.com,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH 12/12] VMCI: Some header and config files.
Date: Fri, 30 Nov 2012 08:47:46 -0800 (PST) [thread overview]
Message-ID: <1481496655.36482563.1354294066563.JavaMail.root@vmware.com> (raw)
In-Reply-To: <20121127002357.GA27683@core.coreip.homeip.net>
I didn't get the resend either, so it seems our corporate mail really is
eating messages. Lovely.
> > > +#define IOCTLCMD(_cmd) IOCTL_VMCI_ ## _cmd
> >
> > I don't recall ever getting a valid answer for this (if you did, my
> > appologies, can you repeat it). What in the world are you talking
> > about here? Why is your driver somehow special from the thousands
> > of other ones that use the in-kernel IO macros properly for an
> > ioctl?
Because we're morons. And unfortunately, we've shipped our product
using those broken definitions: our VMX uses them to talk to the driver.
So here's what we'd like to do. We will send out a patch soon that
fixes the other issues you mention and also adds IOCTL definitions the
proper way using _IOBLAH(). But we'd also like to retain these broken
definitions for a short period, commented as such, at least until we
can get out a patch release to Workstation 9, at which point we can
remove them. Does that sound reasonable?
Thanks!
- Andy
next prev parent reply other threads:[~2012-11-30 16:47 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-07 18:40 [PATCH 00/12] VMCI for Linux upstreaming George Zhang
2012-11-07 18:41 ` [PATCH 01/12] VMCI: context implementation George Zhang
2012-11-07 18:41 ` [PATCH 02/12] VMCI: datagram implementation George Zhang
2012-11-15 23:47 ` Greg KH
2012-11-07 18:41 ` [PATCH 03/12] VMCI: doorbell implementation George Zhang
2012-11-07 18:41 ` [PATCH 04/12] VMCI: device driver implementaton George Zhang
2012-11-07 18:41 ` [PATCH 05/12] VMCI: event handling implementation George Zhang
2012-11-07 18:42 ` [PATCH 06/12] VMCI: handle array implementation George Zhang
2012-11-07 18:42 ` [PATCH 07/12] VMCI: queue pairs implementation George Zhang
2012-11-15 23:48 ` Greg KH
2012-11-07 18:42 ` [PATCH 08/12] VMCI: resource object implementation George Zhang
2012-11-07 18:42 ` [PATCH 09/12] VMCI: routing implementation George Zhang
2012-11-07 18:42 ` [PATCH 10/12] VMCI: guest side driver implementation George Zhang
2012-11-07 18:42 ` [PATCH 11/12] VMCI: host " George Zhang
2012-11-16 0:03 ` Greg KH
2012-11-07 18:43 ` [PATCH 12/12] VMCI: Some header and config files George Zhang
2012-11-16 0:01 ` Greg KH
2012-11-27 0:03 ` Greg KH
2012-11-27 0:23 ` Dmitry Torokhov
2012-11-27 0:32 ` Greg KH
2012-11-27 0:45 ` [Pv-drivers] " Dmitry Torokhov
2012-11-30 16:47 ` Andy King [this message]
2012-11-30 17:09 ` Greg KH
2012-11-30 17:20 ` [Pv-drivers] " Dmitry Torokhov
2012-11-30 18:39 ` Greg KH
2012-11-30 18:45 ` Dmitry Torokhov
2012-11-30 18:57 ` Greg KH
2012-11-30 20:09 ` Dmitry Torokhov
2012-11-30 20:44 ` Greg KH
2012-11-30 20:58 ` Dmitry Torokhov
2012-11-30 21:17 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2013-01-08 23:52 [PATCH 00/12] VMCI for Linux upstreaming George Zhang
2013-01-08 23:55 ` [PATCH 12/12] VMCI: Some header and config files George Zhang
2012-11-21 20:31 [PATCH 00/12] VMCI for Linux upstreaming George Zhang
2012-11-21 20:36 ` [PATCH 12/12] VMCI: Some header and config files George Zhang
2012-11-01 17:28 [PATCH 00/12] VMCI for Linux upstreaming George Zhang
2012-11-01 17:30 ` [PATCH 12/12] VMCI: Some header and config files George Zhang
2012-10-30 1:03 [PATCH 00/12] VMCI for Linux upstreaming George Zhang
2012-10-30 1:05 ` [PATCH 12/12] VMCI: Some header and config files George Zhang
2012-10-30 2:32 ` Greg KH
2012-10-30 2:38 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481496655.36482563.1354294066563.JavaMail.root@vmware.com \
--to=acking@vmware.com \
--cc=dmitry.torokhov@gmail.com \
--cc=georgezhang@vmware.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).