From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932187AbcLLPzi (ORCPT <rfc822;w@1wt.eu>);
        Mon, 12 Dec 2016 10:55:38 -0500
Received: from smtprelay0017.hostedemail.com ([216.40.44.17]:57235 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1752975AbcLLPzf (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 12 Dec 2016 10:55:35 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:173:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3871:3872:3873:3874:4321:5007:6117:6691:7875:10004:10400:10848:11026:11232:11473:11658:11783:11914:12043:12663:12740:13069:13311:13357:13439:13894:14181:14659:14721:21080:30003:30012:30054:30075:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:5,LUA_SUMMARY:none
X-HE-Tag: back27_132f8327c7723
X-Filterd-Recvd-Size: 2731
Message-ID: <1481558130.1764.21.camel@perches.com>
Subject: Re: [patch] nvme-fabrics: correct some printk information
From: Joe Perches <joe@perches.com>
To: Julia Lawall <julia.lawall@lip6.fr>,
        Dan Carpenter <dan.carpenter@oracle.com>
Cc: James Smart <james.smart@broadcom.com>,
        Keith Busch <keith.busch@intel.com>, Jens Axboe <axboe@fb.com>,
        linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Date: Mon, 12 Dec 2016 07:55:30 -0800
In-Reply-To: <alpine.DEB.2.10.1612121646460.3156@hadrien>
References: <20161210090618.GA11680@elgon.mountain>
         <1481369270.5946.51.camel@perches.com> <20161210184029.GY8176@mwanda>
         <alpine.DEB.2.20.1612102104050.1986@hadrien>
         <1481403290.1764.1.camel@perches.com> <20161210210737.GR8244@mwanda>
         <1481408662.1764.3.camel@perches.com> <20161212093352.GB8176@mwanda>
         <alpine.DEB.2.10.1612121646460.3156@hadrien>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.22.1-0ubuntu2 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2016-12-12 at 16:47 +0100, Julia Lawall wrote:
> 
> On Mon, 12 Dec 2016, Dan Carpenter wrote:
> 
> > On Sat, Dec 10, 2016 at 02:24:22PM -0800, Joe Perches wrote:
> > > On Sun, 2016-12-11 at 00:07 +0300, Dan Carpenter wrote:
> > > > On Sat, Dec 10, 2016 at 12:54:50PM -0800, Joe Perches wrote:
> > > > > diff -u -p drivers//dma/pxa_dma.c /tmp/nothing//dma/pxa_dma.c
> > > > > --- drivers//dma/pxa_dma.c
> > > > > +++ /tmp/nothing//dma/pxa_dma.c
> > > > > @@ -640,9 +640,6 @@ static unsigned int clear_chan_irq(struc
> > > > >         dcsr = phy_readl_relaxed(phy, DCSR);
> > > > >         phy_writel(phy, dcsr, DCSR);
> > > > >         if ((dcsr & PXA_DCSR_BUSERR) && (phy->vchan))
> > > > > -               dev_warn(&phy->vchan->vc.chan.dev->device,
> > > > > -                        "%s(chan=%p): PXA_DCSR_BUSERR\n",
> > > > > -                        __func__, &phy->vchan);
> > > >
> > > > That's not a defect.  We're getting the address of vchan.  I don't get
> > > > it?
> > >
> > > $ git grep -n -w vchan drivers/dma/pxa*
> > > drivers/dma/pxa_dma.c:103:      struct pxad_chan        *vchan;
> >
> > I'm not sure what you're saying here still.  This code works as
> > intended.  We're not printing a stack address.
> 
> I guess that the point is that one would like to print the channel, not
> the address of the channel?

Generally, printing the address of a pointer
_can_ be useful, but it's likely a defect with
a low false positive rate.