From: "Pali Rohár" <pali.rohar@gmail.com>
To: Russell King <linux@armlinux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
Robin Murphy <robin.murphy@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
Ben Dooks <ben-linux@fluff.org>, Tony Lindgren <tony@atomide.com>,
Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
Sebastian Reichel <sre@kernel.org>,
Aaro Koskinen <aaro.koskinen@iki.fi>, Pavel Machek <pavel@ucw.cz>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, "Pali Rohár" <pali.rohar@gmail.com>
Subject: [PATCH] arm: dt: Initialize boot_command_line from CONFIG_CMDLINE in case DT does not provide /chosen/bootargs
Date: Wed, 14 Dec 2016 22:12:43 +0100 [thread overview]
Message-ID: <1481749963-8664-1-git-send-email-pali.rohar@gmail.com> (raw)
Commit 008a2ebcd677 ("ARM: dts: omap3: Remove skeleton.dtsi usage") broke
support for setting cmdline on Nokia N900 via CONFIG_CMDLINE.
It is because arm code booted in DT mode parse cmdline only via function
early_init_dt_scan_chosen() and that function does not fill variable
boot_command_line when DTB does not contain /chosen entry. It is called
from function early_init_dt_scan_nodes() in setup_machine_fdt().
This patch fixes it by explicitly filling boot_command_line in function
setup_machine_fdt() after calling early_init_dt_scan_nodes() in case
boot_command_line still remains empty.
Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
---
arch/arm/kernel/devtree.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/kernel/devtree.c b/arch/arm/kernel/devtree.c
index f676feb..dbe25b1 100644
--- a/arch/arm/kernel/devtree.c
+++ b/arch/arm/kernel/devtree.c
@@ -260,6 +260,11 @@ const struct machine_desc * __init setup_machine_fdt(unsigned int dt_phys)
early_init_dt_scan_nodes();
+#ifdef CONFIG_CMDLINE
+ if (!boot_command_line[0])
+ strlcpy(boot_command_line, CONFIG_CMDLINE, COMMAND_LINE_SIZE);
+#endif
+
/* Change machine number to match the mdesc we're using */
__machine_arch_type = mdesc->nr;
--
1.7.9.5
next reply other threads:[~2016-12-14 21:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 21:12 Pali Rohár [this message]
2016-12-14 21:25 ` [PATCH] arm: dt: Initialize boot_command_line from CONFIG_CMDLINE in case DT does not provide /chosen/bootargs Pavel Machek
2016-12-14 21:46 ` Tony Lindgren
2016-12-14 22:22 ` Javier Martinez Canillas
2016-12-14 23:52 ` Russell King - ARM Linux
2016-12-15 0:09 ` Pali Rohár
2016-12-15 0:18 ` Robin Murphy
2016-12-15 10:09 ` Russell King - ARM Linux
2016-12-16 11:42 ` Pali Rohár
2016-12-25 22:08 ` Pali Rohár
2017-01-02 13:54 ` Russell King - ARM Linux
2016-12-16 11:46 ` Pali Rohár
2016-12-16 12:13 ` Javier Martinez Canillas
2016-12-16 12:32 ` Pali Rohár
2016-12-16 12:38 ` Javier Martinez Canillas
2016-12-16 12:48 ` Pali Rohár
2016-12-16 12:53 ` Javier Martinez Canillas
2016-12-16 15:40 ` Tony Lindgren
2016-12-16 16:13 ` Pali Rohár
2016-12-16 16:21 ` Tony Lindgren
2016-12-16 16:27 ` Russell King - ARM Linux
2016-12-16 16:57 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481749963-8664-1-git-send-email-pali.rohar@gmail.com \
--to=pali.rohar@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=arnd@arndb.de \
--cc=ben-linux@fluff.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=pavel@ucw.cz \
--cc=robin.murphy@arm.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).