public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Christoph Hellwig <hch@infradead.org>
Subject: [PATCH 1/8] linux/types.h: enable endian checks for all sparse builds
Date: Thu, 15 Dec 2016 07:15:11 +0200	[thread overview]
Message-ID: <1481778865-27667-2-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1481778865-27667-1-git-send-email-mst@redhat.com>

By now, linux is mostly endian-clean. Enabling endian-ness
checks for everyone produces about 200 new sparse warnings for me -
less than 10% over the 2000 sparse warnings already there.

Not a big deal, OTOH enabling this helps people notice
they are introducing new bugs.

So let's just drop __CHECK_ENDIAN__. Follow-up patches
can drop distinction between __bitwise and __bitwise__.

Cc: Linus Torvalds <torvalds@linux-foundation.org>
Suggested-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 include/uapi/linux/types.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/include/uapi/linux/types.h b/include/uapi/linux/types.h
index acf0979..41e5914 100644
--- a/include/uapi/linux/types.h
+++ b/include/uapi/linux/types.h
@@ -23,11 +23,7 @@
 #else
 #define __bitwise__
 #endif
-#ifdef __CHECK_ENDIAN__
 #define __bitwise __bitwise__
-#else
-#define __bitwise
-#endif
 
 typedef __u16 __bitwise __le16;
 typedef __u16 __bitwise __be16;
-- 
MST

  reply	other threads:[~2016-12-15  5:17 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-15  5:15 [PATCH 0/8] enable endian checks for all sparse builds Michael S. Tsirkin
2016-12-15  5:15 ` Michael S. Tsirkin [this message]
2016-12-15  5:15 ` [PATCH 2/8] tools: " Michael S. Tsirkin
2016-12-15  5:15 ` [PATCH 3/8] Documentation/sparse: drop __bitwise__ Michael S. Tsirkin
2016-12-15  5:15 ` [PATCH 4/8] checkpatch: replace __bitwise__ with __bitwise Michael S. Tsirkin
2016-12-15 15:22   ` Joe Perches
2016-12-15  5:15 ` [PATCH 5/8] linux: drop __bitwise__ everywhere Michael S. Tsirkin
2016-12-15  9:04   ` Stefan Schmidt
2016-12-15 11:51   ` Greg Kroah-Hartman
2016-12-15 17:28   ` Krzysztof Kozlowski
2016-12-15 19:44   ` Lee Duncan
2016-12-19  9:09   ` Luca Coelho
2016-12-15  5:15 ` [PATCH 6/8] Documentation/sparse: drop __CHECK_ENDIAN__ Michael S. Tsirkin
2016-12-15  5:15 ` [PATCH 7/8] fs/logfs: " Michael S. Tsirkin
2016-12-15  5:15 ` [PATCH 8/8] Makefile: drop -D__CHECK_ENDIAN__ from cflags Michael S. Tsirkin
2016-12-15  7:00   ` Marcel Holtmann
2016-12-15  7:57   ` Marc Kleine-Budde
2016-12-15 11:50   ` Greg Kroah-Hartman
2016-12-15 20:15   ` Arend Van Spriel
2016-12-19  9:08   ` Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1481778865-27667-2-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox