Re: [PATCH 0/2] nvme: Improvements in sysfs entry for NVMe CMBs

Jens Axboe
2016-12-19T15:37:56Z

On 12/16/2016 11:54 AM, Stephen Bates wrote:
> Hi
>
> This series adds some more verbosity to the NVMe CMB sysfs entry.
>
> Jens I based this off v4.9 because for some reason your for-4.10/block
> is missing my original CMB commit (202021c1a63c6)?
>
> Stephen
>
> Stephen Bates (2):
> nvme : Use correct scnprintf in cmb show
> nvme: improve cmb sysfs reporting
>
> drivers/nvme/host/pci.c | 33 ++++++++++++++++++++++++++++++---
> include/linux/nvme.h | 8 ++++++++
> 2 files changed, 38 insertions(+), 3 deletions(-)

I have added 1/2, since that one is a no-brainer. For 2/2, not so sure.
Generally we try to avoid having sysfs file that aren't single value
output. That isn't a super hard rule, but it is preferable.

--
Jens Axboe