The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Devendra Sharma <devendra.sharma9091@gmail.com>, abbotti@mev.co.uk
Cc: hsweeten@visionengravers.com, gregkh@linuxfoundation.org,
	ansonjacob.aj@gmail.com, amitoj1606@gmail.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging:comedi:cb_pcidas64=>Fixed checkpatch warnings
Date: Sun, 18 Dec 2016 01:44:25 -0800	[thread overview]
Message-ID: <1482054265.2431.1.camel@perches.com> (raw)
In-Reply-To: <1482053778-28921-1-git-send-email-devendra.sharma9091@gmail.com>

On Sun, 2016-12-18 at 15:06 +0530, Devendra Sharma wrote:
> From: devendra sharma <devendra.sharma9091@gmail.com>
[]
> diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
[]
> @@ -1500,10 +1500,9 @@ static int alloc_and_init_dma_members(struct comedi_device *dev)
>  		if (ao_cmd_is_supported(board)) {
>  			devpriv->ao_buffer[i] =
>  				dma_alloc_coherent(&pcidev->dev,
> -						   DMA_BUFFER_SIZE,
> -						   &devpriv->
> -						   ao_buffer_bus_addr[i],
> -						   GFP_KERNEL);
> +				   DMA_BUFFER_SIZE,
> +				   &devpriv->ao_buffer_bus_addr[i],
> +				   GFP_KERNEL);
>  			if (!devpriv->ao_buffer[i])
>  				return -ENOMEM;
>  		}

Please just exceed 80 columns instead.

				dma_alloc_coherent(&pcidev->dev,
						   DMA_BUFFER_SIZE,
						   &devpriv->ao_buffer_bus_addr[i],
						   GFP_KERNEL);

etc...

  reply	other threads:[~2016-12-18  9:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-18  9:36 [PATCH] Staging:comedi:cb_pcidas64=>Fixed checkpatch warnings Devendra Sharma
2016-12-18  9:44 ` Joe Perches [this message]
2016-12-18 10:01 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1482054265.2431.1.camel@perches.com \
    --to=joe@perches.com \
    --cc=abbotti@mev.co.uk \
    --cc=amitoj1606@gmail.com \
    --cc=ansonjacob.aj@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=devendra.sharma9091@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hsweeten@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox