From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758382AbcLRRao (ORCPT ); Sun, 18 Dec 2016 12:30:44 -0500 Received: from smtprelay0139.hostedemail.com ([216.40.44.139]:50091 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752932AbcLRRao (ORCPT ); Sun, 18 Dec 2016 12:30:44 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:2914:3138:3139:3140:3141:3142:3280:3352:3622:3865:3866:4037:4321:4605:5007:7903:9010:10004:10400:10848:11026:11232:11233:11473:11657:11658:11914:12043:12114:12296:12740:12895:13069:13311:13357:13439:13894:14659:14721:21080:30054:30070:30091,0,RBL:error,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:error,Custom_rules:0:0:0,LFtime:2000,LUA_SUMMARY:none X-HE-Tag: moon03_22d7f81384e35 X-Filterd-Recvd-Size: 2548 Message-ID: <1482082238.2431.3.camel@perches.com> Subject: Re: [PATCH] Staging:comedi:cb_pcidas64=>Fixed check patch warnings From: Joe Perches To: devendra sharma , abbotti@mev.co.uk Cc: hsweeten@visionengravers.com, gregkh@linuxfoundation.org, ansonjacob.aj@gmail.com, amitoj1606@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Sun, 18 Dec 2016 09:30:38 -0800 In-Reply-To: <1482055995-31664-1-git-send-email-devendra.sharma9091@gmail.com> References: <1482055995-31664-1-git-send-email-devendra.sharma9091@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.1-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-12-18 at 15:43 +0530, devendra sharma wrote: > Fixed check patch warnings about multiple line dereferencing []. > diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c [] > @@ -2476,18 +2475,15 @@ static int setup_channel_queue(struct comedi_device *dev, > for (i = 0; i < cmd->chanlist_len; i++) { > bits = 0; > /* set channel */ > - bits |= adc_chan_bits(CR_CHAN(cmd-> > - chanlist[i])); > + bits |= adc_chan_bits( > + CR_CHAN(cmd->chanlist[i])); > /* set gain */ > bits |= ai_range_bits_6xxx(dev, > - CR_RANGE(cmd-> > - chanlist > - [i])); > + CR_RANGE(cmd->chanlist[i])); > /* set single-ended / differential */ > bits |= se_diff_bit_6xxx(dev, > - CR_AREF(cmd-> > - chanlist[i]) == > - AREF_DIFF); > + CR_AREF(cmd->chanlist[i]) == > + AREF_DIFF); > if (CR_AREF(cmd->chanlist[i]) == AREF_COMMON) > bits |= ADC_COMMON_BIT; > /* mark end of queue */ This would be better handled by using a temporary like:   for (i = 0; i < cmd->chanlist_len; i++) { list = cmd->chanlist[i]; /* set channel */ bits |= adc_chan_bits(CR_CHAN(list)); /* set gain */ bits |= ai_range_bmts_6xxx(dev, CR_RANGE(list)); /* set single-ended / differential */ bits |= se_diff_bit_6xxx(dev, CR_AREF(list) == AREF_DIFF); if (CR_AREF(list) == AREF_COMMON) bits |= ADC_COMMON_BIT; Or moving the indented block into a separate function.