From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941623AbcLVRP6 (ORCPT ); Thu, 22 Dec 2016 12:15:58 -0500 Received: from mga02.intel.com ([134.134.136.20]:35869 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941026AbcLVRP5 (ORCPT ); Thu, 22 Dec 2016 12:15:57 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,389,1477983600"; d="scan'208";a="1075300602" Message-ID: <1482426736.6264.18.camel@linux.intel.com> Subject: Re: [PATCH 2/2] HID: intel-ish-hid: format 32-bit integers with %X From: Srinivas Pandruvada To: Nicolas Iooss , Jiri Kosina , Benjamin Tissoires Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 22 Dec 2016 09:12:16 -0800 In-Reply-To: <20161222100910.6179-2-nicolas.iooss_linux@m4x.org> References: <20161222100910.6179-1-nicolas.iooss_linux@m4x.org> <20161222100910.6179-2-nicolas.iooss_linux@m4x.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2 (3.18.5.2-1.fc23) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-12-22 at 11:09 +0100, Nicolas Iooss wrote: > In ishtp_hid_probe(), use %04X instead of %04hX to format __u32 > values, > in order to silent a format error reported by clang: > >     drivers/hid/intel-ish-hid/ishtp-hid.c:212:3: error: format > specifies >     type 'unsigned short' but the argument has type '__u32' (aka >     'unsigned int') [-Werror,-Wformat] >                     hid->vendor, hid->product); >                     ^~~~~~~~~~~ >     drivers/hid/intel-ish-hid/ishtp-hid.c:212:16: error: format >     specifies type 'unsigned short' but the argument has type '__u32' >     (aka 'unsigned int') [-Werror,-Wformat] >                     hid->vendor, hid->product); >                                  ^~~~~~~~~~~~ > > Signed-off-by: Nicolas Iooss Acked-by: Srinivas Pandruvada > --- >  drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/intel-ish-hid/ishtp-hid.c > b/drivers/hid/intel-ish-hid/ishtp-hid.c > index 277983aa1d90..cd23903ddcf1 100644 > --- a/drivers/hid/intel-ish-hid/ishtp-hid.c > +++ b/drivers/hid/intel-ish-hid/ishtp-hid.c > @@ -208,7 +208,7 @@ int ishtp_hid_probe(unsigned int cur_hid_dev, >   hid->version = le16_to_cpu(ISH_HID_VERSION); >   hid->vendor = le16_to_cpu(ISH_HID_VENDOR); >   hid->product = le16_to_cpu(ISH_HID_PRODUCT); > - snprintf(hid->name, sizeof(hid->name), "%s %04hX:%04hX", > "hid-ishtp", > + snprintf(hid->name, sizeof(hid->name), "%s %04X:%04X", "hid- > ishtp", >   hid->vendor, hid->product); >   >   rv = hid_add_device(hid);