From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756068AbcL0DbO (ORCPT <rfc822;w@1wt.eu>);
        Mon, 26 Dec 2016 22:31:14 -0500
Received: from mail-pg0-f45.google.com ([74.125.83.45]:33548 "EHLO
        mail-pg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755146AbcL0DbN (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 26 Dec 2016 22:31:13 -0500
Message-ID: <1482809468.3862.6.camel@canonical.com>
Subject: Re: [PATCH 1/2] ASoC: rt5660: Add ACPI support
From: Shrirang Bagul <shrirang.bagul@canonical.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        Bard Liao <bardliao@realtek.com>, Oder Chiou <oder_chiou@realtek.com>,
        Liam Girdwood <lgirdwood@gmail.com>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>
Date: Tue, 27 Dec 2016 11:31:08 +0800
In-Reply-To: <20161219154428.qedy4fxmtsvownvh@sirena.org.uk>
References: <20161219135147.24208-1-shrirang.bagul@canonical.com>
         <20161219135147.24208-2-shrirang.bagul@canonical.com>
         <20161219154428.qedy4fxmtsvownvh@sirena.org.uk>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-bpIMdyIRQAB00TiOtVi6"
X-Mailer: Evolution 3.22.1-0ubuntu2 
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--=-bpIMdyIRQAB00TiOtVi6
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2016-12-19 at 15:44 +0000, Mark Brown wrote:
> On Mon, Dec 19, 2016 at 09:51:46PM +0800, Shrirang Bagul wrote:
>=20
> > +static const struct acpi_gpio_params audio_wake_intr_gpio =3D { 0, 0, =
false
> > };
> > +static const struct acpi_gpio_params lineout_mute_gpio =3D { 1, 0, tru=
e };
>=20
> Can we please write these in a fashion more idiomatic for the kernel and
> useful for human readers with named struct fields?
Okay, will update in ver. 2 of the patch. Thanks.
--=-bpIMdyIRQAB00TiOtVi6
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQI6BAABCAAkBQJYYeB8HRxzaHJpcmFuZy5iYWd1bEBjYW5vbmljYWwuY29tAAoJ
ELlj3b/+u+hkeHMP/Razg3jYOTiblXJ0/9qE0WQvESZze6pknqBm+OgFibUZeNwn
gXcM2RbEYllAeeQJf+1oZNbuRtZ5+1uXJ8+fTXwmmUnZR32scKe2nnIp1JUvKDV5
pR3iXhyPaLnmQUuYjkDFvIVVW10LlSiFmvdmwAGlxaXA/r83AD9/5PtsLPQQVyBv
oiqN+BFAc9THP/NT8QawsVYrsqbS2G7e3B+dcOKD+U+S5vqNzCZuEzDHqQYTmXDD
Da6OjDZkyXZEfk8UkbJHh6Y2Ij7O0/ZPY7UUpgma43LvKi+X8gmcXo+Zbwvfv+JL
+fUdc8iqbTX4muMxsS3yzi83xG0zptIHT/Pph41Lme4y5ExuQBsW0m+CWKJgC8by
60gHqp3AQ6uD+KrpKwPSo/zF/oGH2Bht/PahcKI+orI2/rQ/iQ9myGV6k85VQ1h5
DAVLUoUgZEwNH3+uIGCnql1o55Fv2vLsWYmUY1eYvMQQaBEbV7c2Ku7lbg6Kc+Bj
4cqRjIz7gmTbKaC500sfd7wf8V40dldlKruifxd8xT3WkYKGBjo+oEok7yOt9wBo
e9oEuN9NXg9qGuaOWG3lEMKEB3kVL60NDqX1jbqiDNPm1SxT6k6mh+KrTWNYRwA7
rAvnpNCdgU2c8gtuauwOBnD6jgKA0LCrYDZj8bLhnSozTR3zy+9BWh3xFWsY
=rCm2
-----END PGP SIGNATURE-----

--=-bpIMdyIRQAB00TiOtVi6--