From: Joe Perches <joe@perches.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: gidisrael@gmail.com, davem@davemloft.net, nhorman@tuxdriver.com,
akpm@linux-foundation.org, geert@linux-m68k.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] This continues from this commit: 52f5684c8e1e ("kernel: use macros from compiler.h instead of __attribute__((...))")
Date: Sat, 31 Dec 2016 08:31:20 -0800 [thread overview]
Message-ID: <1483201880.1955.10.camel@perches.com> (raw)
In-Reply-To: <20161231090325.GA16976@gondor.apana.org.au>
On Sat, 2016-12-31 at 17:03 +0800, Herbert Xu wrote:
> On Fri, Dec 30, 2016 at 04:49:28PM -0800, Joe Perches wrote:
> >
> > Perhaps it'd be better to remove the declaration/prototype
> > of crypto_ablkcipher_show and surround the definition of
> > crypto_ablkcipher_show with #ifdef CONFIG_PROC_FS / #endif
>
> No that's stupid. We want to maximise the compiler coverage.
stupid is rather a strong word for the most
common technique used in the kernel to avoid
compiler warnings.
next prev parent reply other threads:[~2016-12-31 16:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-31 0:41 [PATCH] This continues from this commit: 52f5684c8e1e ("kernel: use macros from compiler.h instead of __attribute__((...))") gidisrael
2016-12-31 0:49 ` Joe Perches
2016-12-31 9:03 ` Herbert Xu
2016-12-31 16:31 ` Joe Perches [this message]
2016-12-31 9:04 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483201880.1955.10.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=gidisrael@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox