From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755181AbdAAOhz (ORCPT ); Sun, 1 Jan 2017 09:37:55 -0500 Received: from mail-bn3nam01on0078.outbound.protection.outlook.com ([104.47.33.78]:24621 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754991AbdAAOhy (ORCPT ); Sun, 1 Jan 2017 09:37:54 -0500 X-Greylist: delayed 933 seconds by postgrey-1.27 at vger.kernel.org; Sun, 01 Jan 2017 09:37:54 EST Authentication-Results: spf=pass (sender IP is 74.221.232.54) smtp.mailfrom=sandisk.com; broadcom.com; dkim=none (message not signed) header.d=none;broadcom.com; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac1c2133-ba3ff70000000ec6-3c-58698b8f6049 From: Bart Van Assche To: "jejb@linux.vnet.ibm.com" , "hch@infradead.org" , "jbaron@akamai.com" CC: "linux-kernel@vger.kernel.org" , "sagi@grimberg.me" , "sathya.prakash@broadcom.com" , "suganath-prabu.subramani@broadcom.com" , "martin.petersen@oracle.com" , "hare@suse.de" , "linux-scsi@vger.kernel.org" , "hch@lst.de" , "davem@davemloft.net" , "Sreekanth.Reddy@broadcom.com" , "chaitra.basappa@broadcom.com" , "dledford@redhat.com" Subject: Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands Thread-Topic: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands Thread-Index: AQHSZDpw6n/1deRsO02VFgm/NvDDkg== Date: Sun, 1 Jan 2017 14:22:11 +0000 Message-ID: <1483280506.5512.1.camel@sandisk.com> References: <1482985824-7270-1-git-send-email-jbaron@akamai.com> <20161229080250.GA11605@infradead.org> <1483226343.2518.32.camel@linux.vnet.ibm.com> In-Reply-To: <1483226343.2518.32.camel@linux.vnet.ibm.com> Accept-Language: nl-NL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.28.1.254] Content-Type: text/plain; charset="utf-8" Content-ID: <4FB5EA17D8535C4DA4CE240D192FBA4B@sandisk.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA02SbUhTYRTHee6bV+foadn2ZC7dkkAjp+aHi4RIL3aDPvShcPRCDr3oUqds KloQKyRKjeYLNq9WY0pNizQXJDotlyJlutBMNFIrNZaaikmmeMk5Ir/9nvM/v+ecD4fGJQIR SGt1OZxep8lQUn7EkyAgHCgr1qojvw+GMXNzdoypcRUSjNu1QDIOaxnG9JqsGFP/uBtjzLU9 JNNQqmMGW2sopni4hWIe9QgY83RmnmCa7o8STNXylA8z/e58/Da2vMuCs/x4H8U+rx/BWNfY M4K128LZCaedYNtGjBS7ODVKsPMdQxRr773CLjXvOSU663cohcvQ5nF6VVySX9p1m4XKbpXl j7XfIY1gVloEfGkEY9AtwUIUAT9aAuswVPL1F+kJJNAF0FB/tIcpGI2qTY7NpgBYvFF/Pwg8 DxyaSLRatIp5unbAY6jSXEV5OAAmoBU3T3o5Ar18WL1ZJ2AounajAvewGEahzs+dwDu6GqCy ia7Nj3xhLLKV/NgIaBpAOSqcEXnKOJSh0ckHmHdtiOocLtzLO5H7m0B6OQQt2QTKo+IwDDW2 qrxqLDKvWEkvK1BF8Rcf7wrb0ZuqScIEpPyWCfx/m99i81tsfottAWQDkBo0yYbMVC47KibC oNGlaA3pEclZmc1g8yoUB1uA0HTcCSANlP7ipNw0tYTU5BkKMp0A0bgyQKwQa9UScYqm4DKn z7qoz83gDE6wmyaUMnHwq7YzEpiqyeHSOS6b0/9LMdo30Aj0/jkDY0c7781JWkW/2/eqyunu oLUP7dY4kUqUl/B2UccjfrroqvHTBWWS2Sm9dGKf9Y+QP903bqp4vS7I5LcpecH+9f7K5bR4 S8eAwiRJPC077EMekZY2DO+626j+GHxzsX6+2fEzdETet2Cz1b5wn5tV2ULcS8rEyJNrVUrC kKaJCsf1Bs1fStalLBEDAAA= X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:74.221.232.54;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(39410400002)(39860400002)(39850400002)(39450400003)(39840400002)(2980300002)(438002)(377424004)(189002)(24454002)(199003)(81156014)(4326007)(8676002)(54906002)(356003)(5001770100001)(2950100002)(229853002)(7416002)(50466002)(38730400001)(2270400002)(5660300001)(97736004)(68736007)(189998001)(81166006)(3846002)(102836003)(2906002)(86362001)(6116002)(33646002)(23676002)(69596002)(103116003)(47776003)(106466001)(2900100001)(54356999)(106116001)(305945005)(8936002)(7736002)(626004)(2201001)(76176999)(92566002)(2501003)(50986999)(4001150100001)(36756003)(7099028)(32563001);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR02MB389;H:sacsmgep14.sandisk.com;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11OLC010;1:q3ajPCo6Pye9Yu1tt3Fjb7qIqiy8YWBTqqXR+WFjyrhKOxWhMf2TyLY7/3n7SuzPhpHM1OTgStNdmN4GFLc96j0wv0UvM8Qe9SbJGk5NPXOF8FSj/L1ikJkoJHyruMBMS4wqfRanQrdghqW4jEQYnoNhtaOIfN9Itntqdt51Geh6T4j41/AH/Pt+65V4mJbRgWfFQ4vz6aZF7a/qDT6Xse+a/HWceU4sjRCJ0Cbw/LI2jfBa72l3xAYfny1aGqECwryQNVmVDoFz0N0aUpfbZxK1wRJAtD7/7jRbVmnwvT5RPvTjxFRgRsnnwhamYYczQ9MjeB+MJspAJVFmP4OV0vduND+eViHLSD8/09Wbg40cXEk9M5M9NcZOIa4lBEWk28M7p5n/4MFhu3wLMF2wbD7oqqKQLp+YT8ZVVvMzPRM+nK+jUwwEkanxAiwJVOFo3yuOVzL3/Q/hIvKDZ2YlCBEDjgDbWZH19wGGfGmstsS8ChM1yiNG/+zcdANP8sLlDQMO2ZSN/Ku7TVGBy4EFfE1czjtBTaISgn3OvQ4xNa3hEngIHswLKm9/RFozFx2IeFIjUCpTm1p4nZigc0gGyA== X-MS-Office365-Filtering-Correlation-Id: b219c228-0420-4ecd-b45e-08d43251982b X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(8251501002);SRVR:BLUPR02MB389; X-Microsoft-Exchange-Diagnostics: 1;BLUPR02MB389;3:2JSQgXJEAWvnQyl8ppOdItV4cyZZ9Gfqt5QV9lGUgOnFsnzFqxSn3ByhGctLpdNllLUNCEc45BhIeSO750MZidInzzVektaLkcy63rMmjywckkOLilVw1+Oj5iH0Nvzee437Pcr0KnuIr1+oUuv0I5LxDRNoVK6H0hl1g/jQFEhUU9VcVmmNCZRPIlplCBVHFcDS8O3qQ8rifvgjM3nZNXW6B13UEBy9SvLVMz5DYdSmLoaSDio5+QDiJYhJBNCHnuC03izzxcp6N3vLR9yM9GKubzndn8KtMLHYbNU5FrmUGFApm3VF5Z/u+G3uQS4DjUbKQao5y9XnjadnSK9no8YfdmXA0KfZkld4qbfn7S72xYiBmSKhqD+QpGO8y0XBVGVzrZ5SAjq17u1bVaaCtA== X-Microsoft-Exchange-Diagnostics: 1;BLUPR02MB389;25:GRd/e3iYHafW40Gnv+tMp8dqBWtFis4F1c1TYvjpWzU7W0Tq5goL0nILJbjRr6VES8iF9RGsJ2sYqhAixZDZqtl54NzMAptZ4eCHIbeowH5K3aYNZ5HSsUF+IrN5h9D9kU8d3SMwGejk2ZlKi5fA0rWGaLoNusaEXTeLGv/grcT4ascYwExmNpWqgawAj4UQpaBelK17FloEw8yjP+rSqEHd+l5JP86AqQYjo2lqZyVCzErk/lsSM9loSD1x4Nr3atB684yE05G5CU4VxnEZNELKS0JnclJ9yeAfM+Nq4njVC2oUFZc4BZzDla/3zHMBOqvTFmUnUwjty/rRS7NvwTvRVLHFQLKRii3EyZn9IVwDZAdHCRIf422iYoBzYKYRESN5+DDT0Lw7yb/8Lm8CBHVgvGRDV+u0e9AuAy5eX2KaptzIG6zVfqzYsVjHM7rM8ISnS3feWcnEWzqcYpFfdAQdYr9tC8KMubovJ+I4+Aws4W/kZgvz/esdb69diquR/1Bi5kwDVEE3EoaXxc7j6R/IvAQRuexq/6r1mWEfx5i8h0Aj8u6/iALD5flvwmRw+gG1uPrUartgpweSC90CvuMFM+LFRk5vCffqMn9IpcMn1MtbmijUxcKn+9odQArE9KABR31MAWA6rYVtNKTtfThf2YS77TSuj92tPU+BgASnS/ZKOveCygsRwyrreGr7EmnGdN+OfWLHTRZh25HGI2UwR+FkAzlb38rAdXaVs/6PaWCFs0f+u9eRM94W2AL/QPqm0BEST1ZDyezICNqliQOxTGKXev/UMwJ/Obv8LRHgS2o7IJWuZuFX9Z9iTusD X-Microsoft-Exchange-Diagnostics: 1;BLUPR02MB389;31:mXogWmjzdEJZowjSSZFawg4vW5f2WvtBg2GJ7uQ//4gk1fDiIEluGQPQ4GO2QPIpFtn3DDM0jt3ONNOYFwEZBNMk5ZkksJRaNRBPD4Nl+KGOqwii7kXYrxHn3jvD5l6lcdfKVxWQKhQKTiaSUSDxf3dPnNLZfyICe8AVfJeSb5jFC9M/BWzgCZAwpfqtNbshxS8DOACgU/Mze31oywnaxsmy58bz/GKCS0UwZqk6OfSFvFsDeR/WmjbGtazc/NrIPKzkJgTSuNef3oZNBHM9K1WvPA3Htc8SknUvodXZuyA=;20:VrKSStgGzJflOhkdumJgdvtxvTIzNUmxZbEZ7LoauaH5h2SyvxCejBDuvYT9HFxrq0loiGtYRRLEmTD0oGxOnacSZw76crhKFYXe5H+tL1K8INjidjU9pNTYux79IAfjuvFw49p6MBkq/QLMWUKxbe4hYdcwRdvJnv3FnUee3V82S1m+SHgFRkOjt/jEioCxSRyNBur/zhI437KipVwpFbeT4EOlBL6SSUM6c+nLXJUxsiMitPN8MMvraLiz1M6oUIISs8mKdusZc7nyff5Z7LRbHnVDr+HR7E3XLOMGq3WLkIgQLf6quqYU5Vhqr7GoGQ0nuN6aBEajxNQfFRNz4NurB9mmxQqeW4nfWJ6Vc+UBAQVjVh6Yp4n6c66GqSqTx+1MObddTvITCTZ/FwLsblQ/NfYcG4/U3cuQ0nXjdb4LeJCF024nD1hAfr5nkSTGXwACsp5Z9iHbltva30iJ6U9ro1VPJBZk8v8fFAej6+EgLpF0GFClQOqE7td6pQ7V X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(17755550239193); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(13024025)(13023025)(13015025)(13017025)(13018025)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6041248)(20161123564025)(20161123562025)(20161123555025)(20161123560025)(6072148);SRVR:BLUPR02MB389;BCL:0;PCL:0;RULEID:;SRVR:BLUPR02MB389; X-Microsoft-Exchange-Diagnostics: 1;BLUPR02MB389;4:yFpUKfvoYjYd4OPIlfEgnmzJVfodJfx8jlkxbFsp0XzptaigRAtGVqyHjfTzTU1y5TJcuMZbM4kEl6ihR4GHllFexpWvK4hWquz1spQjdcsKj/3i1AsO4oW+22+JX+S9TVKQ4xBz0IC+YbOSgaab5DoPwU7Vu8BX2nqb35Y/w7A2ucXphLn2bGwM6sZcPoozVb6K0unwFNXHM20hYnPyrcKNemXcJ1peFWga7gdGNfjrIF+05ZaY8eboN8OSRIyu7Zih7TggdC6O2LZUFYWmuX2Y7NyAeZ/SfzMog69r+JeeMH0RF68sWCrDigha0AuZfq8g6lqIqGr2RuVlkIXrCIZUc77PnXCkXh8AUDA0ShX0JWd4o2RvtEBm5TOxdWZSEheHess6cnHO05EdWkr0pwoIY6eZeUq2z52Ca9zdTvSxD5N5XLj2AcKobGfcNn++OtEl3h0HEG3Dy6hevGo7006f+nTUPzwfj+HfqcwOM22a3982jmk/39B9ZqaPmW5wanNHOpIj0nXfE9N2jErOc5EG2VbhUTp1YelROQTcYyAImrsIwMpEX1B6qWx/WpsLbdx6zFFcmsvLeVdBv7t8eQ1VEPklbKggiCyqzAV6fFwjo1hpF6eP1sZNYZPS6/8U8bhIw0G3u+7edSYlYVNLmK9OghjqC5JYB2MOr2SRivDuSjh1t/UqPNq9kUxzLWs/+nlgVX3/v+Nhlu3MqbTSAWR9KU/gdbva9af01y6QGkY= X-Forefront-PRVS: 0174BD4BDA X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTFVQUjAyTUIzODk7MjM6UUYvZDhQR3hndUJJdVRmdTN4NVpaSkErS2dp?= =?utf-8?B?bnF1c2kwbmdRYlE1VjNWb1B5V1FpZlhPZms4WDFPcHp1bEFKV3N2UXpNTmFP?= =?utf-8?B?NW4zU2lzUTFBRHA2MEhWd3dRTllwUFR1RVlKOXpnd0N5dzdVd1FFTEhiVDdZ?= =?utf-8?B?cXEwbVFkSU90a1NzTm9qU0NoM3c5MFlyV2pIdjBsaFczRnRpZkN2VUNYTXdw?= =?utf-8?B?OWo2clA3eFU5bW9teHlyWmZBMDZnQU83ODhnWmR1SndTbnYwQ3JZa0swcDhr?= =?utf-8?B?UkpBa0h5V1pNRVAzZVBVMUQxUHJQYnZSbG5JOHhaVWxBMjNNMnY1Z1pxRmRD?= =?utf-8?B?TVlQMjAybzJscVloNzlObW5KSnk0KzkwY2pUV2M3a3E4TU5jSzUxSEhlUWpz?= =?utf-8?B?dGluMjVyYkVGTWJ5UXM5elQ1R1hJbEQzQi8xQlNCZXFqMG1aNzFmdHpFOVdj?= =?utf-8?B?ZENubjNYWDJ0Kzl3eXE0WGFIZXI1WDVnaWxKbGJ2amorRDEyZ1loTjVDeWFP?= =?utf-8?B?SENUdktIUHZiWmxxVUJOWUVQOGRPa0Fpck15TTIxUFNHbE1VbnUrakdnK2M5?= =?utf-8?B?ZTJ2NzkvWGhHalpQMllKMkhlNXpHbFdjRVd1aThsQy9ESDJDZTRwZ08wWlo2?= =?utf-8?B?Q3FFNGNsd3h4cWFGK2tMSm9VQ0NLb2svUmQ3SWRYb2QxZGlhdzZSTjlhUDQv?= =?utf-8?B?bmRkdWtTOGhuZUxxMUZlekd4ZGVMWTcxNU9EcHNwV0pVVUNhSTRyczh6eFRt?= =?utf-8?B?S1VoM2dCY0tmYUxaKy9JVkRJVmNtSWh3dWszNFdDT3haMlBES2RHUkJGSTZ5?= =?utf-8?B?YndkUkFVdklPTEhJS2V5aStRM3BGUTh0am1KL245K2UzdlhGbXZMUUxhWDhi?= =?utf-8?B?R2U1aEdUd203ZCtuMGRaWDFSQUs0d1FKeWk3K1BhcE15QTlncytnSzBBUEto?= =?utf-8?B?T1lORWxJYnJKTVc5TlZTY0NYa21nd2hXaE1ZalJtM1paRmtjR2FnTjBQMkN1?= =?utf-8?B?WjB6ckhZd1AvZ3RLT1kyNjV1ZmVST2tmbHd6RVl3MkN3bncvVmZhSmsrZEIy?= =?utf-8?B?UGorbGVDTmFSUXZWc24zMWFKVGRaOXEvUUV4NGtVSUJ1bXB0QitrNVJyWmZL?= =?utf-8?B?L0pWUDVJUG83RHRTV3hLNUJyUWk5d1BYNk0rWU4zN0hsUE9qVjhybVNLY0JV?= =?utf-8?B?a1R2U2QzVWtqNGNhakREeGJ0bVBMeTBFazVZcVJIL2szNlgvNnRzdGRwR0tF?= =?utf-8?B?alYyMDVOT0N2VFAzUTVCWmFjdHFGT3pRMVdZeE5UVGgyWk9vekpSaEVyM1Nw?= =?utf-8?B?MUpLQ0tCaTZYcWxmV0kzb2FscHlYUEdKUUlFaXVjbmN1R01oWFB6ZVU2VXBN?= =?utf-8?B?SmNxYURFOGQ2UE5HblV4Tmhlam80dU53b1NGRjJJVDB6cE1rUEhwZ1NFNWR3?= =?utf-8?B?ZFd5SkpXNTc4OG42UFhtSTFUOUtEZjFVanYycHl1TWFjVS9Qam5Zdm9IVXV1?= =?utf-8?B?QS8ySU41dnVJRGdFRW5GUWxWZGRmSUcza2w2U1J4RW1vc1V5YWdOY3hQazA4?= =?utf-8?B?OUZReHRSSUlMRzZCdEp1ZXlQV0QzSm5NZk1heUlNc2FZYm5oOHF4UHBVbFVO?= =?utf-8?B?dXdxZG9sSUY2cVVxbURkaEVkVWxKUVV0a2MxRXhGR0FabVF2ZldZaE1rUk52?= =?utf-8?B?cTZyTXZuVGFYM2xDcmJNcWJ5WlpWelVRTEh3d1ZybXBsWHhmWDNCMERXVkJH?= =?utf-8?B?RSs2YnFpSFR0VnNDYnZGcy9xRVVRV1JITXVmcys4TTlHVktCSkJEa0NXQTh6?= =?utf-8?B?M3ZHRHI0d2dvbTRMZktqNmJQTUVEemNrUTBLUDlIUEVQOTcxTHBUNGpYbHpx?= =?utf-8?Q?kuKRJo5a7Y=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR02MB389;6:X3V+2vUnU1jx12VbMJVgdUZzuNrhq2S2vR2Oe18wQTJItquJo6YbEnwibr1MdWxgbRBKK4ZClT/pRzu9jOmaNMdbpm/MnLfSkF2ZEdIrmqCyFszxlQGQoS/5PLMCnbippAk5Dg+l+W2gJzMgqpT2OktDBrHJO8emsVfu4pqDNwt/8PPtUI/fFiNP0X38cxypU9yVkpUocu7CYywrg04d9lt/pfc2YHBICUHqRNN3hZW4OUmNYXmemMs2u8epOKSDh4ydq+RWoEnn3Lh2eRPZv67/Swqh4lFPqDnt3xRZf/UTQsLm02IkY0zKMaIE/XDGdbf9oEED5sm46A6faO76riVkt3ql5kNjxViFSEUqSIvuyzUO3WOGV1qW9ydUKt78IJmiHLNCRpSnPYftzN/FCeRGS3ES+0psgJmIbbWXn/eV8t+Wg5gx/duAUFRDJcacsOOjAI3hJuxlODvkzeWQ3Q==;5:PKor3VVU23LoUGZNh2VPmX1EQhNagKhQUHn0c1h0zCrk2xRGSdZJvO+yhrkpjjFlHNQDcpE/iBukahG4AG6SPCyek1VyMAc/9VpdyVz7VsJZ9C9a66Gvhp5/1cIK23ZeYK+qXk7ci4ekdKGDqXW/gg==;24:7dQ5MXLjzSACC1SgwCgEB5g3eyk9E9U/tvXP3NCwrzAsUTVOMetBE4eXY7LkCH9EnqDyqPu6YEJYP1zM5GHcf4hsh+UurPjDYsHYvI1EbG8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BLUPR02MB389;7:PuJIqpXb1euNf108P7mvFG/88sGuSKeSknDdjZJUiAZs4BLjp9e1B7Dlej/6ZpUpAGsWmTTjSUBPfT5lnBa14tiU5Z2nItAK0EEul8HdVloCg1sFuRBQoeBIfBUwwgZh9VxRh3qKZd9X1rZ9wv1upFaRydYcqQUXHa6aV3LUaY+wUdMqMAlaEjRyYw5GQz6xlJnx/zKuISDvAP4GPAurC/n5NvJXGLlrEpX2bE4vvhuBMm8zHQYlv/0N/8+O/iGnTFkXc43qKQjaDoRvVInASuuntm6HYld9VHmDwxc/SnmfcJrg8MdTf7pKaHvay67u4DBzO7RP2a3P5axfQ9c4wjYKBbyhu2ExH69TOEPGz2CHOmSR96QZna7hWL5+A6VvUOCmReW3SKhxKaBXCuL62hzrBKGpAODFClIysYpzWy+PnJAzY7L0KXc23NGPi3cEpk4Hs5lTt+W2oSBe0MpmVQ== X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jan 2017 14:22:17.9875 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[74.221.232.54];Helo=[sacsmgep14.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR02MB389 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v01Ec7Vn022744 On Sat, 2016-12-31 at 15:19 -0800, James Bottomley wrote: > On Thu, 2016-12-29 at 00:02 -0800, Christoph Hellwig wrote: > > On Wed, Dec 28, 2016 at 11:30:24PM -0500, Jason Baron wrote: > > > Add a new parameter to scsi_internal_device_block() to decide > > > whether or not to invoke scsi_wait_for_queuecommand(). > > > > We'll also need to deal with the blk-mq wait path that Bart has been > > working on (I think it's already in the scsi tree, but I'd have to > > check). > > > > Also adding a bool flag for the last call in a function is style > > that's a little annoying. > > > > I'd prefer to add a scsi_internal_device_block_nowait that contains > > all the code except for the waiting, and then make > > scsi_internal_device_block_nowait a wrapper around it. Or drop the > > annoying internal for both while we're at it :) > > OK, I know it's new year, but this is an unpatched regression in -rc1 > that's causing serious issues. I would like this fixed by -rc3 so we > have 3 options > > 1. revert all the queuecommand wait stuff until it proves it's actually > working without regressions > 2. apply this patch and fix the style issues later > 3. someone else supplies the correctly styled fix patch > > The conservative in me says that 1. is probably the most correct thing > to do because it gives us time to get the queuecommand wait stuff > right; that's what I'll probably do if there's no movement next week. > However, since we're reasonably early in the -rc cycle, so either 2 or > 3 are viable provided no further regressions caused by the queuecommand > wait stuff pop up. Hello James, My recommendation is to revert commit 18f6084a989b ("scsi: mpt3sas: Fix secure erase premature termination"). Since the mpt3sas driver uses the single-queue approach and since the SCSI core unlocks the block layer request queue lock before the .queuecommand callback function is called, multiple threads can execute that callback function (scsih_qcmd() in this case) simultaneously. This means that using scsi_internal_device_block() from inside .queuecommand to serialize SCSI command execution is wrong. Bart.