From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761440AbdADR4G (ORCPT ); Wed, 4 Jan 2017 12:56:06 -0500 Received: from foss.arm.com ([217.140.101.70]:55384 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761405AbdADR4B (ORCPT ); Wed, 4 Jan 2017 12:56:01 -0500 From: Sudeep Holla To: linux-kernel@vger.kernel.org Cc: Sudeep Holla , Peter Zijlstra , Ingo Molnar , Jiri Olsa , Stephane Eranian Subject: [PATCH v3] tools: perf: fix linker error when libelf config is disabled Date: Wed, 4 Jan 2017 17:30:02 +0000 Message-Id: <1483551002-26501-1-git-send-email-sudeep.holla@arm.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1483545363-11393-1-git-send-email-sudeep.holla@arm.com> References: <1483545363-11393-1-git-send-email-sudeep.holla@arm.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When libelf is disabled in the configuration, we get the following linker error: LINK libperf-jvmti.so ld: cannot find -lelf Makefile.perf:515: recipe for target 'libperf-jvmti.so' failed Jiri pointed out that both librt and libelf are not really required. So this patch fixes the linker error by getting rid of unwanted libraries in the linker stage. Fixes: 209045adc2bb ("perf tools: add JVMTI agent library") Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Jiri Olsa Cc: Stephane Eranian Signed-off-by: Sudeep Holla --- tools/perf/Makefile.perf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) v2->v3: - Corrected the original commit under "Fixes:" tag that introduced the libraries initially v1->v2: - Dropped libelf and librt as they are not required diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf index 8fc24824705e..9e4a7ea84637 100644 --- a/tools/perf/Makefile.perf +++ b/tools/perf/Makefile.perf @@ -512,7 +512,7 @@ $(LIBJVMTI_IN): FORCE $(Q)$(MAKE) -f $(srctree)/tools/build/Makefile.build dir=jvmti obj=jvmti $(OUTPUT)$(LIBJVMTI): $(LIBJVMTI_IN) - $(QUIET_LINK)$(CC) -shared -Wl,-soname -Wl,$(LIBJVMTI) -o $@ $< -lelf -lrt + $(QUIET_LINK)$(CC) -shared -Wl,-soname -Wl,$(LIBJVMTI) -o $@ $< endif $(patsubst perf-%,%.o,$(PROGRAMS)): $(wildcard */*.h) -- 2.7.4