From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934906AbdAJKPb (ORCPT ); Tue, 10 Jan 2017 05:15:31 -0500 Received: from mx2.suse.de ([195.135.220.15]:45792 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934625AbdAJKP2 (ORCPT ); Tue, 10 Jan 2017 05:15:28 -0500 Message-ID: <1484042931.4750.1.camel@suse.com> Subject: Re: [PATCHv14 2/3] usb: USB Type-C connector class From: Oliver Neukum To: Heikki Krogerus Cc: Mika Westerberg , Guenter Roeck , Greg KH , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Date: Tue, 10 Jan 2017 11:08:51 +0100 In-Reply-To: <20170106105405.GA31031@kuha.fi.intel.com> References: <20170105110119.87401-1-heikki.krogerus@linux.intel.com> <20170105110119.87401-3-heikki.krogerus@linux.intel.com> <20170105155402.GG3353@lahna.fi.intel.com> <20170106105405.GA31031@kuha.fi.intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-01-06 at 12:54 +0200, Heikki Krogerus wrote: > Hi guys, > > On Thu, Jan 05, 2017 at 05:54:02PM +0200, Mika Westerberg wrote: > > I wonder if "source sink" instead is better? Along the lines of > > /sys/power/state. > > > > Then you can print "[source] sink" when source is selected and so on. > > That is more or less how I originally proposed how we list the roles > in general. I introduced the separate "current_*_role" and > "supported_*_roles" attribute files because somebody wanted them. I > don't remember the reason why they were preferred to be in separate > attribute files. Neither do I. > > Oliver! Guenter! Do we really need to list the current and supported > roles in separate attribute files? Can't we just have the "power_role" > and "data_role" attribute files for the ports instead of the separate > "supported_*_roles" and "current_*_role", and show the current role > like Mika proposes? I definitely would prefer it that way because it > is similar style used in other places like Mike pointed out. Either way would serve. > And since we are talking about the ABI, can we also change the listing > of the accessory mode back to just "audio" and "debug" like I > originally had it? I don't remember who and why wanted it to be > changed to "Audio Adapter Accessory Mode" and "Debug Accessory Mode", > but it differs from the style we list the other details. Yes, but can we differentiate analog and digital audio? Regards Oliver