From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933532AbdAJQbh (ORCPT ); Tue, 10 Jan 2017 11:31:37 -0500 Received: from s3.sipsolutions.net ([5.9.151.49]:52626 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755619AbdAJQbb (ORCPT ); Tue, 10 Jan 2017 11:31:31 -0500 Message-ID: <1484065886.1014.3.camel@sipsolutions.net> Subject: Re: [PATCH] checkpatch: don't warn on every struct without const_structs file From: Johannes Berg To: Joe Perches , Andrew Morton Cc: linux-kernel@vger.kernel.org Date: Tue, 10 Jan 2017 17:31:26 +0100 In-Reply-To: <1484065662.12006.2.camel@perches.com> References: <20170110140318.737-1-johannes@sipsolutions.net> <1484060517.2106.38.camel@perches.com> <1484060672.1014.1.camel@sipsolutions.net> <1484065662.12006.2.camel@perches.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.2-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > I copied checkpatch elsewhere and ran it. > > Why do you want to copy checkpatch "someplace else"? > Instead of copy, I think you should soft link it. Well, no, I have to distribute it with that. > > Regardless, the current code is utterly stupid - it prints a > > warning that it won't flag any structs, and then proceeds to flag > > all structs. > > > > If you must, send a patch to abort() [whatever the perl equivalent > > is] when the file can't be found, but as it is, the code is just > > idiotic. > > Maybe so. > > As is, your patch description is incomplete because > it doesn't mention your use case. I don't think that's relevant. The script is internally inconsistent, as I do mention in the commit log, which is worth fixing. johannes