From: Joe Perches <joe@perches.com>
To: Bogdan Purcareata <bogdan.purcareata@gmail.com>,
labbott@redhat.com, sumit.semwal@linaro.org,
gregkh@linuxfoundation.org, arve@android.com,
riandrews@android.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: android/ion: Fix coding style issues
Date: Tue, 10 Jan 2017 14:12:49 -0800 [thread overview]
Message-ID: <1484086369.12006.9.camel@perches.com> (raw)
In-Reply-To: <c6aed1d5-dafb-9e3b-dfec-24ccafed3a3e@gmail.com>
On Tue, 2017-01-10 at 23:40 +0200, Bogdan Purcareata wrote:
> Fix following checkpatch warnings:
> - Lines over 80 characters
> - void function with return statement
> - Unaligned comment mark
> - Header function prototypes missing variable names
Please read Documentation/SubmittingPatches
(umm, make that Documentation/process/submitting-patches.rst)
Make sure to send the patch to yourself only until
you know you can apply it correctly and then send
it to the mailing list.
btw:
This should probably be a series of 4 patches, each
single patch doing one of the things listed above.
And do please use checkpatch on your proposed patches.
next prev parent reply other threads:[~2017-01-10 22:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 21:40 [PATCH] staging: android/ion: Fix coding style issues Bogdan Purcareata
2017-01-10 21:47 ` Greg KH
2017-01-10 22:12 ` Joe Perches [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-01-11 21:20 Bogdan Purcareata
2017-01-12 7:36 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484086369.12006.9.camel@perches.com \
--to=joe@perches.com \
--cc=arve@android.com \
--cc=bogdan.purcareata@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=riandrews@android.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox