From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux@rasmusvillemoes.dk,
arnd.bergmann@linaro.org
Subject: Re: [PATCH v2 1/1] lib/vsnprintf: Add %par specifier for sake of consistency
Date: Wed, 11 Jan 2017 16:59:20 -0800 [thread overview]
Message-ID: <1484182760.3065.3.camel@perches.com> (raw)
In-Reply-To: <20170111155710.77c58352c40af6daef1f262b@linux-foundation.org>
On Wed, 2017-01-11 at 15:57 -0800, Andrew Morton wrote:
> On Wed, 11 Jan 2017 18:28:07 +0200 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> > While resource_size_t is repeating phys_addr_t, allocate %par specifier for
> > that type for sake of consistency.
> >
>
> I'm struggling to see the value in this. A more detailed changelog
> would help, explaining why you think the kernel would benefit from
> this.
>
> Are there callsites which should be converted? If so, a patch which
> does at least some of those would be helpful.
A resource_size_t isn't a different size than a phys_addr_t.
Not so far anyway.
$ git grep typedef.*resource_size_t include
include/linux/types.h:typedef phys_addr_t resource_size_t;
Is there an arch that needs a different size?
If not, why add another case?
Just to make the kernel larger?
next prev parent reply other threads:[~2017-01-12 0:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 16:28 [PATCH v2 1/1] lib/vsnprintf: Add %par specifier for sake of consistency Andy Shevchenko
2017-01-11 23:57 ` Andrew Morton
2017-01-12 0:59 ` Joe Perches [this message]
2017-01-12 11:18 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484182760.3065.3.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd.bergmann@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox