From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759912AbdALA7Z (ORCPT ); Wed, 11 Jan 2017 19:59:25 -0500 Received: from smtprelay0084.hostedemail.com ([216.40.44.84]:58450 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752550AbdALA7Y (ORCPT ); Wed, 11 Jan 2017 19:59:24 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1431:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3870:3871:3873:3874:4321:5007:6119:7903:8603:10004:10400:10848:10967:11026:11232:11658:11914:12043:12663:12740:12760:12895:13069:13311:13357:13439:14040:14096:14097:14181:14659:14721:21080:21433:21451:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: cause05_6ecfc78bc6b2f X-Filterd-Recvd-Size: 1818 Message-ID: <1484182760.3065.3.camel@perches.com> Subject: Re: [PATCH v2 1/1] lib/vsnprintf: Add %par specifier for sake of consistency From: Joe Perches To: Andrew Morton , Andy Shevchenko Cc: linux-kernel@vger.kernel.org, linux@rasmusvillemoes.dk, arnd.bergmann@linaro.org Date: Wed, 11 Jan 2017 16:59:20 -0800 In-Reply-To: <20170111155710.77c58352c40af6daef1f262b@linux-foundation.org> References: <20170111162807.45736-1-andriy.shevchenko@linux.intel.com> <20170111155710.77c58352c40af6daef1f262b@linux-foundation.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-01-11 at 15:57 -0800, Andrew Morton wrote: > On Wed, 11 Jan 2017 18:28:07 +0200 Andy Shevchenko wrote: > > > While resource_size_t is repeating phys_addr_t, allocate %par specifier for > > that type for sake of consistency. > > > > I'm struggling to see the value in this. A more detailed changelog > would help, explaining why you think the kernel would benefit from > this. > > Are there callsites which should be converted? If so, a patch which > does at least some of those would be helpful. A resource_size_t isn't a different size than a phys_addr_t. Not so far anyway. $ git grep typedef.*resource_size_t include include/linux/types.h:typedef phys_addr_t resource_size_t; Is there an arch that needs a different size? If not, why add another case? Just to make the kernel larger?