From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751004AbdANNLN (ORCPT ); Sat, 14 Jan 2017 08:11:13 -0500 Received: from smtprelay0217.hostedemail.com ([216.40.44.217]:35770 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750923AbdANNLM (ORCPT ); Sat, 14 Jan 2017 08:11:12 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:69:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2559:2562:2828:2915:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3871:3872:3874:4321:5007:7875:7974:10004:10400:10848:11026:11232:11658:11914:12043:12438:12683:12740:12895:13069:13311:13357:13439:13894:14110:14181:14659:14721:21080:30012:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: part55_4443ae089ad07 X-Filterd-Recvd-Size: 1951 Message-ID: <1484399467.14692.6.camel@perches.com> Subject: Re: [PATCH] x86/platform/UV: Clean up the UV APIC code From: Joe Perches To: Ingo Molnar , Mike Travis Cc: Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org, Dimitri Sivanich , Linus Torvalds Date: Sat, 14 Jan 2017 05:11:07 -0800 In-Reply-To: <20170114082612.GA27842@gmail.com> References: <20170113152110.831599361@asylum.americas.sgi.com> <20170113152111.689032281@asylum.americas.sgi.com> <20170114075241.GA12018@gmail.com> <20170114082612.GA27842@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2017-01-14 at 09:26 +0100, Ingo Molnar wrote: > * Ingo Molnar wrote: [] > In particular the random line breaks, apparently to pacify checkpatch, were > horribly widespread. I just made the lines longer - that's still more readable > than the multi-line horror that was there before. [] > arch/x86/kernel/apic/x2apic_uv_x.c |  500 ++++++++++++++++++------------------- [] > - pr_info("UV: OEM IDs %s/%s, System/HUB Types %d/%d, uv_apic %d\n", > - oem_id, oem_table_id, uv_system_type, > - uv_min_hub_revision_id, uv_apic); > + pr_info("UV: OEM IDs %s/%s, System/HUB Types %d/%d, uv_apic %d\n", oem_id, oem_table_id, uv_system_type, uv_min_hub_revision_id, uv_apic); 140+ chars on a single line. Is this really better or easier to read? Long lines make it harder to humans to verify format and arguments used in printf type calls.