From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751722AbdAPDOP (ORCPT ); Sun, 15 Jan 2017 22:14:15 -0500 Received: from smtprelay0004.hostedemail.com ([216.40.44.4]:54236 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751677AbdAPDOO (ORCPT ); Sun, 15 Jan 2017 22:14:14 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3653:3865:3866:3867:3868:3872:3873:4321:5007:7576:7903:8828:10004:10400:10848:11232:11658:11914:12043:12050:12296:12740:12760:12895:13069:13071:13161:13229:13311:13357:13439:14180:14181:14659:14721:21060:21067:21080:21451:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: seat34_41c93b46abc25 X-Filterd-Recvd-Size: 2789 Message-ID: <1484536450.2835.4.camel@perches.com> Subject: Re: [PATCH] checkpatch: update $logFunctions From: Joe Perches To: Miles Chen Cc: apw@canonical.com, linux-kernel@vger.kernel.org, wsd_upstream@mediatek.com Date: Sun, 15 Jan 2017 19:14:10 -0800 In-Reply-To: <1484535455.17875.3.camel@mtkswgap22> References: <1484293088-17617-1-git-send-email-miles.chen@mediatek.com> <1484295257.3065.31.camel@perches.com> <1484535455.17875.3.camel@mtkswgap22> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-01-16 at 10:57 +0800, Miles Chen wrote: > On Fri, 2017-01-13 at 00:14 -0800, Joe Perches wrote: > > On Fri, 2017-01-13 at 15:38 +0800, miles.chen@mediatek.com wrote: > > > From: Miles Chen > > > > > > Currently checkpatch.pl does not recognize printk_deferred* functions as > > > log functions and complains about the line length of printk_deferred* > > > functoins. Add printk_deferred* to logFunctions to fix it. > > > > Hi Miles. > > > > Good idea, perhaps less good an implementation though. > > > > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > > > > [] > > > @@ -425,7 +425,7 @@ our $zero_initializer = qr{(?:(?:0[xX])?0+$Int_type?|NULL|false)\b}; > > > > > > our $logFunctions = qr{(?x: > > > printk(?:_ratelimited|_once|)| > > > - (?:[a-z0-9]+_){1,2}(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)(?:_ratelimited|_once|)| > > > + (?:[a-z0-9]+_){1,2}(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN|deferred)(?:_ratelimited|_once|)| > > > > This should be a change on the line above like > > > > printk(?:_ratelimited|_once|_deferred|_deferred_once|)| > Thanks for your advice, I'll modify my patch and submit it again. Hello again Miles. Actually, because perl matches the shortest match first, the deferred_once should be before the deferred above so deferred_once matches properly too. ie: printk(?:_ratelimited|_once|_deferred_once|_deferred|)| > > Or perhaps changing both lines if there are to be > > macros/functions like pr__deferred_once someday. > > > > printk(?:_ratelimited|_once|_deferred|_deferred_once|)| > > (?:[a-z0-9]+_){1,2}(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)(?:_ratelimited|_once|_deferred|deferred_once|)| Here too for both lines if you submit this one.