From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751560AbdAPN7F (ORCPT ); Mon, 16 Jan 2017 08:59:05 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:40942 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751386AbdAPN67 (ORCPT ); Mon, 16 Jan 2017 08:58:59 -0500 Subject: Re: [patch] KEYS: Fix an error code in request_master_key() From: Mimi Zohar To: David Howells Cc: Dan Carpenter , David Safford , James Morris , "Serge E. Hallyn" , linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Date: Mon, 16 Jan 2017 08:58:50 -0500 In-Reply-To: <11899.1484226513@warthog.procyon.org.uk> References: <1481907033.17553.78.camel@linux.vnet.ibm.com> <20161216090827.GA7285@elgon.mountain> <11899.1484226513@warthog.procyon.org.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17011613-0052-0000-0000-0000020A4EB9 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17011613-0053-0000-0000-0000079BACCA Message-Id: <1484575130.5538.2.camel@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-16_11:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1701160210 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-01-12 at 13:08 +0000, David Howells wrote: > Mimi Zohar wrote: > > > On Fri, 2016-12-16 at 12:08 +0300, Dan Carpenter wrote: > > > This function has two callers and neither are able to handle a NULL > > > return. Really, -EINVAL is the correct thing return here anyway. This > > > fixes some static checker warnings like: > > > > > > security/keys/encrypted-keys/encrypted.c:709 encrypted_key_decrypt() > > > error: uninitialized symbol 'master_key'. > > > > > > Fixes: 7e70cb497850 ("keys: add new key-type encrypted") > > > Signed-off-by: Dan Carpenter > > > > Thanks! > > Can I put that down as an Acked-by or Reviewed-by? Feel free to add by "Acked-by" on both this patch and Dan's other patch "KEYS: Use memzero_explicit() for secret data". Mimi