From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Christoph Hellwig <hch@infradead.org>,
Bart Van Assche <Bart.VanAssche@sandisk.com>
Cc: "torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"mingo@kernel.org" <mingo@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"sathya.prakash@broadcom.com" <sathya.prakash@broadcom.com>,
"suganath-prabu.subramani@broadcom.com"
<suganath-prabu.subramani@broadcom.com>,
"hare@suse.de" <hare@suse.de>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"Sreekanth.Reddy@broadcom.com" <Sreekanth.Reddy@broadcom.com>,
"chaitra.basappa@broadcom.com" <chaitra.basappa@broadcom.com>
Subject: Re: [PATCH] Revert "scsi: mpt3sas: Fix secure erase premature termination"
Date: Mon, 16 Jan 2017 08:14:39 -0800 [thread overview]
Message-ID: <1484583279.2540.37.camel@HansenPartnership.com> (raw)
In-Reply-To: <20170116152721.GA6677@infradead.org>
On Mon, 2017-01-16 at 07:27 -0800, Christoph Hellwig wrote:
> On Sun, Jan 15, 2017 at 10:02:51PM +0000, Bart Van Assche wrote:
> > I disagree. Even if my patch would be reverted that still wouldn't
> > fix the severe race condition that was introduced in the mpt3sas
> > driver by the patch that triggers the lockup during boot. As I
> > explained two weeks ago (see also
> > https://www.spinics.net/lists/kernel/msg2411413.htm
> > l), commit 18f6084a989b ("scsi: mpt3sas: Fix secure erase premature
> > termination") is the one that should be reverted instead of my
> > patch. I agree with Linus that the offending mpt3sas patch already
> > should have been reverted.
>
> In addition to that ATA passthrough through scsi CDBs is a fringe
> feature compared to normal operation of the HBA.
So how about, instead of arguing about reversion, one or other of you
reviews the proposed fix of the fix which would avoid having to revert
anything?
James
next prev parent reply other threads:[~2017-01-16 16:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 15:02 [GIT PULL] SCSI fixes for 4.10-rc3 James Bottomley
2017-01-15 9:19 ` [PATCH] Revert "scsi: mpt3sas: Fix secure erase premature termination" Ingo Molnar
2017-01-15 16:11 ` James Bottomley
2017-01-15 18:54 ` Linus Torvalds
2017-01-15 19:13 ` James Bottomley
2017-01-15 19:41 ` Linus Torvalds
2017-01-15 19:49 ` James Bottomley
2017-01-15 22:02 ` Bart Van Assche
2017-01-16 15:27 ` Christoph Hellwig
2017-01-16 16:14 ` James Bottomley [this message]
2017-01-16 18:04 ` Christoph Hellwig
2017-01-16 9:22 ` Ingo Molnar
2017-01-16 14:24 ` James Bottomley
2017-01-16 16:30 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484583279.2540.37.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=Bart.VanAssche@sandisk.com \
--cc=Sreekanth.Reddy@broadcom.com \
--cc=akpm@linux-foundation.org \
--cc=chaitra.basappa@broadcom.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=sathya.prakash@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox