From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1750997AbdAQIsF (ORCPT <rfc822;w@1wt.eu>);
        Tue, 17 Jan 2017 03:48:05 -0500
Received: from smtprelay0072.hostedemail.com ([216.40.44.72]:41839 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1750939AbdAQIre (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 17 Jan 2017 03:47:34 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:2898:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3872:4321:5007:7875:7903:10004:10400:10848:11026:11232:11657:11658:11914:12043:12438:12740:12760:12895:13069:13311:13357:13439:14181:14659:14721:21080:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none
X-HE-Tag: back74_7c0182c1e7400
X-Filterd-Recvd-Size: 1903
Message-ID: <1484642850.9538.7.camel@perches.com>
Subject: Re: [PATCH] staging: fsl-mc: fix coding stye errors
From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
        Dhananjay Balan <dhananjay@cliqz.com>
Cc: Stuart Yoder <stuart.yoder@nxp.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Date: Tue, 17 Jan 2017 00:47:30 -0800
In-Reply-To: <20170117082708.GC4051@mwanda>
References: <20170117081128.wrmdicglnwifu2mi@gaia>
         <20170117082708.GC4051@mwanda>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.22.3-0ubuntu0.1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2017-01-17 at 11:27 +0300, Dan Carpenter wrote:
> On Tue, Jan 17, 2017 at 09:11:28AM +0100, Dhananjay Balan wrote:
> > Split line at boolean operator.
> > 
> > Error was reported by checkpatch.pl as
> > WARNING: Avoid multiple line dereference - prefer 'mc_msi_domain->host_data'
[]
> > diff --git a/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c b/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c
[]
> > @@ -94,8 +94,8 @@ int __init its_fsl_mc_msi_init(void)
> >  			continue;
> >  		}
> >  
> > -		WARN_ON(mc_msi_domain->
> > -				host_data != &its_fsl_mc_msi_domain_info);
> > +		WARN_ON(mc_msi_domain->host_data !=
> > +						&its_fsl_mc_msi_domain_info);
> 
> Better to line it up like this:
> 
> 		WARN_ON(mc_msi_domain->host_data !=
> 			&its_fsl_mc_msi_domain_info);

At 81 chars, it might be better on a single line instead.

		WARN_ON(mc_msi_domain->host_data != &its_fsl_mc_msi_domain_info);

It also might be better to shorten some of the identifiers.