From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754265AbdARLDO (ORCPT ); Wed, 18 Jan 2017 06:03:14 -0500 Received: from mga05.intel.com ([192.55.52.43]:24772 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754224AbdARLDJ (ORCPT ); Wed, 18 Jan 2017 06:03:09 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,249,1477983600"; d="scan'208";a="1114401766" Message-ID: <1484737176.2133.191.camel@linux.intel.com> Subject: Re: [PATCH] i2c: core: helper function to detect slave mode From: Andy Shevchenko To: Vladimir Zapolskiy , Luis Oliveira , Andy Shevchenko Cc: Wolfram Sang , Rob Herring , Mark Rutland , Jarkko Nikula , Mika Westerberg , linux-i2c@vger.kernel.org, devicetree , "linux-kernel@vger.kernel.org" , Ramiro.Oliveira@synopsys.com, Joao Pinto , CARLOS.PALMINHA@synopsys.com Date: Wed, 18 Jan 2017 12:59:36 +0200 In-Reply-To: References: <73246c4a-504c-52d7-dde4-970a45dca0bd@mleia.com> <3748130b-5321-12eb-ec75-e2637dd9fc54@mleia.com> <1484240482.2133.92.camel@linux.intel.com> <7fdf5d3c-d0ea-ec45-6b18-4573fff6dd11@synopsys.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-01-17 at 01:14 +0200, Vladimir Zapolskiy wrote: > review comments then, for example it is not obvious that on a platform > with both CONFIG_ACPI and CONFIG_OF enabled there should be an > exclusive > selection of only one of two possible branches as in your code etc. ACPI and DT approach differently to this property. Like I already said to you check GPIO library where we have similarities. -- Andy Shevchenko Intel Finland Oy