From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752171AbdASKur (ORCPT ); Thu, 19 Jan 2017 05:50:47 -0500 Received: from mga14.intel.com ([192.55.52.115]:50946 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751661AbdASKup (ORCPT ); Thu, 19 Jan 2017 05:50:45 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,253,1477983600"; d="scan'208";a="810768350" Message-ID: <1484822772.2133.225.camel@linux.intel.com> Subject: Re: [PATCH v3 1/5] staging: fbtft: convert fbtft_reset() to be non-atomic From: Andy Shevchenko To: Greg Kroah-Hartman Cc: Noralf =?ISO-8859-1?Q?Tr=F8nnes?= , devel@driverdev.osuosl.org, Thomas Petazzoni , linux-kernel@vger.kernel.org Date: Thu, 19 Jan 2017 12:46:12 +0200 In-Reply-To: <20170119094914.GA5162@kroah.com> References: <20170103182949.114385-1-andriy.shevchenko@linux.intel.com> <20170103182949.114385-2-andriy.shevchenko@linux.intel.com> <20170119094914.GA5162@kroah.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-01-19 at 10:49 +0100, Greg Kroah-Hartman wrote: > On Tue, Jan 03, 2017 at 08:29:45PM +0200, Andy Shevchenko wrote: > > First of all, fbtft in current state doesn't allow to override GPIOs > > to be > > optional, like "reset" one. It might be a bug somewhere, but rather > > out of > > scope of this fix. > > > > Second, not all GPIOs available on the board would be SoC based, > > some of them > > might sit on I2C GPIO expanders, for example, on Intel > > Edison/Arduino, and thus > > any communication with them might sleep. > > > > Besides that using udelay() and mdelay() is kinda resource wasteful. > > > > Summarize all of the above, convert fbtft_reset() function to non- > > atomic > > variant by using gpio_set_value_cansleep(), usleep_range(), and > > msleep(). > > > > Reviewed-by: Noralf Trønnes > > Signed-off-by: Andy Shevchenko > > Andy, this series came through with the charmap all corrupted and git > didn't like them at all.  Can you fix up and resend? Strange. I used usual git send-email. Okay, just resent (as v4). -- Andy Shevchenko Intel Finland Oy