From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753421AbdASQFs (ORCPT ); Thu, 19 Jan 2017 11:05:48 -0500 Received: from mail-co1nam03on0040.outbound.protection.outlook.com ([104.47.40.40]:3140 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753153AbdASQFp (ORCPT ); Thu, 19 Jan 2017 11:05:45 -0500 Authentication-Results: spf=pass (sender IP is 74.221.232.54) smtp.mailfrom=sandisk.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac1c2133-4386e98000013ebf-13-58815e8189dc From: Bart Van Assche To: "chaitra.basappa@broadcom.com" , "JBottomley@Parallels.com" , "jejb@kernel.org" , "hch@infradead.org" CC: "linux-kernel@vger.kernel.org" , "Sathya.Prakash@broadcom.com" , "suganath-prabu.subramani@broadcom.com" , "martin.petersen@oracle.com" , "linux-scsi@vger.kernel.org" , "krishnaraddi.mankani@broadcom.com" , "kashyap.desai@broadcom.com" , "sreekanth.reddy@broadcom.com" Subject: Re: [PATCH 2/4] mpt3sas: Fix for Crusader to achieve product targets with SAS devices. Thread-Topic: [PATCH 2/4] mpt3sas: Fix for Crusader to achieve product targets with SAS devices. Thread-Index: AQHScm3fx3aEleS0tU22rppRB+1A2w== Date: Thu, 19 Jan 2017 16:05:38 +0000 Message-ID: <1484841924.2634.1.camel@sandisk.com> References: <1484840950-13656-1-git-send-email-chaitra.basappa@broadcom.com> <1484840950-13656-3-git-send-email-chaitra.basappa@broadcom.com> In-Reply-To: <1484840950-13656-3-git-send-email-chaitra.basappa@broadcom.com> Accept-Language: nl-NL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.28.1.254] Content-Type: text/plain; charset="iso-8859-1" Content-ID: <8C028A0066B5864A97AFD375A59EBD2C@sandisk.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCIsWRmVeSWpSXmKPExsWyRobxn25jXGOEwc6nxhZv325msjg9YRGT xaXeJawWi5b0sFgcmH+O1WLn443sFpd3zWGz6L6+g81i+fF/TBYb5t1isZj59Sm7xbMzMQ48 HrPun2Xz2LxCy2PTqk42j49Pb7F4nJz3k83j8ya5ALYoLpuU1JzMstQifbsEroxl5zYxFrzk rNj45TRLA2MTRxcjJ4eEgInE5T0NTF2MXBxCAkuYJLYvbGaGcM4zSvz4fQrKOcYosbfnLhNI C5uAkcTsCXtYQBIiAqcYJXa9mAPWzywwg0Vi1qzHzCBVwgKJEvcap4DZIgJJEivmTmWCsPUk Hi7eywJiswioSqw/3gxWwytgKHFu2VSoQyYwSvTsugJWxCngK3H7yTW2LkYODkYBWYmW19wg YWYBcYlbT+YzQTwhILFkz3lmCFtU4uXjf6wQtoLE5xX/2CDq9SRuTJ0CZVtJPP1/lh3C1pZY tvA11A2CEidnPgFbKySgLnHyzlpmoEtmIVk3C8moWUhGzUIyahaSUQsYWVcxihUnJhfnpqcW GJroFSfmpWQWZ+sl5+duYgSnBUXjHYz/NrgfYhTgYFTi4Z3h1BghxJpYVlyZe4hRgoNZSYT3 zO2GCCHelMTKqtSi/Pii0pzU4kOM0hwsSuK88gd2hwoJpCeWpGanphakFsFkmTg4pRoYp/L9 7IpNWsD82XGH9nPem5Mq7op8Y1sZwtr5/9DinzGNPud3ukg2n/QrmS63eBU3m+mUa5ttVHZ/ K0u1atE7kyT/drbN90lbll78/WLXytA5JccmTPb9+OSkp2FOeEPtbMNNxta7bi7bHNYn9LHX dcaKnco5ij339ryqnNPJomYXev4hQ8lqXyWW4oxEQy3mouJEAGNxxQ0HAwAA X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:74.221.232.54;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(39850400002)(39410400002)(39450400003)(39860400002)(39840400002)(2980300002)(438002)(377424004)(24454002)(199003)(189002)(2906002)(626004)(4326007)(2270400002)(54356999)(76176999)(103116003)(106466001)(6116002)(102836003)(3846002)(106116001)(5250100002)(36756003)(23756003)(50986999)(92566002)(50466002)(2900100001)(2501003)(69596002)(189998001)(33646002)(54906002)(2201001)(305945005)(229853002)(38730400001)(47776003)(97736004)(8746002)(8676002)(86362001)(356003)(81166006)(8936002)(5001770100001)(2950100002)(53936002)(7736002)(68736007)(81156014)(7416002)(5660300001)(7099028)(32563001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR02MB1423;H:sacsmgep14.sandisk.com;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD047;1:Unf842gdyvXJdHqll7zGcfw/mJMyRucoQCZuRF524vaKDLhDd2XDgIo8fMOYDIIjyDdHX0i6u52s0Mrwja4aNYYnOAJlXcQ+F1fvd9x3cn0Ga+7Jbvc1Ild73wHOnItEoy0htJbMQrNNResKyAdKxLn7vIqfYueiEu/mS36umve9pcAO39bA6ot2s2qU+tZdi2ehWkUW+DcxqEjYw3QlUicX8updlI74I8EXtDlfwjnFjcMLBayWhKn771ryLyVwojfHBX/5OKm7vgwbuRMJj8l934YCj9Rl5+COP95F2L1UUJuNcSF6jSRAlLQr2D7+I0EZ1m2ZIR+aLrikyN2NYh99jyK1U3mpQVdt+XrdLN7G+vr4xlew+30YR6gsFfFgeHWNrr6MmmniAhQ04fwcO4CHn62MW+rCBf6HyW6fyzv+puFpmDgbBM+wkZEEgIB8Z+aa3ZKw8utvdzoyThziw9TbVe34L/pt9QOmxNZCn2GOO6xKcHCpxInqjRpgacxb2sk+sNdU4HGZG1DMLJrAjRjz8/qfVybT/edkQW2eU9C9B2D/c7/X2iR+LER9f/T4 X-MS-Office365-Filtering-Correlation-Id: e7d18f8e-7562-467e-ff55-08d44085040a X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(8251501002);SRVR:SN1PR02MB1423; X-Microsoft-Exchange-Diagnostics: 1;SN1PR02MB1423;3:99WaEvCNk1N9L/oNMdPhkP+jzbmNo/Pl/zIfv5pAmKTR2nDwNaQ2kWTjk+u2l1Y6/Q3iNAJMpvk/EIX6dYQidwiDVmLPwGyKrPkerBW429W+MaKkvFoQLTdZRjfFe3LQuEf7WMsc2HEsVD7TFrkTagfdzN+xMcdco+KpLe2mFTmI87kdLHVstrKO57xAMoiT3t3FXeHWA3+YAwhAI/G2NHXBtZd9nRtUo0FMfApSZFvIlIEM2f9qhB77RR49DlyZfXH5mTsdgKPOZ2Uii+UZLpI4NEdpBxVVNntBD7jlH8CdG+/DYy0LOlkec8+h0vHi8zKiAIMSvWRt9Z9PFsPRSxaoGwYxI+WeKMrUEAQ8x8aPZYFPsF5/KthuDc2mfwGZ6W9q3RRLC+kmOJd4mD8tEw==;25:ctS0Q/VOfp2g0T+p2F5QW7PcKB354PBqTXTXBjXbppOIXkLZ8Nvqf8PCqV7RSYVonNd90spWrLaj2nTZXi3Jc8epwNc5kisWExqeWkEiH1bavdNIszfwGN2Xlw3kAQ/ApBFGGftn0jmgoqZxVlW9cy7J/XRRll7BK0I29iuqY20Vy/TEkSq7wp3e4b2JE9YBOCdIW+PoVW5ebK0nnxfrToLFnyp4y/11ZqCKzDLGOgmaj+1vlgLK4vQ4jDj47jo0ARsawSZ4yIdh0/0OyR3woyCKtN+LXuKhJvSlGUAkP4TiqDfrrERG8Hfm1fkIKy5sBbt/O3hXENGPhFglN9y3mOHYOotplev0vZeZMLiRzFQAW1LbfGvi5vdYVor1tDHYG7xMPso7b3oTN77685D0Fo6Y0AvyuOBiZ8wS52kLsE8mbx3mWSIVkE/gHpOa7Zx2tqXvwGU0h9ytfjkLX7N+zg== X-Microsoft-Exchange-Diagnostics: 1;SN1PR02MB1423;31:K6Eh/UHnjseHso/hf2QUV85c5yq6+ZHFjh0S5+dEel9bbLtnont7A1fm12Y7mmJb8wE+NrBu27AMX1hUwv3jCe9cJyBU77mCowH8OcbbWXzuOwCvcKLuqd25kOLabpS6dDeUOasDdxUmfq2DVqi1J54eIWOmsnfnP2/y88xnZDbXbkMsXvNRiROWndZIqC1mrCaLrgBoqP3MSc3fJVHG249cTcaYZGbOVVS/gVTvJ0Xb3rUlTmyrPKuPAuLZx8ZcfCOCH4sCryNHv4PsbByB8Awzni4LwCByBHa35TThmSg=;20:fOmO37hDmhy9+WAIpR/jJM3fAZ6sM+YQ91ZZ++BDMPFb/XmhMTcBisaxqpzvzQboNqrbR9+cy6bjk6G6Q7TyGySyMT30lPL2pwaKylaO3tTkyJ//hJKq5pXXgVuv0g3wmbE6ovoCqIna1h97PeVGm3McjVNfRPoCvA1syzijsKtMFASqrh2B4HUnZ5NnWvULMp2NUmk6EY1LbnNw4kxNZihN+lger+gbSKkSLfCpeCdR0PjMD/W7addolUJcp3d09mFAN7TJ0wdZzI2C/S485tVAShQMZUCLeRZyokSpmHzksuQ19YE2arQuT7nb3EWc2W7boh2HIXh6HbCoSykj076C2eF+iP0US0heLardQOn8itROa1LXsZiCkap4pb9FEjDVfiEigx9fzCnY3fD850h7xjvhzlqtrQrih8bE0Oy033j0YGm4oZuICgtLLd+K3TU/2ZBItS9pMIpSdEaj0mQrrDVExCammqB9r8CeBkdDN3MlzcBhy0nEZMbMof/R X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(13015025)(13017025)(13023025)(13024025)(13018025)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(20161123560025)(20161123558021)(20161123555025)(20161123562025)(20161123564025)(6072148);SRVR:SN1PR02MB1423;BCL:0;PCL:0;RULEID:;SRVR:SN1PR02MB1423; X-Microsoft-Exchange-Diagnostics: 1;SN1PR02MB1423;4:4zKHFOntjP4JmmVsR0sRDA7vSYNs1MvQqsuIY+tvB4E/+eJi3C/KogRZzgq8+TgBl4Z5kBmdBoH087NrD5tTyphNFauCpkyq6lnh2nskzgGTdLuGL70feqTaFPIQHq8hmobR2Tpdxg+jiIKkwUpPH3HpiX37bVLLGlYKoeFBgUx77O5QaJpxik0Ib2wxy+3MXkM8U3TMXbS+0J0s4PHPoFV3vOi+xNmaJrOn7fGrhHEQFbmfP203am0Vc+ACndnEeDVRbGJUIjjxMII6pYN1WnWtjV/l5c3mdxOFzTWoU6tODmWDh8iH+7UyUy5xcYkpJkmr8fUtduYAwrNA4j4Y++k2jYCSIJTFG86VT71javrhUFWs7pBmIUQkwEFit144YnKN1OsiS1yXDbQPr2tX3bYohC8Nd+YgmkeD6wEc/aeABln2aeTuJIBicU785qG+EraIQYb4eS2VwKnSAcmYBzy5OPKmqjuYwO5hagf81w7/aw20oUs0wL6u3aaZnbh9z2y129P7UgSbF3g+VSmsHb/8ZBLMNWRub3ULRflEvIAhBG1Y2a5s/sEzG50YgzQPkS7Eg91E73wr4ny5efKWciMuvf1nThPYQoyctv5RnUpKOQP9vrNIO5UT2CtGctAbY99jOQo1VYId5Cn69s7JNJnYiX0GiS6vXYRTAfmTecVGgrA0/VPZQwEHiafNvsOnJiqJYUui99G4Rer/pgyYtg== X-Forefront-PRVS: 0192E812EC X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;SN1PR02MB1423;23:+pPWBi6T47gwGOMx4JbTL4ao2EwVBO6dlzJ7Vly?= =?iso-8859-1?Q?1SC0MdDvxENGxkKNxwVCKgUSYgFVuj/l+Mf9z55+7rsRieWNRm9vxP2JPh?= =?iso-8859-1?Q?0SP7iT17JEyCuiqLHKPolc/bh6BYoeu7VnsxkJFFGwH2Pfd2UYHQbGJ0bc?= =?iso-8859-1?Q?mKreKlj1UHZtZwlF59lYWbGkTMXIAudOLXOgtU+Cjlhefah0bCC/J4PsZj?= =?iso-8859-1?Q?KtSlpeCMFW+6+GCttDnwxVfi6y2YElO4UhJTaV4pTRAgUPcUmNTP4u6KqI?= =?iso-8859-1?Q?hZ7ey6/ucdLAXski3e+v1ceXLuRowi+Q2qRbsCms4Xmi0VSiEmsEw6y6W1?= =?iso-8859-1?Q?F6vMZTRjOWOGl2fGCGH2KIHCqarVb7j0QBHsDChTFb09GwsXlDDtp9MhLe?= =?iso-8859-1?Q?BVwW7YRuModucYWKKqycjplPh6SR0DhsVtrmIz0BsyhFBNvHy8MEsgsbRa?= =?iso-8859-1?Q?R5Q3qanCxfy4K5xDdx+mDQxM5iVAVZPnybtJpMC5n42z+ZBTviNogFFbY1?= =?iso-8859-1?Q?sDNySEZrGXp1ByCErhuBg0sT/kbQp6Htt7sawsE4gHv/g0VAhcFUVQsZlH?= =?iso-8859-1?Q?cvff//UuDJAnw8bgpQv+a++zWwuX+f23hged8CMYlEmYPAu+fAcdz7hbRR?= =?iso-8859-1?Q?I2hVEAMkTta3uYJWcNrN+jRQupRBaMf0SuMGmJMmFDiRXC2l/67Ha8aNpD?= =?iso-8859-1?Q?cy/+b45kGXFIN4wtH8ngRo7O9Z+keu2kJjSwJ0jpdxJYsD81dMAzRH5/+L?= =?iso-8859-1?Q?C1/fOpcNf5KVwofmQR0STFoTLRsbhy8q00v4fJRZzaTk2m2MYVacsg0gM0?= =?iso-8859-1?Q?hl3EpHVnGPTzN/4elsJKUNJKk8IZZL38IWSzxLhhI4wIEeNSBRrsDoii2M?= =?iso-8859-1?Q?e0Q0Kn6LVNmk+IiATcjRHqEuWN/k29sJRjp/qrBeRe2qYX6VMM6xEDnHY7?= =?iso-8859-1?Q?RJ+nVFl1JJJoTt5PnCGA+E1GwK8YeMJRh5EW+pBn0kKEMeq4TTIASyGpaN?= =?iso-8859-1?Q?bH0IxJ7ZBJAQQFUGxJuNOxP1eiEZOfM+EzjvgaJtHiMEPjfZcrB3JPsBF9?= =?iso-8859-1?Q?sEENWrSfpWVST8x+ZQeAILZtm/wLItGHfLuiEmeF3g1j4rXHpqafpGPHdj?= =?iso-8859-1?Q?UrPATvQ0q8XgfmY0aPVHHbMfaUu0fGc+Xrfa627FUYwrd8FYs8Fu8bljZe?= =?iso-8859-1?Q?wkwZySVIXE1bjKMcFUbmgnXcUSEhJBytL4VCzxScnQX7kt3aC6tLNY7oQb?= =?iso-8859-1?Q?qhpv5fxtjNcDC3POKzi6136f6oXvafOCqjHR/PgqaAp93onZdRFyHnh0fm?= =?iso-8859-1?Q?wgztmWlaO0MR9ngC0E3Mw5WzOtV5Frgpr3p6Ve0sAwxguzs49BoKr4To+2?= =?iso-8859-1?Q?WuksWv1nPAH6C7b1M3gnh8t2hYshZrXF6E4kW6SCPUN44IGcHMasIG8+ff?= =?iso-8859-1?Q?gIbdJZpLPsy7kd/uAwHGSjua6NyCSJscmh9R8aVNyGITXIfSEll8TExsA?= =?iso-8859-1?Q?=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR02MB1423;6:38W8FJXNE40BefoJIs+q9STy88aQf0mFCJAL3fW2DsjRvQa8DsuAKS8XO95FQ1+HeAxL5nVx9XyHbNFhl6txBFNM7uBVo1BY/VKnyeLdgnGr8XCbBj0e2Tl3UqmlmDYUp2LOA48S82yxvnbXb8A+1swsF/YUeKfHZVuXpfk3/7vHDXi0ijM+3yT+/oIvc/GOIkBmVxtH1dadA0S+vkXxx2N47Xn7a9s0ybAx8KZsmcOx4I1oXOmy2m6KENS11sYzkPBkydQ4JkB+TUTAd9BAGjIvf+c2EaudcFdusdBNgqtOL4n29QS9FtvL/8jHI1eqYGPvozbRl8LPx18px2YbKpyWNx06xFkRYd2HjwqgwXecsMxOcur2JDwrbqwoy4X+hU/UGitlrDZz/rKh6wo3NMqz5igG1yRAqhtbSQvyFG0z5rR9c/RLJ1xbfSOIcNha8o3A7Kf3yrrmw6ZB3bvDFA==;5:hzBNLgfQJ/+HUgWkRB8HBjdA2sBZop+8R/tv1l36UN+qeEBfmwj1biftrE2EXOgCt2Z6dvi6ko/IQGUnyXwH/mka1rNO8R7PB3uLylA3tNkcMwT+WUQgYqyLVx28lScDwMjOJlxghpR+2J6ItXyDdw==;24:prWV8tsSq/AKkIN6hSviRaIT9LSs9XsR5SQhlAo/Fpow8X9qL99nNxa7JAjIdfytGdoW91UIUttT1t6Yy3DJCJ6u0/HM4sarljGi6x3Jv7w= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN1PR02MB1423;7:kMo0fIJt3HjTETXYvBPQFdJAeID4Ce8g0fOzheOtSS8lVOtkZJ0Esb60+BnjGCgoMAyC4iPrdyEzdsNwh+lkPLjemfOT+sujaIpHey8trrZEwyG/ZoMs3+66+aU8cgUyH10rjfrWWm6sLYVJIqvJNbx8POH0XA4k10YaY9dKq/DoeqPW17V0cMlBciRjg4jdfPLIPbKrR701Eqi3+nYpqxYAYD+hp74X7dSgappOas48yy6lVT3t4m66KTKxfEisuHqvswc7gFnU+8t8zv2UpJBEgJVu4kJbs/5jTni7eU08YEXIdS5Hb0hA3R5nASTMlEnq1PBGfh3JxmXeSdnSsCq6WsrY2dSJqp/rZMfR6ocmYDsis7D2W/MiAkeeREuXGUzZ0DWT4htcPyLcfxGoF6xVM2h5eUDkjr+DPWU9rjq6wN3v/V2dHWivsqV3N1djvJpLNGs1Ir63J1M7MB7Gzw== X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2017 16:05:40.7180 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[74.221.232.54];Helo=[sacsmgep14.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR02MB1423 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v0JG5sJk030836 On Thu, 2017-01-19 at 21:19 +0530, Chaitra P B wrote: > diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c > index 5ffbfb1..b3f9f7a 100644 > --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c > +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c > @@ -1096,6 +1096,27 @@ _scsih_scsi_lookup_get_clear(struct MPT3SAS_ADAPTER *ioc, u16 smid) > } > > /** > + * _scsih_scsi_lookup_get_clear_without_lock - returns scmd entry without > + * holding any lock. > + * @ioc: per adapter object > + * @smid: system request message index > + * > + * Returns the smid stored scmd pointer. > + * Then will derefrence the stored scmd pointer. > + */ > +static inline struct scsi_cmnd * > +_scsih_scsi_lookup_get_clear_without_lock(struct MPT3SAS_ADAPTER *ioc, > + u16 smid) > +{ > + struct scsi_cmnd *scmd; > + > + scmd = ioc->scsi_lookup[smid - 1].scmd; > + ioc->scsi_lookup[smid - 1].scmd = NULL; > + > + return scmd; > +} Please make the following changes in the above code: * Use swap() instead of open-coding it. * Call _scsih_scsi_lookup_get_clear_without_lock() from _scsih_scsi_lookup_get_clear() to avoid code duplication. * Fix the spelling of "dereference". Thanks, Bart.