From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751364AbdAWPCU (ORCPT ); Mon, 23 Jan 2017 10:02:20 -0500 Received: from mga05.intel.com ([192.55.52.43]:54496 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751214AbdAWPCT (ORCPT ); Mon, 23 Jan 2017 10:02:19 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,274,1477983600"; d="scan'208";a="812276153" Message-ID: <1485183638.2133.287.camel@linux.intel.com> Subject: Re: [PATCH 1/2] device property: export code duplicating array of property entries From: Andy Shevchenko To: Dmitry Torokhov , "Rafael J. Wysocki" Cc: linux-kernel@vger.kernel.org, Mika Westerberg , Hans de Goede Date: Mon, 23 Jan 2017 17:00:38 +0200 In-Reply-To: <20170123073849.28352-1-dmitry.torokhov@gmail.com> References: <20170123073849.28352-1-dmitry.torokhov@gmail.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2017-01-22 at 23:38 -0800, Dmitry Torokhov wrote: > When augmenting ACPI-enumerated devices with additional property data > based > on DMI info, a module has often several potential property sets, with > only > one being active on a given box. In order to save memory it should be > possible to mark everything and __initdata or __initconst, execute DMI > match early, and duplicate relevant properties. Then kernel will > discard > the rest of them. > Looks good to me. Reviewed-by: Andy Shevchenko Couple of style nitpicks. > > +struct property_entry *property_entries_dup( > + const struct property_entry > *properties) Can we use struct propert_entry * property_entries_dup(...) ? > +struct property_entry *property_entries_dup( > + const struct property_entry > *properties); > Ditto. -- Andy Shevchenko Intel Finland Oy