From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751804AbdAWW21 (ORCPT ); Mon, 23 Jan 2017 17:28:27 -0500 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:53842 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751668AbdAWW20 (ORCPT ); Mon, 23 Jan 2017 17:28:26 -0500 Message-ID: <1485210503.2534.32.camel@HansenPartnership.com> Subject: Re: [tpmdd-devel] [PATCH RFC v4 4/5] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c From: James Bottomley To: Jason Gunthorpe , Jarkko Sakkinen Cc: open list , linux-security-module@vger.kernel.org, tpmdd-devel@lists.sourceforge.net Date: Mon, 23 Jan 2017 14:28:23 -0800 In-Reply-To: <20170123164754.GA29360@obsidianresearch.com> References: <20170122234438.12102-1-jarkko.sakkinen@linux.intel.com> <20170122234438.12102-5-jarkko.sakkinen@linux.intel.com> <20170123164754.GA29360@obsidianresearch.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-01-23 at 09:47 -0700, Jason Gunthorpe wrote: > On Mon, Jan 23, 2017 at 01:44:32AM +0200, Jarkko Sakkinen wrote: > > From: James Bottomley > > > > Signed-off-by: James Bottomley > > > > I really think we should not use the ugly read/write interface for > any new things. The R/W interface is needed for backward compat, so we don't really have a choice (well, it could go in for long term deprecation, but I found in SCSI that "long term" == "never"). I think no-one objects to the ioctl interface ... it's just no-one feels strongly enough to build and test it. I'm sure if you send patches, Jarkko will include them. James > Still unconvinced we should add a new cdev at this point.. But seeing > seesion support certainl is encouraging..