From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751218AbdAYCh2 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 24 Jan 2017 21:37:28 -0500
Received: from smtprelay0118.hostedemail.com ([216.40.44.118]:60481 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1750984AbdAYCh0 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 24 Jan 2017 21:37:26 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1381:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3870:3871:3872:3873:4321:5007:6119:8603:10004:10400:10848:11232:11658:11914:12048:12296:12555:12740:12760:12895:13069:13138:13231:13311:13357:13439:14659:14721:21080:21433:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none
X-HE-Tag: roll11_7ac309417f52b
X-Filterd-Recvd-Size: 1466
Message-ID: <1485311842.12563.50.camel@perches.com>
Subject: Re: [PATCH] nvdimm: constify device_type structures
From: Joe Perches <joe@perches.com>
To: Bhumika Goyal <bhumirks@gmail.com>, julia.lawall@lip6.fr,
        dan.j.williams@intel.com, linux-nvdimm@ml01.01.org,
        linux-kernel@vger.kernel.org
Date: Tue, 24 Jan 2017 18:37:22 -0800
In-Reply-To: <1485285847-7006-1-git-send-email-bhumirks@gmail.com>
References: <1485285847-7006-1-git-send-email-bhumirks@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.22.3-0ubuntu0.1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2017-01-25 at 00:54 +0530, Bhumika Goyal wrote:
> Declare device_type structure as const as it is only stored in the
> type field of a device structure. This field is of type const, so add
> const to declaration of device_type structure.
> 
> File size before:
>   text	   data	    bss	    dec	    hex	filename
>   19278	   3199	     16	  22493	   57dd	nvdimm/namespace_devs.o
> 
> File size after:
>   text	   data	    bss	    dec	    hex	filename
>   19929	   3160	     16	  23105	   5a41	nvdimm/namespace_devs.o

Fine, but are you sure about the sizes?

It seems odd the text went up 651 bytes
while the data went down just 39 bytes.