From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751906AbdAYPzS (ORCPT ); Wed, 25 Jan 2017 10:55:18 -0500 Received: from mail-dm3nam03on0105.outbound.protection.outlook.com ([104.47.41.105]:56240 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751480AbdAYPzQ (ORCPT ); Wed, 25 Jan 2017 10:55:16 -0500 From: "Kani, Toshimitsu" To: "hch@infradead.org" , "jmoyer@redhat.com" CC: "linux-kernel@vger.kernel.org" , "linux-nvdimm@ml01.01.org" , "viro@zeniv.linux.org.uk" , "dan.j.williams@intel.com" , "akpm@linux-foundation.org" , "joe@perches.com" , "linux-fsdevel@vger.kernel.org" , "david@fromorbit.com" Subject: Re: [PATCH v5] DAX: enable iostat for read/write Thread-Topic: [PATCH v5] DAX: enable iostat for read/write Thread-Index: AQHSbPtlTiUJMkiVMkuLU74ml2JDaaFJH+4AgABCEpaAABpcgA== Date: Wed, 25 Jan 2017 15:55:14 +0000 Message-ID: <1485363041.2029.26.camel@hpe.com> References: <20170112183848.23159-1-toshi.kani@hpe.com> <20170125111952.GA11978@infradead.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=toshi.kani@hpe.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [15.219.163.9] x-ms-office365-filtering-correlation-id: e5b841d4-cf13-4254-5516-08d4453a8d13 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:CS1PR84MB0293; x-microsoft-exchange-diagnostics: 1;CS1PR84MB0293;7:wOaRSfTbnKevDG6zkQ5JhgQyt7q+D1VyI3D/P1W0fHcKBmOSGfXEny5CFCNya34Vv0Hs21NWVMxHOGwbXS0lTIUTHcTTkAuAreKIJ6DLR8Xt3Cm6gE68pqFlsZ/KhkwsI5x79jO0V90PtJWrEcY0QEAhseAHLgzmkGzUMNzeAXiDwTHHqaNeu6TGCPwCA7rekPZVHbwNPEEyTKR/AMzS6HmGHfVFKs9KnU5AxoZxyKJrXvm/s3oKMPJyd0K55XN2IpVNBnbl4rTR41220JcI8Y9h6KTR8hXFQAGiUIWgEM0wdME3ZkPZJACKe1UuA7C62HvVAsGZ/c9M8brHYuHWDPtaOYo7CYrLdoyFu9tymFkBLRxgkd4jPfAUtwzQMpyIrj9IRhNpfXtclYj7FyjCpjUE+yrNMFqrbl0imEnDxax85qdtfC3dr1ChJgANopusfTAUQLtzdx2c+gAtKVMgPg== x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(278428928389397); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026)(6041248)(20161123560025)(20161123562025)(20161123555025)(20161123564025)(6072148);SRVR:CS1PR84MB0293;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0293; x-forefront-prvs: 01986AE76B x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(7916002)(39450400003)(39860400002)(39840400002)(39410400002)(39850400002)(199003)(24454002)(377424004)(189002)(86362001)(54906002)(92566002)(106116001)(53936002)(50986999)(305945005)(76176999)(7736002)(54356999)(3660700001)(66066001)(5001770100001)(103116003)(6512007)(2900100001)(189998001)(2950100002)(2501003)(106356001)(97736004)(105586002)(3846002)(8936002)(6486002)(38730400001)(229853002)(36756003)(77096006)(101416001)(5660300001)(4326007)(81156014)(3280700002)(6506006)(81166006)(122556002)(68736007)(102836003)(6436002)(7416002)(33646002)(6116002)(2906002)(8676002);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR84MB0293;H:CS1PR84MB0294.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2017 15:55:14.1054 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0293 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v0PFtQbI008663 On Wed, 2017-01-25 at 10:15 -0500, Jeff Moyer wrote: > Christoph Hellwig writes: > > > On Thu, Jan 12, 2017 at 11:38:48AM -0700, Toshi Kani wrote: > > > DAX IO path does not support iostat, but its metadata IO path > > > does. Therefore, iostat shows metadata IO statistics only, which > > > has been confusing to users. > > > > > > Add iostat support to the DAX read/write path. > > > > > > Note, iostat still does not support the DAX mmap path as it > > > allows user applications to access directly. > > > > NAK.  DAX I/O should not be accounted for block device statistics. > > Agreed, this is a layering violation. I will check to see if it can fit on top of Dan's patch-set. Thanks, -Toshi