From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753377AbdAZPL7 (ORCPT ); Thu, 26 Jan 2017 10:11:59 -0500 Received: from mail-by2nam03on0076.outbound.protection.outlook.com ([104.47.42.76]:49024 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753169AbdAZPLy (ORCPT ); Thu, 26 Jan 2017 10:11:54 -0500 Authentication-Results: spf=pass (sender IP is 74.221.232.54) smtp.mailfrom=sandisk.com; grimberg.me; dkim=none (message not signed) header.d=none;grimberg.me; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac1c2133-0c3ff70000013ebf-65-588a8c410894 From: Bart Van Assche To: "augustocaringi@gmail.com" , "jejb@linux.vnet.ibm.com" CC: "linux-scsi@vger.kernel.org" , "emilne@redhat.com" , "andriy.shevchenko@linux.intel.com" , "linux-kernel@vger.kernel.org" , "martin.petersen@oracle.com" , "sagi@grimberg.me" Subject: Re: [PATCH] scsi: srp_transport: Fix 'always false comparison' in srp_tmo_valid() Thread-Topic: [PATCH] scsi: srp_transport: Fix 'always false comparison' in srp_tmo_valid() Thread-Index: AQHSd+aAQg90/FscGkqpDJSGJqmC1Q== Date: Thu, 26 Jan 2017 15:11:43 +0000 Message-ID: <1485443483.2980.1.camel@sandisk.com> References: <1485429447-19103-1-git-send-email-augustocaringi@gmail.com> In-Reply-To: <1485429447-19103-1-git-send-email-augustocaringi@gmail.com> Accept-Language: nl-NL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.28.1.254] Content-Type: text/plain; charset="utf-8" Content-ID: <60F89A3FF81E5B4C9FB135C38048D49B@sandisk.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHIsWRmVeSWpSXmKPExsWyRobxn65zT1eEwbyD2ha9TdOZLPpbDzJb LFsZbbFqYp7F5V1z2Cy6r+9gs1h+/B+TxbrX71kcODx2zrrL7nH+3kYWj3knAz0eHNrM4vHx 6S0Wj/f7rrJ5fN4kF8AexWWTkpqTWZZapG+XwJXx/e5MtoJLghXTj75naWCcIdjFyMkhIWAi 8W9rH3MXIxeHkMASJok/ly8zQjjnGSXmzLkJlTnGKLGg4RIzSAubgJHE7Al7WEBsEYECifmL msE6mAVuMEmsfP+TtYuRg0NYIEZixhkRiJpYie75N5ggbD2Jczd+MIGUsAioSlyYKgUS5hUw lJhzaQEbiC0k4CFx9fAzsHJOAU+J5586wSYyCshKtLzmBgkzC4hL3HoynwniAQGJJXvOM0PY ohIvH/9jhbAVJD6v+McG0sosoCmxfpc+RKuVxOuW3awQtqLElO6H7BAXCEqcnPmEBeICdYmT d9YyT2CUmIVk2yyESbOQTJqFZNIsJJMWMLKuYhQrTkwuzk1PLTA00StOzEvJLM7WS87P3cQI jnVF4x2M/za4H2IU4GBU4uFdYNQZIcSaWFZcmXuIUYKDWUmEdx1fV4QQb0piZVVqUX58UWlO avEhRmkOFiVxXsePHRFCAumJJanZqakFqUUwWSYOTqkGxkSrUz07wl8HmnPd7uvZIWuubv3F 6orezwz26tgr1dZqooUlorx7T//yfVJjy/Xw64zH6/5Fn1tVP6vLasrmxdeKAiaXPXv877nu ulczDyw8qXpecYdW+NkJ3Ko7BTQKZt1/3DotdIl79a3a6TJVUvNtZzhZRAc8Xdn2vWRrwVXW 2fbhh1eb/lBiKc5INNRiLipOBAB7zKxu8QIAAA== X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:74.221.232.54;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(39450400003)(39840400002)(39860400002)(39410400002)(39850400002)(2980300002)(438002)(199003)(377424004)(189002)(24454002)(2950100002)(103116003)(68736007)(356003)(53936002)(5250100002)(97736004)(76176999)(106466001)(54356999)(4326007)(50986999)(189998001)(38730400001)(229853002)(54906002)(5001770100001)(106116001)(2906002)(39060400001)(86362001)(2900100001)(81156014)(2270400002)(92566002)(5660300001)(2501003)(69596002)(36756003)(50466002)(33646002)(8936002)(305945005)(6116002)(8676002)(23676002)(626004)(7736002)(81166006)(47776003)(102836003)(3846002)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR02MB1413;H:sacsmgep14.sandisk.com;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD030;1:ZlbV5N0Odf2a8rvJvrKIqyXcUVBvLSuH8pCZKNnzGQOl+qvi2CimN3N7HbYKlSLtDflgALCzmtcN/0wY0QhYLRu0HP0ztcsRQ+Nn3QiMPvD9VXKYzQCB1oeP/804PGmqFs2t/br9II5pTwSHZaufACQHc9jO4Yek4gr5xg3Vhcudyc/Ghb467P1Y3l1zJIXWcezedDp4F0gQs/9d/yIW/nnvhkquGcVUC062Kt6IjE8z1T09ejudcvHoeby+/rctd3QVasW03dGfcv923BLBaMiwqqaXhQXmo3YJ7AHxtmA3fOu5jpwCZ4XRJqbcdHSxyL5Hpz+8DLXu4zUA7b5rk3guxTrrE8GBik9SSrMxuFLl3JhSc9deFAl/nrRwu/Agm9hZJxbinTn9y60tSKKqvVzQF8mcCXDa/qIqBIdFU4qgxKt4W0yQsf0s4Lv7cSsXWjeNtT4dcrJ2usFIs96+VYP71k56IvEnlRNVKrMZJuZhMfEtxBMLuppzihba8KeKUTLysbGYoiiKxJUkCUxl2OhiHECLiHt5k5ilghQsaX9Q+g9U469Olz5IvzWvzIc8ikKuTYRpj4nnRhLYl9jZz7tKnN4tPF4L8gOuuMQ4n2A= X-MS-Office365-Filtering-Correlation-Id: 36508532-7d93-4e2d-5e2d-08d445fda6cd X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(8251501002);SRVR:CY1PR02MB1413; X-Microsoft-Exchange-Diagnostics: 1;CY1PR02MB1413;3:07gO859P6KkIR5J1jOqR7DtOaeDILapRKDlo0/cvGouIwK3LWr4MyIhTqsnayW4jQviYG1XgeJXa6EiH0ZI/GQE1iTTaFQaQ/x1tW6VVDSaxFwukJLH5Ab/KlPygK/x4GO0q4vlsVg6l1Pye3LUun0pYp/hMvXhsChpCGeo5zxMxlIlJtvKKVtM2l4OjUxMKZlBT0IY6vgVnpngKIH90+PyiGWwMxZGbzuLb8oMCXo8bpf/NmXB68cpZPV1T3y9bQUgiJov1/5ZQttPpLozOPjkTdoJePgW8U34pDfNA/R5uz9fGZq4CnxqLaGYO08jBX1BKo1BFU6BPXRYkQPoTOQYb4yMJOWFU2SynmIEiIYySX9/fXIayumdrE4iAhJs4HFZY/qDyjs6nGo7fB1rdmA== X-Microsoft-Exchange-Diagnostics: 1;CY1PR02MB1413;25:iBKKomLBgUgORu0OYM7JBWNpxS02RVgJqNxqnNDTC01eYFVLsjvg9TTdMVOUIN23AOZ055Nw93LbqRZ4GxDEsaFKB6jmZsXny7l9UKmlFdS0+7nFm19Lnj5AiJeh+nDtTWfcnahujj6bO5vHUdcOtv8VwgEYlVhZQNPUfDpHImXFKweoAcIZqyrf95aVbiM/JRSBqGRaSvEy8dsKcQjRGXl7PBCpZNjPeXa6I2MW4l/iyq4blfdoHuCqZd/YY1Uvp1eG1FyOxLBhR5EYQxsLCV0vU05E4/ACN4GgrUaznBQsW4BZdLp11uz3fs/hDoW22fRuWsf0EHddHE1RQeN3bm8AeDTn/qCpHv0e1cP/tmPylzNJL0kR4kya2jInP0RIwHCrwgFD92YqXvV7htTlAOp9bvNxZeUDsv31V4OY1zBrcMMmgOY7wSTthYX7nQxwK1JklDSSMvfyHE7q27Bw38/6gW9hTPDerVpXO2Tsz1LCBdlndLkQm7vuM7AenBTPdkbhitp8SJci+NVhEluGvUFqFPfgzW9NKDEJvTFcSxyrzDN3RUbnVaCgnE//sJcViLN4ldqA5crWcIqaQKjdGvlvi1ugjlXfV9v6j+IjtQjLqoMZpN4prG0geawVmDcrxsJBcauExZNaXaAF25MZUrU1NqElBQvPDcTZAmFWP3DSHjEAA001Mlq6v56iEmSrSOjqJAE0mivt8xzlPY0y3M/m1yR98Ekv9WfD6rLOGTUjjiWJRnnyDPF1qf9sxpxb X-Microsoft-Exchange-Diagnostics: 1;CY1PR02MB1413;31:443G43JhNkKNOewPzbocd8Bl0IOLFgfFnOKWfw5gmLUkE5nkr/VwYvBLtvgDdvPKFAuJIVu8UDbjHm7DF9x8xZU9qfUCDTiEiN+NBxvVOJxBELuqDxW0GDmZ9vWkaEBnurD6zfCqRhXOyJx0VDHHkgWHNXT6I1inROTEJbQ/CWPYRiej5tCVtmCuzAIDcQE/xRCUCKv2L7Z5susBOL5qbwpHprGnfLNahdZMuiHLx0bLHyxJVWgKKvS6769vTputY28aqADhTS+v15f23h5kkg==;20:22mXn3LRnLshTRDHJlHg8Ioy/nuXCtXdLlR0zIOwOmT+jR/wjVztoSXCatfN/twvAMoqEKyrNCDBDd7/+N4iXywPxxSj24POeDkrl4HOOmU3a79X6pIy0+Imkh6VDD8h8xd6iPg59nsYMxTTqRZHXasgb1MkfitHCUx1QidUsAI1NZU6SqyTgQrwpXju4gjzXCz9rWSZorivZs8Qkj3tn3o/2PWpJOigGzJ+7oh5loQO7MXt67f+pa0AAZWKvojCHUC65c10cE2dVt1MQymPWfVj+BECcju7gn3H87sm/NxPD1auziubSMemDZ0uPVrpIW0H2AbSxSkERb/x2/qn6y2EDPnMIGnRpXA1uJb7+X+mrpoK6HZpUdxPiHl69pZcjSrZZAfd43dE9g3TClR2pyAqvn5VKjxJgijrZGq2/iYLdcw3kIZU9TlbTNFHxqjuOZ7dhOvjjtZcL4NAOyLtBJxATG9hGegdwD0MUNU88WmIzLU8eZ2ze/MzJcv/eYHG X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(13017025)(13015025)(13024025)(13023025)(13018025)(10201501046)(3002001)(6055026)(6041248)(20161123560025)(20161123562025)(20161123564025)(20161123555025)(6072148);SRVR:CY1PR02MB1413;BCL:0;PCL:0;RULEID:;SRVR:CY1PR02MB1413; X-Microsoft-Exchange-Diagnostics: 1;CY1PR02MB1413;4:YpXdx8KB0/bn94Hs+OOtK7ud6o9Bnn4Xm4Hr9b5KhyU3VRftU3xdL7iqIcKENWKSzwre3YC8qaaSnw8SCtkuvnRioc+JDLTNAu2PZjGHxoytsKP07F8CXfjUkIyxzD6AR6c4muTpPXZwkIK8uvs9j0EF7lwIFwzRGjnTU8jVLjaBp+kfoZ46FvcMOOhssH9/LU9yTT4RI0LwXD3vL/ZZ1p9GYsPH1GdRSlNqjxd1+WTbv7S2uA12ZPxWftX7O9BuS/Fv3oSR92/DiOrhRaQtcjSIxtdwypDMeGJEKxWaCKrxkmqAN/9VKyy2LTlnO0bba2BGKzUoL0a3r3iNJrD4tC4GoKkbHLjCv5aYNdTn4pLccj3p7IYiwm1hy7/v9W9C1+iC/qxIzduWVv8P6nLsNvYVF+gx/bz8K++gDd7TdYWC9wlnpYq9wUDICNWWfPWbXkB3FDgTAiOfDpMkY+vUynD34DvTaagZG8TNrU6FmYzVzzmfL9MzRBDD5PFgz/BUme51mxvSosA0dHhx1eMZWNoLTX5yGc6Sp4TK4XdPGzYBvXIniR+EWHWtQJOQ1Z1eEfPyisoCIfRaxuct7/xFyI3AapV7daDqyWdocdgm0jumppANf0KhBNa/IdkhG/l3FrNEubT/g4/jWvUlSBVFX+qMRllsLPUrEBt7f4j3lFLNOqhMa+dVym5p76wFkz6d X-Forefront-PRVS: 019919A9E4 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjAyTUIxNDEzOzIzOnRFUWFkenQveWxKMTZVT1JvRnQ3NjFZRWJS?= =?utf-8?B?dHNxa3BScWxFVFZsOGZRM3IzZ2MreGk0NzNuVW9XSWhZdVJVU2VvMmJJQWFa?= =?utf-8?B?NUhzeGRkRUlYVHJsU0NlOVhRN09DbFU3MUdLdmhLenB6bEtQQXdhbEY4bGtp?= =?utf-8?B?S3UwWDdWTDFJMTdjaDlNa3JvQWxjSkowL0dHcTAwQ0l0Wmdmanl4cStKbnBB?= =?utf-8?B?dzl2YU9maFdPT0RTMHlwa1Fod0JOWTAxZ3lwMkhBSVJBVS9EUldqVkw2WlJ4?= =?utf-8?B?SUVGZWk5STJ0RHpFVitoUE8xU2k3SGxBVzA0ZkE1S3JHRHZNR280UWdtN1lh?= =?utf-8?B?ZGJkUXRnRlJaT2ZWNlVqQVhHaDM4N1RaRklZaVE1ODhJaEJYM2U2YzRtL3ZJ?= =?utf-8?B?elF6RUF4T1pnd1lDb0Q5ck4vazlkMjFpTnVTcGxGbjNDZnFVdEFpTGoyRVM4?= =?utf-8?B?WWo3NitxUFR4OFdCNlpxbnljcERaSjR2elRnVVBsNzBMOUFQdnpXRFpzV2Mv?= =?utf-8?B?MHJueXp6WDdzM25xeGd6UFp3Z2tSRHZqVWdhWnFlMXA4cnJLeGtRc1l5L3hu?= =?utf-8?B?elhKdE1HWjV1MTJPN0xWRlY3OW53ZDFhVVNYbjJDbXFHVk55ZHROem54dElW?= =?utf-8?B?NXBaYTVtZUVzSUVvaFdnbjhTTzVROTZvU3V5VWxEeWtGMWZYT1ZRb3daSHpT?= =?utf-8?B?aGVSNlpwa3AyZUR6d1lIZllNZlVtWDlnM29BR3MzZFZVcHlRU3ZYSEVMUDBF?= =?utf-8?B?Wlh5LzRTNFR5ZnF6U1JKODhsVGkrblNmQzVzUGZxanBEOUI3MXVGM2p0ZXgr?= =?utf-8?B?VUNadStlU0tiSTRnOGpuclduK1g2TUpyc0U0NE9sc0RoeWR1eHltMG1mdEVa?= =?utf-8?B?T2c4WmRpbDN1SUxFOHRENjRBdHJqL09wTzJGUTdOMk91VXdxeUI4cTRzdGcr?= =?utf-8?B?TE0wRXlLeUhSL3FtWW1sMnMvYWdORzJVdDBqR1VFbTBpejBHUUVXcU1SQzhI?= =?utf-8?B?S3VtbWxWa2twVzRqVFVHWHZLZ21ndHdubGozdkJOY1Rxc3hJU2Fyc3lJenp0?= =?utf-8?B?V3EzeE1aNXBROGxkejd2U1dVV3QzczRhcFM3Y2xlU1YwRytCV0NMUHV1TEpj?= =?utf-8?B?ZlNVN2hCVy8vR0IvOTJBV3RzbFhuTE04QkhYZnZLR0dmTHVINHJGYmlyZTFa?= =?utf-8?B?VmNwTWdWYVlicllrUWtLZ0pTQmhMeUV4dGZUM1JUQ281WFVXNHlueVdwejM3?= =?utf-8?B?MmU0ZU1WTGZRdDVoblRpV1ZzNThOMUYxVFV4dzA0MWoxd0R5TENweEJKaHQ1?= =?utf-8?B?Tk5uV1hXY1NwWGFRaitzaExNWFdZNnp3WGw0QVdOUU5mM1RIVnpaeXZuUzZX?= =?utf-8?B?OXhmNGgvUGRvUU5GRDE4UXRSTUVRZzFPVnZNaW1QWm9ONTJDYkM0QUMyanVx?= =?utf-8?B?SUdDeHNncUpTRFRhYlNQaGxJamwxYlIzdXVsSDJ6WHNLaTVmVTNmcDFFdzdi?= =?utf-8?B?WjBlNUFGQ0Q4bFJsZ2pjV1lKQm9PQTB3NU1tSVc0ZlJjdVhkNi9NS2ZWL0JW?= =?utf-8?B?cEY0SXVheitlSWIrTXFiUGhtekxBVENKYkp0TkJnZVYrUTY4UG9sVEVLKzk5?= =?utf-8?B?dm5vTGIyTGNMSmszMHcxWVFSOVFTdUJtRmRoQVRWdVN3dzFDRUNQT2hhdDJ5?= =?utf-8?B?TWtqaTVkNDNrMmwrcDVqNXRhZ2luMHRKenR5aFhDR01qaVlpVTdNcnE3em41?= =?utf-8?B?SmRRQnZncE9QSGw3RTR5V1NMZ2I3OUNidVJjeXQ2UkNpYUkxckhvNnptdjFq?= =?utf-8?B?MklIbGl2YyttejZoc0hvVms2T1hEc0FTNFFPdnhRblFyV3c9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR02MB1413;6:vyCyLBL2s3X7e6+w2fzqVdqS1kAtsGAHtxfe+zXdTqPQKNKzok4u00WAEOQlEz6XfRDWFBV22vnaXcuKML8R5GkdgRFYzAy7NTHMI7FceKxaD2dJO6OLamnMUVzw41WpSWN5tlXZo8yqjaqhTf5d0LQUaoISnClYVn+O+ijZmlqFYCNf+N5wscbb2sFRAqtKJQobzuDMgZSSGY4WkDdm4NSqEpoR7UYWZMbDBCH1epKGsP/u23qdO+ahJ5t564cm2+nH+EDZ7jiUNSrehuZrng0K3jm1A3AquymrdiI5g2sU8Q/9u4P0Yc16KzSpxFWvBktsJZ6FW+H4VO+k9WU90DICcDsYBXaq7yDHZkMRhH7Camsex4wjZAXPtAu7b6y/URzI7zy/yQACOh2y8RBEF5te9RdkH2zUtU8uS+/hB7/AzEPr0VMQYObgP3iCkdxyUPHZjAbGDYPQKT42wk5OSg==;5:flpu0iqunURkjOLrCwrqvr2snYy/FzsKSExqcDwjv+hWaxPcw1CtAdOHr0wZ2esaST4UFckiErTlGOmJGgKrRu9z+/P+cQgRFlDeAlW2JKLkKRqENR9UO72xaI6+q2DrKJ72RV08k71Hq/tysOWmhQ==;24:o+ygDebn1TMuPZASYLxwmsuzw1ctoFxukDoguKBl6utCgx72DYIyGMRHh9luRVV0jiGO8gnomJ0T8luN+Y46Uz6+/JyrMCevvSyGlAQZwzg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1PR02MB1413;7:HgqKR1vErX/jjkr3kI8tb2x8d9dLIvcPZqUnYmjWXw2C+DQYx4kjJjKHBNipZHlLqdTPRLDLCYEqSaa1JfJrlVfWfjjb6X0UjCdXyHAlu6NFtLHh5ebRd8LDb4muUb6kDfH4qf0cnUwOWvXbbjPjKHJv/XRp/XgbecLuexSKLNko95PDWxwPbjTVdFC1vWDCJyAo0WYQvwsgLLd1TC7ak1ZCWM4pbgaQL3ojJF8ey6IX97hn+ZpjN1su10LhjYWAzPcwc7yqoVQ10HqfhAaLFjC1XtD++Ug2t/XECTg92eMiyBnXpkP0dwmSQARUCWO1TXffulVz72ekE1EdC42qvj4k8fHlXch9M2m3BQYVoKN8DphfaGRRlUzXnsy+05PZ5PiZYb3k4Eq1LC3t2Zo4Ud4fTJP4+pUecxfkmmGCVyqDr2NYoSSh5dzkjtBoqYxGRj9BBW5TC58GasWXykbDAg== X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2017 15:11:48.5333 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[74.221.232.54];Helo=[sacsmgep14.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR02MB1413 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v0QFCEo3017401 On Thu, 2017-01-26 at 11:17 +0000, Augusto Mecking Caringi wrote: > In a 64bit system (where long is 64bit wide), even dividing LONG_MAX by > HZ will always be bigger than the max value that an int variable can > hold. > > This has been detected by building the driver with W=1: > > drivers/scsi/scsi_transport_srp.c: In function ‘srp_tmo_valid’: > drivers/scsi/scsi_transport_srp.c:92:19: warning: comparison is always > false due to limited range of data type [-Wtype-limits] > if (dev_loss_tmo >= LONG_MAX / HZ) > ^ > > Signed-off-by: Augusto Mecking Caringi > --- > drivers/scsi/scsi_transport_srp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/scsi_transport_srp.c b/drivers/scsi/scsi_transport_srp.c > index b87a786..d8c83f4 100644 > --- a/drivers/scsi/scsi_transport_srp.c > +++ b/drivers/scsi/scsi_transport_srp.c > @@ -89,7 +89,7 @@ int srp_tmo_valid(int reconnect_delay, int fast_io_fail_tmo, int dev_loss_tmo) > if (fast_io_fail_tmo < 0 && > dev_loss_tmo > SCSI_DEVICE_BLOCK_MAX_TIMEOUT) > return -EINVAL; > - if (dev_loss_tmo >= LONG_MAX / HZ) > + if (dev_loss_tmo >= INT_MAX / HZ) > return -EINVAL; > if (fast_io_fail_tmo >= 0 && dev_loss_tmo >= 0 && > fast_io_fail_tmo >= dev_loss_tmo) This patch is wrong. The purpose of the dev_loss_tmo >= LONG_MAX / HZ check is to avoid that the expression 1UL * dev_loss_tmo * HZ further down overflows. Can you check whether changing the if-statement into if (1UL * dev_loss_tmo >= LONG_MAX / HZ) also suppresses the compiler warning? Bart.