From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933386AbdA0RKD (ORCPT ); Fri, 27 Jan 2017 12:10:03 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:35050 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932902AbdA0RJq (ORCPT ); Fri, 27 Jan 2017 12:09:46 -0500 From: Cheah Kok Cheong To: abbotti@mev.co.uk, hsweeten@visionengravers.com, gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Cheah Kok Cheong Subject: [PATCH] Staging: comedi: drivers: comedi_test: Set max input value for auto config Date: Fri, 27 Jan 2017 23:55:54 +0800 Message-Id: <1485532554-2520-1-git-send-email-thrust73@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1485365489-3577-1-git-send-email-thrust73@gmail.com> References: <1485365489-3577-1-git-send-email-thrust73@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently user can input any value for amplitude and period. This patch set a sane max value for auto-configuration mode. For manual configuration mode, it is assumed this is taken care of by the COMEDI userspace tool since there's no limit set here from day one in the staging tree. If otherwise then maybe this can be looked at separately. Signed-off-by: Cheah Kok Cheong --- Note: This patch is dependent upon an earlier pending patch. [Staging: comedi: drivers: comedi_test: Add auto-configuration capability] drivers/staging/comedi/drivers/comedi_test.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/staging/comedi/drivers/comedi_test.c b/drivers/staging/comedi/drivers/comedi_test.c index 92b3a4f1..4e18e2c 100644 --- a/drivers/staging/comedi/drivers/comedi_test.c +++ b/drivers/staging/comedi/drivers/comedi_test.c @@ -715,6 +715,14 @@ static int waveform_attach(struct comedi_device *dev, static int waveform_auto_attach(struct comedi_device *dev, unsigned long context_unused) { + /* limit max input voltage to 300V [typical oscilloscope max value] */ + if (set_amplitude > 300000000) + set_amplitude = 300000000; + + /* limit max input period [= 1 hertz] to avoid too low freq */ + if (set_period > 1000000) + set_period = 1000000; + int amplitude = set_amplitude; int period = set_period; -- 2.7.4