From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "augustocaringi@gmail.com" <augustocaringi@gmail.com>
Cc: "jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"emilne@redhat.com" <emilne@redhat.com>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"sagi@grimberg.me" <sagi@grimberg.me>
Subject: Re: [PATCH] scsi: srp_transport: Fix 'always false comparison' in srp_tmo_valid()
Date: Fri, 27 Jan 2017 19:42:28 +0000 [thread overview]
Message-ID: <1485546128.4267.25.camel@sandisk.com> (raw)
In-Reply-To: <CADFy_4HK9nxcB0xn6_Hw6xVKgJKVuVfkFPTsfQSoe-bJc6gGMw@mail.gmail.com>
On Fri, 2017-01-27 at 10:06 +0000, Augusto Mecking Caringi wrote:
> On Thu, Jan 26, 2017 at 3:11 PM, Bart Van Assche
> <Bart.VanAssche@sandisk.com> wrote:
> > This patch is wrong. The purpose of the dev_loss_tmo >= LONG_MAX / HZ check
> > is to avoid that the expression 1UL * dev_loss_tmo * HZ further down
> > overflows. Can you check whether changing the if-statement into if (1UL *
> > dev_loss_tmo >= LONG_MAX / HZ) also suppresses the compiler warning?
>
> Hi Bart,
>
> Right, now a I see...
>
> Doing your proposed change the warning go away...
>
> Do you want me to send a new patch for that?
Hello Augusto,
If you want your patch to go upstream you will have to repost it.
Bart.
prev parent reply other threads:[~2017-01-27 19:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 11:17 [PATCH] scsi: srp_transport: Fix 'always false comparison' in srp_tmo_valid() Augusto Mecking Caringi
2017-01-26 15:11 ` Bart Van Assche
2017-01-27 10:06 ` Augusto Mecking Caringi
2017-01-27 19:42 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485546128.4267.25.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=augustocaringi@gmail.com \
--cc=emilne@redhat.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox