From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750996AbdA0TqC (ORCPT ); Fri, 27 Jan 2017 14:46:02 -0500 Received: from mail-by2nam03on0083.outbound.protection.outlook.com ([104.47.42.83]:25248 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751013AbdA0TpP (ORCPT ); Fri, 27 Jan 2017 14:45:15 -0500 Authentication-Results: spf=pass (sender IP is 74.221.232.54) smtp.mailfrom=sandisk.com; linux.intel.com; dkim=none (message not signed) header.d=none;linux.intel.com; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac1c2133-4386e98000013ebf-1c-588c1d32838f From: Bart Van Assche To: "augustocaringi@gmail.com" CC: "jejb@linux.vnet.ibm.com" , "linux-scsi@vger.kernel.org" , "emilne@redhat.com" , "andriy.shevchenko@linux.intel.com" , "linux-kernel@vger.kernel.org" , "martin.petersen@oracle.com" , "sagi@grimberg.me" Subject: Re: [PATCH] scsi: srp_transport: Fix 'always false comparison' in srp_tmo_valid() Thread-Topic: [PATCH] scsi: srp_transport: Fix 'always false comparison' in srp_tmo_valid() Thread-Index: AQHSeNV9re1jT9/WGkOx9DXGGj3KLA== Date: Fri, 27 Jan 2017 19:42:28 +0000 Message-ID: <1485546128.4267.25.camel@sandisk.com> References: <1485429447-19103-1-git-send-email-augustocaringi@gmail.com> <1485443483.2980.1.camel@sandisk.com> In-Reply-To: Accept-Language: nl-NL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.28.1.254] Content-Type: text/plain; charset="iso-8859-1" Content-ID: <97F84E9FD4D3E144A338E0C7C03CCA53@sandisk.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGIsWRmVeSWpSXmKPExsWyRobxn66xbE+Ewffdgha9TdOZLPpbDzJb LFsZbbFqYp7F5V1z2Cy6r+9gs1h+/B+TxbrX71kcODx2zrrL7nH+3kYWj3knAz0eHNrM4vHx 6S0Wj/f7rrJ5fN4kF8AexWWTkpqTWZZapG+XwJVxb/J+1oLXrBV3rj5kbGDcx9LFyMkhIWAi catlDWsXIxeHkMASJoltd1awQziXGCU69k1gB6liEzCSmD1hD1iHiIClxIMT7UwgRcwC/cwS /379Zeti5OAQFoiRmHFGBKImVqJ7/g0mCFtPYvOst4wgNouAqsTiu0dYQcp5gWa2rI4ECQsJ 7GSU2LAwBCTMKRAoMfV1KYjJKCAr0fKaG6SCWUBc4taT+UwQJwtILNlznhnCFpV4+fgfK4St IPF5xT82iHo9iRtTp0DZVhI/V89mgbC1JZYtfA3WyysgKHFy5hOWCYxis5CsmIWkfRaS9llI 2mchaV/AyLqKUaw4Mbk4Nz21wNBErzgxLyWzOFsvOT93EyM4dhWNdzD+2+B+iFGAg1GJh5fj WXeEEGtiWXFl7iFGCQ5mJRHeT1OAQrwpiZVVqUX58UWlOanFhxilOViUxHlfH+uKEBJITyxJ zU5NLUgtgskycXBKNTC2F/1nPtMTKa5++mbnv/nG+mdUVtnKbIlhsfAoebRF+wO79s2PEasY krf0BmrVaus0/XMprjrFPiGkvO4ap8O6omnr/vK/5+A2VJ5+w72loq8uXjBlyYp+L77Zfa/2 /Xv0XKuR3Xnegonr/0yb1sryvNnXeZur9MoLRXL5O3j4t7w8Gp963k6JpTgj0VCLuag4EQBd OSdd2QIAAA== X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:74.221.232.54;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(39410400002)(39860400002)(39840400002)(39850400002)(39450400003)(2980300002)(438002)(3190300001)(24454002)(377454003)(377424004)(189002)(199003)(106466001)(36756003)(189998001)(305945005)(2906002)(23756003)(33646002)(2351001)(69596002)(1411001)(106116001)(5660300001)(229853002)(4326007)(3846002)(626004)(2501003)(102836003)(50466002)(103116003)(6116002)(1730700003)(53936002)(97736004)(81156014)(2270400002)(5640700003)(8936002)(8746002)(81166006)(39060400001)(8676002)(47776003)(2900100001)(92566002)(86362001)(54906002)(50986999)(38730400001)(54356999)(6916009)(356003)(110136003)(7736002)(2950100002)(68736007)(76176999)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1PR02MB040;H:sacsmgep14.sandisk.com;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11OLC002;1:X920dTPfuu5r8Pijak7Lc/PJ5sxAHEQDZGzvejGVZ4xCjACYkoX3qh5gNGHQy/ELfpNVxoq524EbjCkAOHOGJqySBNUVUYnmU4Ofg81+aVB1oCJUOE0V1sJ+MhDCN3/asOV0/FjnhLXaHAiwiIr2YLyq6UFPJxd23KkARnVd/TSDc+scnS8McDfy43Ma7wJdICgeTeMHyvLAJzZR61tcw9ce8NwHXiDFboCw/bxSk52osn2tVUCqNO63VINj93O8kafujLel6PVn1GRfY4nU/hMevJ05PoWooG4ETkvZPJKtddVZif5nvpHnGsJW43JuZWrH0NJWiRlYkTZ9jxDCvgOHo4ecY98n1ZbZQWVb6J3RbWMamhCrDESflINtuJ0C8bS+CxjFp9FLiwFCCxQzQKkN4jO3feLpLDLg+ScMpnNnHdp8TCruHxQv18PQ1QKpidHnzbpOSyxXf1gOFbbhG/xzOGYFPG5uXujOvutwQWxzkgKcL/040tSALfpgqdN0e3aNutto9AfTYzPNJryTmgxSU9wdWSKuwiWqYLLz4S8xdYQT8rt6a/v9MZ4l8nlO2Nl7ijJispDdmfWDEPgjbzYwyma/9yoPaK2vQKlhyH557V0eAEw2ErJZ+xFz4l2N X-MS-Office365-Filtering-Correlation-Id: c63de1f3-619a-4221-24c8-08d446eca45d X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(8251501002);SRVR:BN1PR02MB040; X-Microsoft-Exchange-Diagnostics: 1;BN1PR02MB040;3:nN/JpzXa/EL2HKHpy3P7icikvRfKLQiNHRlzhoPjEmsK2gJ+jSlv3etJP+k2Wlv50BbWG9hzpQCJfK5Cw225/yyHLnAmbfsoGjuSRKHBI3t8m15TRJT9xxpd9FdXxq+UqjELglyAWqHUCBfCvbS8I+RhDqAm9o7OqR9awmxYLb1nZLRFLLNXdEiyIsaeScxdLBbQ3UzQpWaYbyF7mjJQBz1DA8w2Ofq2ms7Qi3MyW3PBfpQplfDRYZuhqSqPeVSgWKe89/MA861ESydPKL2P7Xr1+Yggc0+kxItxCEQTIL8DL6TB2Pxja5lZbCuGn/KWN0R5ufpN9kMUvqbTbxdE/X4wV6Oz+i4XFiOyhVlmCc7zk+j2E5JHbTlDYPOl5TDGo3Cd50H7fzI0ASnkPB3DXA==;25:voJHgl+6cZe2K5EqBBPmfZWLpxm4/TzIbihSJhFa6gDV5u4eEH7CqzD7zxKW4CV9zva2K++KpA/ZeAmzPYFG1Jak16DeHKbrMi8PBptOyzQ0g9rOmyXUzAtbbg5nTFwAmJt+CScXM/a+8Ev7ffZAFSmVXx7nWNzan5jsalTmkQ28U2lkwxVrN7x3Y1Xxtqoei33GLS5kYnZjp7mOnsjtYtHGgRZ/n5MiyfoPgg0fdoqbtj5tOcsSCk0Qe5r1j7VtzCUpv5fOVyu9p2oqoadNYosYu8iGDU1vlbl0UPpMu3tT5dsD2d+0PTjcOU5qxCi03+qExDky5gR3SQ5DJDhXRW8Xw5jjgKBql508DLJBZAgcnERCTFxt9KW+181HM5kuDKT/7kpOzPIbzoKN4kNm4Nb7uLcM5PgCb1AxjZOpHGs4SF2EQrpikI7Rp8z94aGlZs/wlZ+vfpUb5RIMzJtFxg== X-Microsoft-Exchange-Diagnostics: 1;BN1PR02MB040;31:8qpdbx2NmCzjOBczqjP3kNB0F5ZQVS61rfg0qdav+j5ui5ENBvlND94LVITS9DUkUsIs8Gxn/vR5pH/WWSStEDcmSMmPW/mzM6nC7pG0IrSgdBLxewYd8KshmuTW38asxqQi5CNzEUeD4OL3hRo1Mdvrm0+RWRJ+xRZiFpL2E40xTezGVXolslbYFdAhjn76nW1q4FUT+oD4zgGK1xQGUH0x/nsEuKnsOS7MQblubLQZNzgv5KeGldE9rqEjU9udImEW2B3VnN/+lufx2y9knV37i/7JHsBOUPm1y1ydgdI=;20:YxA07LdurQSwmJBLJjXiPxr+ufN9yvPRdbRKq5DBf+blnGZ0hjZJ2hngdFZmstQTEeqzLGUuKmMVbUGhZBzt4tBNyrD//bATSikGkgSe6ug2mE+RHN/G9jscDkr0yRtlvUBwu8s+4Q56CL3yv9DldvewkSP/fDE82/Npy0f6BHXt3Qs7WWAdpDFR0uTZRWP4pt4BLEeH2kdJyj2YPY58lFzuyNV5On1KE3PQ8ZjlD814L6uxGUcK/be8gfk1woMOiuChmvFzFbZJ+emC8pBjn8LE/g4jxeLIpUMzQkw1arA9eUu1qQj+13jKpLkPGo/f1lcRpaFVCP/BtxlU5rlZYnlscVSX5uzTakYwsbGTidHFpG91tGynskGv5MJ4+pw6fazLWgY4ypZ6+Mls26cGjt2lOzr3gZfUmrmLRvPb3CvCupq80o1ECjyfptrA+5bCGfJ/48lm7C8db51Hu8Eu20lhZBX/woRiWDWCbfNdOPYKz4jtOUPA3veQBaOYwqoo X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(42932892334569); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(13018025)(13024025)(13017025)(13023025)(13015025)(5005006)(8121501046)(10201501046)(3002001)(6055026)(6041248)(20161123562025)(20161123555025)(20161123560025)(20161123564025)(6072148);SRVR:BN1PR02MB040;BCL:0;PCL:0;RULEID:;SRVR:BN1PR02MB040; X-Microsoft-Exchange-Diagnostics: 1;BN1PR02MB040;4:0oQzVAfS/452wQgzs1FxiGCV+ip/iumnEEUAt1fmmVeajqibuuJ7QVZYIUfzzae0HitAd9Q2qBKZNY1TXikUIsWwoFX4op0EvDeHNkp3j3bKo64NcuCsd7XJmDzo5wkNJD7/mz2LVJIq6JKlt6P8rMcOXx2oMMhOsKtnTc/bfmOQfJu1glhPCG3N+KTVGkUwXALKTdxdoOlerPL+wkbzZIZt4x0xGp9coSU3gSLAdbtK8pp9Q98Cc5AnC+wDByj67gussIx7ED1ja0Rad9SXSUMsq38iCfGnAy7S2TRqQdAh34S6yDGIPyRtubGWsnsMHU0sdb4v0BuOWGz5sJmKGibhxCRFIzMAEcquwuqe7E+9OPLkvt/thaG+1stVIzEAWQQHp+ym++bAB5A5qAEiDwRxMcqUiK7dFvdoBJVsBCbUsT8TCp5knR9a39qvoKG7YH+rT7tnfeV9NHXrBIFYpfEgw/HX3cLWCkzHjnh3WlQFfU6q78o5ihTtyfF6yaJXcXN2/67G0ZHyuW5POrvbM+ddz1fOURpmtzM+bfjkfykpMxUBGLD4pFMFVg/3koUKdOvhebo7b/xi8WdvRqu0L+Mbd3m5/hOjtbuWst/ioZbELnIN1WbMSG8X3jBPPru7Tg+CsggrbpOcnTOU6vSZJODTP8+ka8seJxYuI9uzoKc9dkTEmiCS/5Dbap0vClZ12HjQZauWys0HNzI8dA9CM4RBk+a+Rk3PqW9w8rQhUAg= X-Forefront-PRVS: 0200DDA8BE X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;BN1PR02MB040;23:Vci3aHNxll9YMsZNjHGUZmE6tLdzunI89T8FJuxD?= =?iso-8859-1?Q?8HHeRD95jueCqRQqZlz11KxCDZkyGoHpaxdWRWg87kvMmzNsTJxUR9nJB+?= =?iso-8859-1?Q?Wxa6NSUmpRK1SAKrVav8EDJocn8GLomqafToL27tWf/7AmkCwu2xIBPp7Z?= =?iso-8859-1?Q?6B93w5HBCD+pP9gNqT4YZIEBxTb7n7312Ur/WvavsJcFTXX/rJrxjcwmon?= =?iso-8859-1?Q?eFxt5iTdOlHtHNLnS0yTijVKfpwHxRvZWP/NtzYhp+/PT5sZvZtsUynEOj?= =?iso-8859-1?Q?a6kA0Ne0TowxPaaYD5Z3/1xWI+stG3sFt9hX0kBSet6Bk9/BmXwYchV7LT?= =?iso-8859-1?Q?rNG9X9lYx6xSXEkDzAhJwBgwR0VtFSjrgkAXVfKszRAZDoMpBsVBPqePCR?= =?iso-8859-1?Q?xCY/FXxzooL6ZIbBP14p+T/uCy43YVel0HH0rNYKxB+P0h6NNphBx6ooNQ?= =?iso-8859-1?Q?9XXaq0CNHAAIIB7grCU9EnOkH4VGEUvl3aCCzjJdETVkjVJgqgvRxgH2wf?= =?iso-8859-1?Q?emDC8q3n72H3v3j26eLyrBuxB+2Dg8ZpzSOH79cTBjtvb+UOHdrd9YUTqZ?= =?iso-8859-1?Q?Wp+EPHXl8O4H//uxVe9SY8mb4MMpqqMbJm+zyOWsc1g5y+ZS1d12R20CEx?= =?iso-8859-1?Q?LjRwF9QyCNXtjOaitdy7iqYRJmm+zS7bNzEVVH8KlxsX6B5O07kyFQcdtO?= =?iso-8859-1?Q?GR1Rk2JI68iXhwpEbZR763bz8eBImOR5kmOBxB5H+TlYx9g2OaVEVPFI+U?= =?iso-8859-1?Q?RBaLZu81cX2dgs2zDeliiVqYrGUKSmxHghY2UZYSHYPzgP2t7pq5ynKQXo?= =?iso-8859-1?Q?ZJPPdyVl9J7lFuVRuYC5SCze98MWx/1wHLpLiamQf6dlaeMyJTOAS3Pb1Y?= =?iso-8859-1?Q?VW4qflYCXMB8D4TsYPoRVtd0ZWkAxaKK9oEn+oNw+ryfotRqtwfXsRaT0r?= =?iso-8859-1?Q?SkhtPezcWWtFY9UeG3BA1gH0z+kC0LJ+KsklzKtJRlnhnWOriracPrnKPE?= =?iso-8859-1?Q?GQk46Rwk+kBlPmpExTI6WO0r/QR18iGNBh0oQwabJ9ygdIu4KgsNA7kclG?= =?iso-8859-1?Q?B5Vh/vGylOoRiafZhI40SD6VKXkejgSYJrTImimGwPQF50N6YXZoQRF5w4?= =?iso-8859-1?Q?koFiW/LgGwA+jVjGlvkQQiczKqMHjkht5tfDTl5kdovx0CxR74QQK6g+J3?= =?iso-8859-1?Q?4/yESBTQ4xRhe9jD2R71dqUFe0LWmIJ/n6RWZfl3TXaoxAS5Mc5kJTRIY+?= =?iso-8859-1?Q?goE29HM1LmryqEdnVT5vF4fYUKgY1X+/bLTwC4RqxmD//IW9MXi9MslvLj?= =?iso-8859-1?Q?JPt38KQqGopjAjR8kypEX+J4vc+KW5Uy/G0QSxxCrIfQ9ulNVgiU8s+y3v?= =?iso-8859-1?Q?oleYiU1UFQYawmaU2g3OMU9PXxqkr2m5UhjLSKLluE6fStD65DmT5uDm30?= =?iso-8859-1?Q?G1XIXpZjgFLTAkp2nuO5cK/jp5BJeItbexBhKll7C06QjfCvs7KHaMhbKk?= =?iso-8859-1?Q?UJIU/7AUztwrXBPhzRWLUDn77aTkYTR+dhYX7M2OELmv7C5CMsHj4MfN+8?= =?iso-8859-1?Q?J/i1MwK7gsn1oJAeKrUIgAxRE=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN1PR02MB040;6:SKVEAm8rgZbD7xBcdvVBdtbMfcSL11ozwBFmSJ5Ft3Afp6KXZTf7LOWMtd4pJ0gYVhyws1Ncok//bGrf/CqcOjhaH5xGWgDSTMsfCsq65cpvzZPGrnEnTWuJyO0sucB8nfnDkcaTg/WxZ066FiN8Godq470b4HDW/znj8fLy1WdvuXX2Fi6KDNAwA+mtYwUiuzGfbnwJAXfaCi/P5IPObwzFuryxlB71mArSTHR4t51EugM5zlz3Q3WHgV6OqIntDvUN9zfdUD/tm6pmAO7UlN/DqwAAsAbyhu7QOEnns8fB8rQMiD2eIEMf2Y6vVNi8kgYQh6Kd7F1Ide3JGGDH+xq7nTwM1IxyW0wUp8MhfHfdK4iWDAmzZl1i5/IKKnowkUmdpPeagaLGpIC3iMdPEjNly+55BFd6qk2W8L6IpPKvnpsGvTaITbh+Pst1qSvISeZTa2Uj/OprK4Rw6KQD1Q==;5:67ZQFnv2ozeqlLbQAs2+DTl+ii8iT1xT5/WrgClrN7sQdg+Iua5gK1RF66Lj6XNdsKqFfiMlYQQN1YZBaGglrM+UotRhyK0O2BluxDaWfRjJdvm+uuLZbB27szOqmNucm4sPSnwsCMAlIUnQ6Tsgog==;24:QatAM2MSSvwlJny5DPa4MZ/l2ySvsqFyr0qt7LEKmZ0ZUmmwBcXeJVcsadKEOIp5aTPyFIbl4rFWO33swkTjwhqIc3J0KkrzNYThQ0xQVdQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN1PR02MB040;7:IQm58MkdxU6DBpRFJfzvR5gUZ98J+MtiF93LxEBDOF3RnbIsl0BfgLbPrvg9CMbmOCPkfzK2W+T1AdC5fG4/qfqXPzJDWtu7lLhGlnR78l683dzIbT5Dd5BIGGzZSDAlPR4vlJfZdkmDMfxPGM81WVG9IsO3DRK+88HIoO1avciYgWte8nKrBlbbHGUgG0LqPosHh1hiOO6jko1bkzvwxx/WAr7XFE1OtRPmOAIIMmWJ9VWzwUZatQMtHTSgDlp0mAI10nJX6asaZ3LtM4kNGY5CDCXSC7m62H6TwwiOxDFj7OesneDjEHAnmmAnuwAFQ59L/iCdK2l/CMId+UY/gWfbwCJOy/kfcreRJzLoE4Z+n95sR+i1phMDFu5SEQbA8BA+gFErZWNM/se0+gmss+478NiCH1SJWBGP5T/FxloJuI/kyDnUzfuvDgxH/rx1JWcYbjwNIOgJfdsUWDCo5w== X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2017 19:42:34.1920 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[74.221.232.54];Helo=[sacsmgep14.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR02MB040 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v0RJkWun016436 On Fri, 2017-01-27 at 10:06 +0000, Augusto Mecking Caringi wrote: > On Thu, Jan 26, 2017 at 3:11 PM, Bart Van Assche > wrote: > > This patch is wrong. The purpose of the dev_loss_tmo >= LONG_MAX / HZ check > > is to avoid that the expression 1UL * dev_loss_tmo * HZ further down > > overflows. Can you check whether changing the if-statement into if (1UL * > > dev_loss_tmo >= LONG_MAX / HZ) also suppresses the compiler warning? > > Hi Bart, > > Right, now a I see... > > Doing your proposed change the warning go away... > > Do you want me to send a new patch for that? Hello Augusto, If you want your patch to go upstream you will have to repost it. Bart.