From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751527AbdA0Vcy (ORCPT ); Fri, 27 Jan 2017 16:32:54 -0500 Received: from mail-co1nam03on0076.outbound.protection.outlook.com ([104.47.40.76]:20523 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751501AbdA0VcC (ORCPT ); Fri, 27 Jan 2017 16:32:02 -0500 Authentication-Results: spf=pass (sender IP is 74.221.232.54) smtp.mailfrom=sandisk.com; wanadoo.fr; dkim=none (message not signed) header.d=none;wanadoo.fr; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac1c2133-0c3ff70000013ebf-d1-588c36d65986 From: Bart Van Assche To: "christophe.jaillet@wanadoo.fr" , "hal.rosenstock@gmail.com" , "dledford@redhat.com" , "sean.hefty@intel.com" CC: "linux-kernel@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "kernel-janitors@vger.kernel.org" Subject: Re: [PATCH] IB/cma: Fix reversed test Thread-Topic: [PATCH] IB/cma: Fix reversed test Thread-Index: AQHSeOTI2YeN9+8kKky72YK1YeQ6yg== Date: Fri, 27 Jan 2017 21:31:55 +0000 Message-ID: <1485552696.13218.0.camel@sandisk.com> References: <20170127131535.19918-1-christophe.jaillet@wanadoo.fr> In-Reply-To: <20170127131535.19918-1-christophe.jaillet@wanadoo.fr> Accept-Language: nl-NL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.28.1.254] Content-Type: text/plain; charset="iso-8859-1" Content-ID: <465F2579B5B9E74495C91E6DD310C9C8@sandisk.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrFIsWRmVeSWpSXmKPExsWyRobxn+4Ns54Ig/1r1S22HpzLavHy/AdW i42bJzJabL0lbXF51xw2i2eHelksmtdvYHFg99g56y67x+I9L5k83u+7yubxeZOcx+e761kD WKO4bFJSczLLUov07RK4Mh4cX85esIqj4uC9U+wNjE/Zuhg5OSQETCT6WhcxdjFycQgJLGGS uPu+mwnCucQosbhlL1gVm4CRxOwJe1hAEiICtxgl3n57xgriMAscZZTY++4zWJWwgJ7Es127 WUFsEQF9iXn7ZgGN4gCy9SSe/9IHMVkEVCUOznIEqeAFmnllz3R2kLCQgJNE34VykDCngLPE 3r4dYI2MArISLa+5QcLMAuISt57MZ4K4WUBiyZ7zzBC2qMTLx/9YIWwFic8r/rFB1OtJ3Jg6 Bcq2klh9fDkLhK0tsWzha2aICwQlTs58wjKBUWwWkhWzkLTPQtI+C0n7LCTtCxhZVzGKFScm F+empxYYmugVJ+alZBZn6yXn525iBMeoovEOxn8b3A8xCnAwKvHwcjzrjhBiTSwrrsw9xCjB wawkwrt8F1CINyWxsiq1KD++qDQntfgQozQHi5I47+tjXRFCAumJJanZqakFqUUwWSYOTqkG xo2f1mq1+UyUUXfMvvp+yr0DgaFq06T9z+no58Xd6+8+dTrq3X9Gl7iT7L7yETKLlN8ce+nM zDCX697S7Xs+ub99zHvF9ZBvR9S3M1fLJBdfbzBZtEJt04FDqzULrSdFMKzxyiqvj3pg0vJk tmDfISc/A+ntaZvU1gf4V+VM8WWvP7pynlC0tRJLcUaioRZzUXEiANYAJAfNAgAA X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:74.221.232.54;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(39840400002)(39850400002)(39410400002)(39860400002)(39450400003)(2980300002)(438002)(189002)(377424004)(199003)(24454002)(23756003)(626004)(2950100002)(106466001)(305945005)(356003)(7736002)(50466002)(81156014)(8746002)(8936002)(8676002)(38730400001)(106116001)(5660300001)(81166006)(39060400001)(53936002)(2501003)(5890100001)(92566002)(229853002)(76176999)(54356999)(50986999)(2270400002)(3846002)(102836003)(6116002)(54906002)(4326007)(2201001)(69596002)(86362001)(47776003)(5001770100001)(189998001)(2900100001)(103116003)(68736007)(36756003)(2906002)(97736004)(33646002)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:CO1PR02MB048;H:sacsmgep14.sandisk.com;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD029;1:zq3yXtJ8WE9liLNSXvONGF5Ix8A/XemgYLMJufqx8IqaTNB5U1m3Bu+bKE5JZo4X1mVairy4Ty2HT6ZRLEOUl8duaavnbhxBoFBGPfgd99rWD/sgxRqxBZ66zQEgg/i2TsctowSmGuUAAZvsoX42g58Wcpqdhuq0blzCXI8+qymWp/PcQwYHNwk6rH3K2bh7MYGO1D5+7B/aVyBMCMg3x9XwFRPo0DDOnhs17T7YGBmumdU84UzsyPFIFovRNzDN6hsGmMdxoWgu2KmKLtcFq2APHPglr3HjH3DweOjlzEXPPkCw1TyeXyPqL8waVpHPWioxQTl6h8eKzCIqfMf+vGIcpC6p95+2wtT+q81ge3C0xvkseAI8On6WURO5vQ1eINA/j/QqTEhPAABssGVINxs36z5pzBOG3mhBOoyYtau4w9jy3Xe0t765WCXJUx91opqSh6/7chDyIcJA+MKIZd9eBXNPzH/NUL0Dn4qwE5/xjyYdR2FcUoC5dYVadIVRwxADF/agP9v06TluZHdnxZToGw9xoMiXoQI8CAcPnbQU1ZuKpa7Uqbqx00LRqslM X-MS-Office365-Filtering-Correlation-Id: 1a24286a-873d-4905-dd99-08d446fbed3c X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(8251501002);SRVR:CO1PR02MB048; X-Microsoft-Exchange-Diagnostics: 1;CO1PR02MB048;3:kNxNf0OYe37qq2wlqTamUAH+qhWrj0TC82DkTC5U5dc/IPdyvIpoiXZocnknc0mq3uYw7lmq58RqqZPF0jQIIX9BHHyLYu/9PJ4SqQBUYTXxDJCYkcjQD2Pd6ml0Zxxmr47Hbg2j2jlZXeT8EU0uWfRaRR4z0jpTVnBrNr2ELrSALFA4Ahh5UbpGNDSlak6dFgNQD5Ka4GnFnVkV5bQ26ERbE89SEOBJQGTATWi/buSGaXl3/vFtOE1xGtpkdNy7m9EA7qFF8pQIw9SC/TMy35oM6ys+yMPzQdLyLMnUnC0w1FORIR53gUrH4a+ejdRZC8ciD1ON4FBcWwBBE2wvYlZcYzkwmvgHX5rvTdMsXNqmda6CJnONWxf/7hJwWnpf5sj4sjBf6PLy5XL5JucKnA==;25:3MUQxHIWGSeWS5m9aII4Ml/3pRYlsPGQcMTKURBYJqg8FN3JTagjM5Oqo4gL/9kj+EurRXXXJvvtfGeFV3FQFhBYfa3ax9jVGDfziuxfmGGVPfdpibuoD5kxACfcUk2PiPyFr64M+fDwYYMJCyFAIkGX7jNOXYUvkA2ny3e+luLCAxvcEKkJ1gCituZzC54sT1heDVgZ3Z3dPE3wb8JjDDYdV1ABkIoBsIOQI0NXyZjhlyYL+LygLi3d4wYixoeBlYkKK6eBZTURscYgoJ7Jz91O0d7T36ScihaECoHwr/8cQzJhR3fYmraEYDGFXaWdAnKaXj5+jdQfRC2JsdMM9UWbbit1OJ9alYkuINHXcgyTlX0ZYD5GxUqz9amcxXlMaPVzvs2SdqTCGzk9YNDeklZz3aJWILXCUzdLbYYZX4J3FwgheExsfM4+xCMuEwiTjQELc7p1DzzvAWI0rL24xQ== X-Microsoft-Exchange-Diagnostics: 1;CO1PR02MB048;31:4Z9cBjO2kDR3Qbm8dhi17Ew03WGro0IHRhN8i1K5E/XN+Dt81aQG6/w3Z32r0EFYAFY3/X/xH0zN+3AJ5oBsHVzCbOIO9pX6uArefIn7iIDAAj2MdDUwm3bHB3fLez/llzhFLd27i+TpMdj007ezP5Lxj/aeWMPC2HlaeKm3uitzVSqkP6+psP2YjjKsXyrT9y9KbweMsk1srIYGYIoBK7Gz5esb/MTunTEiOrHUww00IWn99YMZvWqtFqM/o8x+Z0qETSfjQW3nZ8QAIeGRLfQlo+A1I+/xslPeHXBU60k=;20:73WMqhpBSvpezKCJKyI0E9JLbtPeB4eNTC+i4dTxQpFogmDE+atlijY+/lIb1MGoYubViSSqGXpMlLVho+kN7GUEflJ/JorgpUqKNYx8UNEvZYRlMJd1OuJTS18NjcQ18i1je/PyAyPjCPXzM8l0WcGR55woIB2bDVegE0kRS9fLHYQunB4drGpoq01WR0wnO758SNpVWWdQfbd8h2f9pxOH/oRJWpu2QLjvT/Blol4yTFoamYIppOqblB48vNHYAwvja3RGe0cgDscCE5vuPG/VBlXHS/xBegcAcnj/YoTTH773AZu4yTQ/+LBZjSGtjGlqnHNqavVVGGA5PZQwMGIiQ5rYqVFsZ+PPEcZSBTfSHl8gEv1Yu1uejmlXTViErAg6N/SmSn0XxIojrsblpZP5GbK30PjyPE4dhHmij7qL0Ab7aYUIVfaTzcoLKF3fOXRbLw1NJCvzoFU5Yzr+nEaB30QNb+pLZbAvYbHzHFumKud0UTt1lqWaTJzBb1FJ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(155761271638844); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(13023025)(5005006)(8121501046)(13017025)(13024025)(13015025)(13018025)(3002001)(10201501046)(6055026)(6041248)(20161123562025)(20161123564025)(20161123555025)(20161123560025)(6072148);SRVR:CO1PR02MB048;BCL:0;PCL:0;RULEID:;SRVR:CO1PR02MB048; X-Microsoft-Exchange-Diagnostics: 1;CO1PR02MB048;4:to2YQ8wxLQa9Is8fR7PcqDB25NOoZuUbxOXBYwArjLOS+I2MzK6a92D9y2kXatjgZdhMC90KrWRQIskRN5hPBSh47oXyvYLooYRRuw5gLnAcZi8kdXhIWtHhtbam6bf1m8ZX8WJ8TYmyoxTloILrQJfnr4FovUSefDZ2ZRD3WYlEqyG44vpVyCh4LokpEjfOIKtW8kJWU8t4KD8sFRAAE3AahYMBCsHtB8sXjbgUQDkg1J4rBPy1QTG+zqJy5bQeKCm1eJI2AjKqF7ePjPRlVnbfFO55GvMwj8iN64OnbjTLOW/v2Ufmn/e/bo4/eYd69RZy7npO1HpwS/xrvtgYF91v51QX7da+fMRhqhA6o7/GHoJVgxrcwNkuR3Qtglqs37UIHn5OcWdghM8Ek5uxnF+UrfhMzZ+S9me+3p2m6sEqBzMkf01IFdBT8bTA9ykM9kUUPE+flg283HwHMiYm2wQ9+okEmbnF24/dbC9RA+123C+cQYfBOD2gpB3GHfohMKaRnf8tSiHuwuOjtZ6be+ucjsRusqhpyaGVws8Vcm8C1fq+a8sghLIMpL48+dRi18iZ7SwyVnpAVhCKhoJYd2cBg6d8SqMyOA5OB/9xWT06y0n4dX54KBy8CnFJhXMT5ubxdqKWQxt/w/t0NXkIsTSWFKg7Tt3WTZ7gk4UFyVHdqUsFon2YmIUGA58FR2UJ/Ij9Ix6UOZ5h23dPYQNPobx3pmlpspVF+S/L905D5ys= X-Forefront-PRVS: 0200DDA8BE X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;CO1PR02MB048;23:xORKZorJETc98bucTaIprlXM9bgWta8/8TFkbJ4u?= =?iso-8859-1?Q?ADckVzDxdfO73whBIYf53fBQsOLQwHLSdO78iV1RAs1qjl+6OMg+LzAo0a?= =?iso-8859-1?Q?F7I6BidFoWsxXbz7hujb2G14CRoTQFnyW92rsGqq3fu/uGqTJppYYGS9Ec?= =?iso-8859-1?Q?T6VpGOm5NFyiuUVt6qXvi88+Gww+AQPiqhfDRVoVZKVClVpBEzjZ6K+cOt?= =?iso-8859-1?Q?CFqiFvTDIT8w333FY9Frwk+3W6/yVqMM/1wF/dWkUAJgekfuEA9QlS7baD?= =?iso-8859-1?Q?YFwOBVRIpJzvRYVTwc3gnj6xMtbpDmNKXa1ALb+hgdZ0V0OJEYjEX+tmd4?= =?iso-8859-1?Q?xvd++YF0wAE/lU0LBiWej5pJMQjL2lt4MABLVnI+Avq4TMT9QJjt2Mn7Zp?= =?iso-8859-1?Q?nLhCrsGMOjerz7MjNVUlIR3Xd0rdw6e+JIXvI3HVSEUk9xwWSmlYR4JgOZ?= =?iso-8859-1?Q?eM9PQqj8ZZYfAO7jPJ8TDDlXevkE91zDJlFpx13Yytzx5r/hNjqkZXs5Td?= =?iso-8859-1?Q?AwtbtJp2aD8M7mCj3ejqptUAQE9jw1KX9wGT10hDIJZYswdOYTm38Y/fd4?= =?iso-8859-1?Q?IECY+0N/YvLoe9Z0qa4AiHy1/Uzzr/Sx9rSE0J2CYJEWh/ycXQMEGziCVp?= =?iso-8859-1?Q?CM7UK0xYdwQg/WngicQMC4WqLFMRLsN720f/jTcj0SjdBK2jrogr32T2Pe?= =?iso-8859-1?Q?pf4rfAHTBzn8yykczib5EbWpo+9RKuQu46wx/UOW1PmfLOi+tXVX7SdLoz?= =?iso-8859-1?Q?+P9tRZqA921HZzQGg26ps7cieGJnP/KZP0auetIUDG+fJd3Put02TI6pw0?= =?iso-8859-1?Q?MmA+WUq97j8B4slU73n+AkUET3CQFXwSNz5bMfu/YBOYgtaf9Y/o261dt8?= =?iso-8859-1?Q?eb0nGz4kGEhzy5JfxQvgYzYwNUVEeGFAM2h4x77uGidFpucr+njYZUrsDr?= =?iso-8859-1?Q?pCxLX0G9qSK/Z4yRq2HAHSU+AivhJBfrp6aIY+f4br2jhi3YmzD3shq+1t?= =?iso-8859-1?Q?GVpys3HsfbuWjegGceb6HMzY8rMwTxgGpZS+jolKnSS5y5SHjz6YK4Jkif?= =?iso-8859-1?Q?vJ7Tk5a0QMhiYXSs5Jjr+7XIKre6EMANEQzFxt5hmv+iKugRuGHOT9ppje?= =?iso-8859-1?Q?y88mr4XoaFh424xYheRPNRI+Xon6GppG0+KVfe9mP4uDQRpon3mq/E+CK3?= =?iso-8859-1?Q?3vBhLL1hY84M11vYRaGQHr02VAKOIl/3fkYqqJS4S8LQ2BRu0F4Qjpyn/G?= =?iso-8859-1?Q?tIhkumPxMjau+1YEnwxvF4LxfrZLFs2SkSTlXI6+U6UhuvdlmzwBq2if7O?= =?iso-8859-1?Q?gu7d/5nldn1wi4gjIuKIT4WDCwwKa/+s2LF22yJcWvq1xzyXJkwikpwPV4?= =?iso-8859-1?Q?+32bqJHQ46ng2TP6L3aWCTSu7VXaCFkIun63kpAAcQUFhxZ4AUCUZ7Aclf?= =?iso-8859-1?Q?zPvyq2JNZUn+WqIpD4VME/R+jQLrZPyJOn?= X-Microsoft-Exchange-Diagnostics: 1;CO1PR02MB048;6:w/en7HFuG1Pqg0guQOuDYfw5v4VSgjcIepNOiYyKFASm9bjzJSizkjiTdWyF8UohZQzVJgGt9fu4PXN5+CnPxbHRYFJWp/nSpj3E3PrfrN/pCRsZHvL9jwXGxMV0WRdsWAPUAfNCgmfDJOzQDRVHMn4OCTnJLRZqmSk8CVHB1uO3sCNCEh1D3n3RjNXy56EN5WpaJ6TIF9iYjQUsWoACwvaFPjokNDaT6S250f0EvDSudqoUkjpPAlTOs/X/EKKwZPzHigBoEQ/32ETQ/mxd4KUK8ba4fDEFWN1QxXSKBT8Pl2kGxHvhHVMSE2HTpglVkZPWI9C/yn5HIcP1ktKUSCUi8IgDi3+ArvaXF5BorhTr9q7bfG1c5VkNo3nzdl4fX474TcDeJrzL/eXAv3N0zaYRfdCbiVbovpP5KeN6FHlsoTbZ7GWKNQmShgFdars9F+NGuoQTYDE5E2BKw9HEXQ==;5:T3SU+8ERmrLfSCYr7u6D5/pCnLBKhGZSUsjqvSRVgfuRItlcEaRZGeQ+NP21R2vgGKI9O7j0qIRXPGERUaFPYTGSLuiEsdhPEdCA8dnwiGcG1VD/cQ/s2TBwBgvbl8g1Jgy2wOA8uxCu0WVVkyyCuQ==;24:5PxePfe9UMdUja9KF5MxTCqE3oZ/LgGmoZhx0hEQhpm9Ra1LVJqMO7ZSzB0TX5XNgWCxfFoU7d0e+zHzjBZrh2xIT4eYfm3sozE2Ba8pkok= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CO1PR02MB048;7:xoJkWyY2+J1sIEnV1iK060PS4+F5EZ3lEqdMbeI7fLuEFUrFK59hxvyHHuqTp2TM4BMMIFULLZw7bUVaxrs0aLSV1gxdV66QBXAfW9hnthi4pNivv6GqGWopsZh4NVSAiSDvyzcMNH6WB/1ASF8Hu65e5renSR9ylx/pki3qAhQcaIbDFYVTGxx67v/46vD/aG7N2panZxzkINQsrAvQ31AuABC6Hqk6MXlpG0ruebjQPD9fmz8e07NdFXynK0GDEdhX6c0aLgWKmowcA7OxUpAoE6e24zhTg6z17umHh1FNOz94WfFRE71cOYL9e1EHBuU6jFrEjk8Dt9LK9hBQL73+0N9qxYd3Q0a54freMyGai/1lIvIM/KD98+PTNWAxZCZ9QkidRY4NEQpTswAL2rW7rR0a1dh/iWTs2xB8Ucm1HAjjQxWZ6RHRUSgaon7Gb0vUwmspDhNil80LvIPSdg== X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2017 21:31:58.9831 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[74.221.232.54];Helo=[sacsmgep14.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR02MB048 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v0RLX0xo008114 On Fri, 2017-01-27 at 14:15 +0100, Christophe JAILLET wrote: > This test looks reverted. > We should log an error message only if 'ib_attach_mcast()' fails. > > Signed-off-by: Christophe JAILLET > --- > drivers/infiniband/core/cma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c > index cfefb941d729..175f62e5841e 100644 > --- a/drivers/infiniband/core/cma.c > +++ b/drivers/infiniband/core/cma.c > @@ -3838,7 +3838,7 @@ static int cma_ib_mc_handler(int status, struct ib_sa_multicast *multicast) > if (!status && id_priv->id.qp) { > status = ib_attach_mcast(id_priv->id.qp, &multicast->rec.mgid, > be16_to_cpu(multicast->rec.mlid)); > - if (!status) > + if (status) > pr_debug_ratelimited("RDMA CM: MULTICAST_ERROR: failed to attach QP. status %d\n", > status); > } Hello Christophe, Do you think this patch needs "Fixes:" and "Cc: stable" tags? Thanks, Bart.