From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Ken Goldman <kgoldman@us.ibm.com>,
tpmdd-devel@lists.sourceforge.net,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [tpmdd-devel] [RFC] tpm2-space: add handling for global session exhaustion
Date: Fri, 27 Jan 2017 15:48:53 -0800 [thread overview]
Message-ID: <1485560933.3229.36.camel@HansenPartnership.com> (raw)
In-Reply-To: <20170127233513.GA28995@obsidianresearch.com>
On Fri, 2017-01-27 at 16:35 -0700, Jason Gunthorpe wrote:
> On Fri, Jan 27, 2017 at 02:04:59PM -0800, James Bottomley wrote:
>
> > if I look at the code I've written, I don't know what the session
> > number is, I just save sessionHandle in a variable for later use
> > (lets say to v1). If I got the same session number returned at a
> > later time and placed it in v2, all I'd notice is that an
> > authorization using v1 would fail.
>
> Is there any way that could be used to cause an op thinking it is
> using v1 to authorize something it shouldn't?
Not really: in the parameter or HMAC case, you have to compute based on
the initial nonce given by the TPM when the session was created.
Assuming the initial nonce belonged to the evicted session, the HMAC
will now fail because the nonce of the v2 session is different. There
is a corner case where you track the nonce in a table indexed by
handle, so when v2 is created, its nonce replaces the old v1 nonce in
the table. Now you can use v1 and v2 without error (because use picks
up the correct nonce) and effectively they're interchangeable as the
same session. Even in this case, you're not authorising something you
shouldn't, you're just using one session for the authorisations where
you thought you had two.
James
next prev parent reply other threads:[~2017-01-27 23:56 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 20:48 [RFC] tpm2-space: add handling for global session exhaustion James Bottomley
2017-01-19 12:25 ` [tpmdd-devel] " Jarkko Sakkinen
2017-01-19 12:41 ` Jarkko Sakkinen
[not found] ` <o6gdhu$li$1@blaine.gmane.org>
2017-01-27 21:59 ` James Bottomley
2017-01-19 12:59 ` James Bottomley
2017-01-20 13:40 ` Jarkko Sakkinen
[not found] ` <o6gese$pev$1@blaine.gmane.org>
2017-01-27 22:04 ` James Bottomley
2017-01-27 23:35 ` Jason Gunthorpe
2017-01-27 23:48 ` James Bottomley [this message]
2017-01-30 0:52 ` Ken Goldman
2017-01-30 16:04 ` [tpmdd-devel] " James Bottomley
2017-01-30 21:58 ` Jarkko Sakkinen
2017-01-30 22:13 ` James Bottomley
2017-01-31 13:31 ` Jarkko Sakkinen
[not found] ` <o6qog0$30l$1@blaine.gmane.org>
2017-01-31 19:55 ` James Bottomley
-- strict thread matches above, loose matches on Subject: below --
2017-02-09 9:06 Dr. Greg Wettstein
2017-02-09 15:19 ` Jarkko Sakkinen
2017-02-09 19:04 ` Jason Gunthorpe
2017-02-09 19:29 ` James Bottomley
2017-02-09 21:54 ` Jason Gunthorpe
2017-02-10 8:48 ` Jarkko Sakkinen
2017-02-09 19:24 ` James Bottomley
2017-02-09 20:05 ` James Bottomley
2017-02-10 10:03 Dr. Greg Wettstein
2017-02-10 16:46 ` James Bottomley
2017-02-12 20:29 ` Ken Goldman
[not found] ` <OFA049276F.2B32440E-ON852580C3.00742287-852580C3.00748E6B@notes.na.collabserv.com>
2017-02-14 14:38 ` Dr. Greg Wettstein
2017-02-14 16:47 ` James Bottomley
[not found] ` <71dc0e80-6678-a124-9184-1f93c8532d09@linux.vnet.ibm.com>
2017-02-16 20:06 ` Dr. Greg Wettstein
2017-02-16 20:33 ` Jarkko Sakkinen
2017-02-17 9:56 ` Dr. Greg Wettstein
2017-02-17 12:37 ` Jarkko Sakkinen
2017-02-17 22:37 ` Dr. Greg Wettstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485560933.3229.36.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=kgoldman@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox