From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751684AbdBALG0 convert rfc822-to-8bit (ORCPT ); Wed, 1 Feb 2017 06:06:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56106 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751311AbdBALGZ (ORCPT ); Wed, 1 Feb 2017 06:06:25 -0500 Message-ID: <1485947176.1076.51.camel@redhat.com> Subject: Re: [PATCH 1/4] dt-bindings: Add binding for brcm,bcm2835-sdhost. From: Gerd Hoffmann To: Eric Anholt Cc: Stefan Wahren , sbranden@broadcom.com, rjui@broadcom.com, lee@kernel.org, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-rpi-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, mark.rutland@arm.com, f.fainelli@gmail.com, ulf.hansson@linaro.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Date: Wed, 01 Feb 2017 12:06:16 +0100 In-Reply-To: <87zii7m5tr.fsf@eliezer.anholt.net> References: <1485516989-1072-1-git-send-email-kraxel@redhat.com> <1485516989-1072-2-git-send-email-kraxel@redhat.com> <2012885435.15821.1485812279271@email.1und1.de> <87zii7m5tr.fsf@eliezer.anholt.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Mime-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 01 Feb 2017 11:06:20 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > The binding should be documentation of the binding. I'd love to see > more explanation in the mmc/host/bcm2835.c, though. Updated both mmc/host/bcm2835.c comment and Kconfig entry now. cheers, Gerd