From: Taeung Song <treeze.taeung@gmail.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Wang Nan <wangnan0@huawei.com>,
Taeung Song <treeze.taeung@gmail.com>
Subject: [PATCH v3 1/4] perf tools: Only increase index if perf_evsel__new_idx() succeeds
Date: Wed, 1 Feb 2017 21:34:04 +0900 [thread overview]
Message-ID: <1485952447-7013-2-git-send-email-treeze.taeung@gmail.com> (raw)
In-Reply-To: <1485952447-7013-1-git-send-email-treeze.taeung@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
---
tools/perf/util/parse-events.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 3c876b8..5d90fe7 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -310,10 +310,11 @@ __add_event(struct list_head *list, int *idx,
event_attr_init(attr);
- evsel = perf_evsel__new_idx(attr, (*idx)++);
+ evsel = perf_evsel__new_idx(attr, *idx);
if (!evsel)
return NULL;
+ (*idx)++;
evsel->cpus = cpu_map__get(cpus);
evsel->own_cpus = cpu_map__get(cpus);
--
2.7.4
next prev parent reply other threads:[~2017-02-01 12:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 12:34 [PATCH v3 0/4] Fill in lacking parts and Refactor several parts Taeung Song
2017-02-01 12:34 ` Taeung Song [this message]
2017-02-10 7:45 ` [tip:perf/core] perf tools: Only increase index if perf_evsel__new_idx() succeeds tip-bot for Taeung Song
2017-02-01 12:34 ` [PATCH v3 2/4] perf tools: Fill in a lacking part no checking NULL after zalloc() in parse-events.c Taeung Song
2017-02-10 7:46 ` [tip:perf/core] perf tools: Add missing check for failure in a zalloc() call tip-bot for Taeung Song
2017-02-01 12:34 ` [PATCH v3 3/4] perf tools: Use zfree() instead of free() and assigning NULL to the pointer Taeung Song
2017-02-10 7:46 ` [tip:perf/core] perf tools: Use zfree() instead of ad hoc equivalent tip-bot for Taeung Song
2017-02-01 12:34 ` [PATCH v3 4/4] perf tools: Use zfree() to be more safe in parse-events.c Taeung Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485952447-7013-2-git-send-email-treeze.taeung@gmail.com \
--to=treeze.taeung@gmail.com \
--cc=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox