From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751599AbdBANtn (ORCPT ); Wed, 1 Feb 2017 08:49:43 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:58880 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750801AbdBANtm (ORCPT ); Wed, 1 Feb 2017 08:49:42 -0500 Subject: Re: Fwd: Re: [tpmdd-devel] [PATCH v9 2/2] tpm: add securityfs support,for TPM 2.0 firmware event log From: Mimi Zohar To: Jarkko Sakkinen Cc: James Morris , Kenneth Goldman , "moderated list:TPM DEVICE DRIVER" , open list , linux-security-module@vger.kernel.org Date: Wed, 01 Feb 2017 08:49:30 -0500 In-Reply-To: <20170201103003.ltiqrfukfyoognx2@intel.com> References: <588F09A2.4090502@linux.vnet.ibm.com> <20170131174659.b6njebycqzd5ur6f@intel.com> <20170131203452.523ckw4aphxdsndq@intel.com> <1485901910.9008.1.camel@linux.vnet.ibm.com> <20170201103003.ltiqrfukfyoognx2@intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17020113-0020-0000-0000-000000B124B7 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17020113-0021-0000-0000-0000026C3638 Message-Id: <1485956970.4068.31.camel@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-01_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1702010139 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-02-01 at 12:30 +0200, Jarkko Sakkinen wrote: > On Tue, Jan 31, 2017 at 05:31:50PM -0500, Mimi Zohar wrote: > > On Wed, 2017-02-01 at 08:46 +1100, James Morris wrote: > > > On Tue, 31 Jan 2017, Jarkko Sakkinen wrote: > > > > > > > James, > > > > > > > > The discussion is about two features: > > > > > > > > 1. Extension to tpm_pcr_extend() (used by IMA) to extend all PCR banks > > > > instead of just SHA-1 banks. It is recommended by TCG to do so in > > > > order to prevent malicious use of PCRs. > > > > 2. TPM 2.0 event log with backend support for OF device tree (for > > > > getting address where you can grab it). > > > > > > > > These are required as baseline to implement full TPM 2.0 support for > > > > IMA. The commits are fairly well baked and went through many iterations. > > > > I've tested tpm_pcr_extend() patches. I haven't tested event log patches > > > > but have extensively reviewed them and Ken Goldman has tested them with > > > > POWER hardware. > > > > > > > > I don't believe that there is major risk to put them already into 4.11 > > > > but it is fairly late so I just want a second opinion before putting > > > > them into pull request. > > > > > > > > > > I'll take this for 4.11. IMA + TPM 2.0 is still developmental and not in > > > wide use, afaik. > > > > Thank you! FYI, I've been running with them as well. > > > > Mimi > > OK, so can I also add your Tested-by to these four commits? I provided Ken with the firmware event log, IMA measurement list, and the PCRs for testing. Ken's tested-by is fine. Missing is Stefan's tested-by - https://sourceforge.net/p/tpmdd/mailman/message/35602588/ I would really appreciate your adding his tested-by. thanks, Mimi