From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752305AbdBAUeJ (ORCPT ); Wed, 1 Feb 2017 15:34:09 -0500 Received: from smtprelay0045.hostedemail.com ([216.40.44.45]:32969 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752229AbdBAUeI (ORCPT ); Wed, 1 Feb 2017 15:34:08 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:1801:2198:2199:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:4321:4605:5007:6120:6742:7901:9149:10004:10400:10848:11026:11232:11473:11658:11914:12043:12438:12740:12760:12895:13069:13161:13215:13229:13311:13357:13439:14181:14659:14721:21080:21451:30054:30060:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:5,LUA_SUMMARY:none X-HE-Tag: car72_23613e5fbe109 X-Filterd-Recvd-Size: 2771 Message-ID: <1485981241.2560.20.camel@perches.com> Subject: Re: Build failure with v4.9-rc1 and GCC trunk -- compiler weirdness From: Joe Perches To: Ard Biesheuvel Cc: Laura Abbott , Will Deacon , Linus Torvalds , Markus Trippelsdorf , "linux-arm-kernel@lists.infradead.org" , Linux Kernel Mailing List , Peter Zijlstra , Ingo Molnar , james.greenhalgh@arm.com, Gregory Clement , Stephen Boyd Date: Wed, 01 Feb 2017 12:34:01 -0800 In-Reply-To: References: <20161017183806.GG5601@arm.com> <20161019153746.GA4411@x4> <20161019155658.GB4411@x4> <20161019162222.GT9193@arm.com> <1485975894.2560.13.camel@perches.com> <1485978587.2560.15.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-02-01 at 19:53 +0000, Ard Biesheuvel wrote: > On 1 February 2017 at 19:49, Joe Perches wrote: [] > > Or maybe add a BUILD_BUG_ON something like: > > > > #define order_base_2(n) \ > > ({ \ > > typeof(n) _n = n; \ > > BUILD_BUG_ON(__builtin_constant_p(_n) && _n < 0); \ > > __builtin_constant_p(_n) ? (_n < 2 ? _n : ilog2((_n) - 1) + 1)) \ > > : __order_base_2(_n); \ > > }) > > > > This would interfere with the ability to use order_base_2() in > initializers for global variables. There aren't any as far as I can tell and would using order_base_2() for a global initializer make sense?