From: Philipp Zabel <p.zabel@pengutronix.de>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org, Jun Nie <jun.nie@linaro.org>,
Baoyou Xie <baoyou.xie@linaro.org>
Subject: Re: [PATCH] reset: make zx2967 explicitly non-modular
Date: Thu, 02 Feb 2017 16:35:19 +0100 [thread overview]
Message-ID: <1486049719.2289.78.camel@pengutronix.de> (raw)
In-Reply-To: <20170202145212.18609-1-paul.gortmaker@windriver.com>
On Thu, 2017-02-02 at 09:52 -0500, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
>
> config RESET_ZX2967
> bool "ZTE ZX2967 Reset Driver
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the couple traces of modular infrastructure use, so that
> when reading the driver there is no doubt it is builtin-only.
>
> Since builtin_platform_driver() was already in use, the init ordering
> remains unchanged with this commit.
>
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
>
> We don't replace module.h with init.h since the file does not appear
> to use __init prefix anywhere.
>
> Cc: Jun Nie <jun.nie@linaro.org>
> Cc: Baoyou Xie <baoyou.xie@linaro.org>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Thank you, applied with Baoyou's Reviewed-by.
regards
Philipp
prev parent reply other threads:[~2017-02-02 15:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CA+DQWkxP4KJbJgVtSRMez0rfzgfxhZBKvzoBvVyRVR7DhyZOjQ@mail.gmail.com>
2017-02-02 14:52 ` [PATCH] reset: make zx2967 explicitly non-modular Paul Gortmaker
2017-02-02 15:35 ` Philipp Zabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486049719.2289.78.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=baoyou.xie@linaro.org \
--cc=jun.nie@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox