From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751726AbdBBXdF (ORCPT ); Thu, 2 Feb 2017 18:33:05 -0500 Received: from smtprelay0133.hostedemail.com ([216.40.44.133]:45730 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751496AbdBBXdE (ORCPT ); Thu, 2 Feb 2017 18:33:04 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:1963:2110:2393:2559:2562:2691:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3871:3873:3874:4277:4321:5007:7903:10004:10400:10848:11232:11658:11914:12740:12760:12895:13069:13255:13311:13357:13439:13848:14096:14097:14659:21080:21451:30012:30029:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: fold12_378c988e1f14e X-Filterd-Recvd-Size: 1917 Message-ID: <1486078376.22276.54.camel@perches.com> Subject: Re: [PATCH v2] staging: rtl8188eu: remove not necessary braces {} (checkpatch fix) From: Joe Perches To: Martin Karamihov , gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Thu, 02 Feb 2017 15:32:56 -0800 In-Reply-To: <2933ae60-bc8a-278e-b81e-03924de72182@gmail.com> References: <20170128084910.7975-1-martinowar@gmail.com> <20170131192456.1221-1-martinowar@gmail.com> <1485902368.20550.37.camel@perches.com> <1485972712.2560.11.camel@perches.com> <2933ae60-bc8a-278e-b81e-03924de72182@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-02-02 at 08:06 +0200, Martin Karamihov wrote: > On 02/01/2017 08:11 PM, Joe Perches wrote: > > ...and clarifying the code for a > > human reader is much more important than making a > > file not have any checkpatch warnings. > > I agree. I respect the developers' own coding style and believe that > some things (>80 characters long lines, name conventions, etc) should be > fixed by themselves (if they want to do that). I selected several TODOs > with requests for code cleanups and chose a fix in attempt to accomplish > my task with minimal inconvenience for the maintainers. I failed in my > first attempts breaking some basic rules, sorry about that. No, not at all. You did fine for a basic checkpatch cleanup. I just wanted to tell you to think beyond checkpatch. cheers, Joe