From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752828AbdBCNAR (ORCPT ); Fri, 3 Feb 2017 08:00:17 -0500 Received: from mout.gmx.net ([212.227.17.21]:62016 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751958AbdBCNAP (ORCPT ); Fri, 3 Feb 2017 08:00:15 -0500 Message-ID: <1486126774.4277.6.camel@gmx.de> Subject: Re: [tip:sched/core] sched/core: Add debugging code to catch missing update_rq_clock() calls From: Mike Galbraith To: Peter Zijlstra , Sachin Sant Cc: Ross Zwisler , Matt Fleming , Michael Ellerman , "linuxppc-dev@lists.ozlabs.org" , "linux-next@vger.kernel.org" , LKML Date: Fri, 03 Feb 2017 13:59:34 +0100 In-Reply-To: <20170203085301.GA6515@twins.programming.kicks-ass.net> References: <20160921133813.31976-8-matt@codeblueprint.co.uk> <87tw8gutp6.fsf@concordia.ellerman.id.au> <20170130213435.GM31613@codeblueprint.co.uk> <33118425-8548-475A-8DED-9A2424C0BCCC@linux.vnet.ibm.com> <1485863317.4498.2.camel@gmx.de> <20170202155506.GX6515@twins.programming.kicks-ass.net> <3BAB5673-2BF8-46E0-8018-6A0F3DEEC9F7@linux.vnet.ibm.com> <20170203085301.GA6515@twins.programming.kicks-ass.net> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:JLFHTbamJT03vJPLIj8o7ALONBA0CokQk6SmzscwjzuTyLQoAWE qSj0bRaCeGkfOmuZaDmfkz+J24OZHzDdwpfFUPNrAzUUKz1DhiN2zk7Qz6nxNM476BovLDD dKMT65yuSWKTeHFunjHtRToHXB/Th3g3vth4C3wVmWHU8EGvD+zp2YjUztvkjUXAqrLEWk0 EFQ8mb9cjz/iN0yDCQgSg== X-UI-Out-Filterresults: notjunk:1;V01:K0:l8Bu3mRxdFU=:nLVbmT/RaNrIYI8I6/DD1r QLz6IbEPXTTLKnuPpYR90KX2nbP6NJ4u03OoN/HUnA8Zkwjm0HVxCR9ANiZnQaoc8bMuOVH3b ZZUmXhb4Kt5zKRAsiMb6dyj5SIb8KmRq1mkKwnGwYBCHHculVIHzEVQmez+65YUO6Mgn+zkgR yHPqPI/KejvCb2t20RrlMQhdwg7yS6mIfjYXCXnOkpbWOLneq2ei4OrvWpFVBYqmSToFn1CXc vfruIsUXJPs9Nwpw6/rT6OIpN+dySoRoXHG0JttCs0zeHz0vcvFaImeTUrFlRodA2O4U/oAD9 bLlg+/ykDe3XxO+cnrtrtPVqYhP29LIOYNZ9fOhELmo8/q7/7QwyIHfTJFJMHtQ8jBZzWKEKH H4XtVRkssRBPmJA8WdGKlesk7ynkkYqyNRRMVUd5cNx5wV4UHC1a9/WGqJxkzpMIkXfeDXYAQ n2EbTRiTyfwaGjrT/HB5r0D6IICt1ueSi5/TwR2uVgKsqdiRaxoMFHTc704+FFhSW85tbdMlm v3NusGnY8SxbHF+soa2BG0FdpFcxWQFudnJ5cgWMCwqSJMfvMftqhMICPpEe/H7zBV05hNrLH 5GF6T3yUE9P4j+VCvS/2Bfj2f93/7dU5j6fqwWE0i1KRXo8tVJ4Nm8hOSSV6uRQHoKTyjmyu5 CYDiIrL2IOMMjdXczHNWyDL+AsYFK3WcE+9L3GmNxb2WvcBAFZm5u7/PMmyDoneKMWlSllqFZ kKys0jkIMIJzMt6GrY1Axq+ueQIYtM14B9TuzrbAU2r1+gFDkaFDrrntv5TG8V75GjededLO6 4NEibA7LRQsv5Fh2dDS8bwwm972BKkgJAanGXKdgyR8G6cHFrKTlKngEO+nmbAfTm1R301pWf naiB8I/QWdLYCZjhXnKN5uFQtU9p0C4why6t5PIWgCflht3FgraC2Z9+MgHqefETu3Up0z4a3 M4jFZ6AzyFbDc6HSv8ARS0XUSWtww2AAzxErzHqwNXQQOKg6OEaBm6kmkw6WoRhE5Hz/lCr6D RZrx42KCW1s/CFUit519fJDcVx8Dt03ltHSAaj3QydvPKu5bM+PVElyZQ6ZeNqF+Jg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-02-03 at 09:53 +0100, Peter Zijlstra wrote: > On Fri, Feb 03, 2017 at 10:03:14AM +0530, Sachin Sant wrote: > > I ran few cycles of cpu hot(un)plug tests. In most cases it works except one > > where I ran into rcu stall: > > > > [ 173.493453] INFO: rcu_sched detected stalls on CPUs/tasks: > > [ 173.493473] > > > > 8-...: (2 GPs behind) idle=006/140000000000000/0 softirq=0/0 fqs=2996 > > [ 173.493476] > > > > (detected by 0, t=6002 jiffies, g=885, c=884, q=6350) > > Right, I actually saw that too, but I don't think that would be related > to my patch. I'll see if I can dig into this though, ought to get fixed > regardless. FWIW, I'm not seeing stalls/hangs while beating hotplug up in tip. (so next grew a wart?) -Mike