From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753688AbdBDEVs (ORCPT ); Fri, 3 Feb 2017 23:21:48 -0500 Received: from smtprelay0049.hostedemail.com ([216.40.44.49]:59271 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753540AbdBDEVq (ORCPT ); Fri, 3 Feb 2017 23:21:46 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::,RULES_HIT:41:355:379:541:599:967:968:973:981:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:1801:2393:2525:2553:2560:2563:2682:2685:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3870:3871:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4250:4321:4605:5007:7903:9010:9025:10004:10394:10400:10848:11026:11232:11658:11914:12043:12050:12438:12555:12740:12760:12895:12986:13439:14180:14181:14659:14721:21060:21080:21434:21451:30029:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: store30_f198108d9c57 X-Filterd-Recvd-Size: 3346 Message-ID: <1486182102.22276.76.camel@perches.com> Subject: Re: [PATCH] Drivers: staging: speakup: spk_priv.h - style fix From: Joe Perches To: Derek Robson , kbuild test robot Cc: kbuild-all@01.org, w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca, samuel.thibault@ens-lyon.org, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, speakup@linux-speakup.org, linux-kernel@vger.kernel.org Date: Fri, 03 Feb 2017 20:21:42 -0800 In-Reply-To: <20170204033129.GA28560@bigbird> References: <20170203235641.10306-1-robsonde@gmail.com> <201702041030.DlSmHZWB%fengguang.wu@intel.com> <20170204033129.GA28560@bigbird> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2017-02-04 at 16:31 +1300, Derek Robson wrote: > On Sat, Feb 04, 2017 at 10:41:20AM +0800, kbuild test robot wrote: > > Hi Derek, > > > > [auto build test ERROR on staging/staging-testing] > > [also build test ERROR on v4.10-rc6 next-20170203] > > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > > > url: https://github.com/0day-ci/linux/commits/Derek-Robson/Drivers-staging-speakup-spk_priv-h-style-fix/20170204-080247 > > config: i386-allmodconfig (attached as .config) > > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 > > reproduce: > > # save the attached .config to linux build tree > > make ARCH=i386 > > > > All error/warnings (new ones prefixed by >>): > > > > #define param_check_int(name, p) __param_check(name, p, int) > > ^~~~~~~~~~~~~ > > include/linux/moduleparam.h:146:2: note: in expansion of macro 'param_check_int' > > param_check_##type(name, &(value)); \ > > ^~~~~~~~~~~~ > > drivers/staging/speakup/speakup_acntsa.c:136:1: note: in expansion of macro 'module_param_named' > > module_param_named(ser, synth_acntsa.ser, int, 0444); > > ^~~~~~~~~~~~~~~~~~ > > include/linux/moduleparam.h:146:36: error: expected declaration specifiers before ';' token > > param_check_##type(name, &(value)); \ > > ^ > > drivers/staging/speakup/speakup_acntsa.c:136:1: note: in expansion of macro 'module_param_named' > > module_param_named(ser, synth_acntsa.ser, int, 0444); > > ^~~~~~~~~~~~~~~~~~ > > include/linux/moduleparam.h:220:20: error: storage class specified for parameter '__param_str_ser' > > static const char __param_str_##name[] = prefix #name; \ > > Can anyone tell me what I did wrong? You removed semicolons from the function prototypes. -int synth_request_region(u_long, u_long); -int synth_release_region(u_long, u_long); +int synth_request_region(unsigned long start, unsigned long n) +int synth_release_region(unsigned long start, unsigned long n) > I don't think it was my patch that broke the build. You should make sure you build test a patch before sending it on to the list.