From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751456AbdBFI47 (ORCPT ); Mon, 6 Feb 2017 03:56:59 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:53646 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751038AbdBFI4z (ORCPT ); Mon, 6 Feb 2017 03:56:55 -0500 X-AuditID: b6c32a24-f79ea6d000001a2b-80-58983a45f12b Subject: Re: [PATCH 02/11] [media] s5p-mfc: Adding initial support for MFC v10.10 From: Smitha T Murthy To: Rob Herring Cc: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kyungmin.park@samsung.com, kamil@wypas.org, jtp.park@samsung.com, a.hajda@samsung.com, mchehab@kernel.org, pankaj.dubey@samsung.com, krzk@kernel.org, m.szyprowski@samsung.com, s.nawrocki@samsung.com, devicetree@vger.kernel.org In-reply-to: <20170121202852.pxxfxpqwjxewjoj5@rob-hp-laptop> Content-type: text/plain; charset=UTF-8 Date: Mon, 06 Feb 2017 14:07:02 +0530 Message-id: <1486370223.16927.76.camel@smitha-fedora> MIME-version: 1.0 X-Mailer: Evolution 2.28.3 (2.28.3-1.fc12) Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprNJsWRmVeSWpSXmKPExsWy7bCmkq6r1YwIg2vneSxurTvHajH/CJA4 svYqk8XME+2sFufPb2C3ONv0ht1i0+NrrBaXd81hs+jZsJXVYu2Ru+wWyzb9YbJYtPULu8X/ PTvYLQ6/aWd14PPYtKqTzWPzknqPvi2rGD0+b5LzuHKkkT2ANSrVJiM1MSW1SCE1Lzk/JTMv 3VbJOzjeOd7UzMBQ19DSwlxJIS8xN9VWycUnQNctMwfoUCWFssScUqBQQGJxsZK+nU1RfmlJ qkJGfnGJrVK0oaGRnqGBuZ6RkZGeiVGslZEpUElCakb31aWMBW1CFT/uNzA1MO7k62Lk5JAQ MJH49vEpG4QtJnHh3nogm4tDSGApo8SE/RdYIZzPjBJXTqxghek42fAHKrGBUeJk/3t2kISw QLDEpD37wIrYBHQkvr0/DTZWREBR4nfbNLA4s8AlJome0xwgNqeAjcTKXZPYIOKaEq3bf4PN YRFQldjZ/4cFxOYVMJV4fRjkCg4gW1Di7w5hiBu0JdY1nGGBaJWX2P52DjPIPRIC59gleu5+ ZgeplxCQldh0gBnCdJGYusIEolVY4tXxLewQtpTEydkP2CFamxkl5m5rZoFITGCUWNlaCmHb Sxy4MgdqF5/EnO6DTBAzeSU62oQgSjwkDu3cDw0eR4l/k45Dg6eVSaJ50wG2CYxys5B8OQvh m1lIPljAyLyKUSy1oDg3PbXYpMBErzgxt7g0L10vOT93EyM4YWqp7GD8scD7EKMAB6MSD++M tukRQqyJZcWVuYcYJTiYlUR4Ay1nRAjxpiRWVqUW5ccXleakFh9iNAUG6kRmKdHkfGAyzyuJ NzQxMzQxMjOyNDcyNVES5/U0mBghJJCeWJKanZpakFoE08fEwSnVwGgczWcwceacxVd/9hfH LM2es5Ijq4ejyP/GEVZ5qXWRe3nf87G+uMZStjRqX4tfSpPyl29fNpy0f7/acMm3G6HT7wh1 TPynJ7ZZe7FCjmjBS3v2TxLfW2P2nC5bfn6SVvNBe+6PO4++nj1x7545t1als89L2MKzOuyb ypdr07oq1h2YkfrWO+eiEktxRqKhFnNRcSIAAtVhAK4DAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrBIsWRmVeSWpSXmKPExsWSnRNsqOtiNSPC4OtsM4tb686xWsw/AiSO rL3KZDHzRDurxfnzG9gtzja9YbfY9Pgaq8XlXXPYLHo2bGW1WHvkLrvFsk1/mCwWbf3CbvF/ zw52i8Nv2lkd+Dw2repk89i8pN6jb8sqRo/Pm+Q8rhxpZA9gjXKzyUhNTEktUkjNS85PycxL t1UKDXHTtVBSyEvMTbVVitD1DQlSUihLzCkF8owM0ICDc4B7sJK+XYJbRvfVpYwFbUIVP+43 MDUw7uTrYuTkkBAwkTjZ8IcVwhaTuHBvPVsXIxeHkMA6RoldN1+CJYQFgiUm7dkHZrMJ6Eh8 e3+aDcQWEVCU+N02jRWkgVngNJPEznWTmEASnAI2Eit3TYKa1MEkce/OEbBuZgFNidbtv9lB bBYBVYmd/X9YQGxeAVOJ14cvANVwANmCEn93CENcpC2xruEMC0SrvMT2t3OYJzDyz0IyaRZC xywkVQsYmVcxiqUWFOem5xYXGJjoFSfmFpfmpesl5+duYgTG4rbDSpI7GFet8DrEKMDBqMTD GzBpeoQQa2JZcWXuIUYJDmYlEd5AyxkRQrwpiZVVqUX58UWlOanFhxhNgQ6fyCwlmpwPTBN5 JfGGJqYWFhYmlsbGxhYmSuK8sdOfhQsJpCeWpGanphakFsH0MXFwSjUw2nz4szpureDuqd7v n58wj8052tX6PF7xwmTFF24ar+JcrqzhOLR9krH1yvd9NVGPBHYx3JX81GUi0b75x89DR8tv rjQ+cWgTh339/88SF5bPzzq1xnCf3o18ob/Zh7Zq2mXnvNx6VOna7XOTX5yPV3PmDbq0U0pz z9qZHz93+X3pLHjCdnCCf7gSS3FGoqEWc1FxIgBC5fCA2wIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170206085636epcas4p4424c682567529655e22f1f9981f13d23 X-Msg-Generator: CA X-Sender-IP: 182.195.34.25 X-Local-Sender: =?UTF-8?B?U21pdGhhIFQgTXVydGh5G1NTSVItVHVybiBLZXkgU29sdXRp?= =?UTF-8?B?b25zG+yCvOyEseyghOyekBtMZWFkIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?U21pdGhhIFQgTXVydGh5G1NTSVItVHVybiBLZXkgU29sdXRp?= =?UTF-8?B?b25zG1NhbXN1bmcgRWxlY3Ryb25pY3MbTGVhZCBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NXQUhRG0MxMElEMDdJRDAxMDk5Nw==?= CMS-TYPE: 104P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170118100723epcas5p132e0ebfad38261bed95cffc47334f9dc X-RootMTR: 20170118100723epcas5p132e0ebfad38261bed95cffc47334f9dc References: <1484733729-25371-1-git-send-email-smitha.t@samsung.com> <1484733729-25371-3-git-send-email-smitha.t@samsung.com> <20170121202852.pxxfxpqwjxewjoj5@rob-hp-laptop> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2017-01-21 at 14:28 -0600, Rob Herring wrote: > On Wed, Jan 18, 2017 at 03:32:00PM +0530, Smitha T Murthy wrote: > > Adding the support for MFC v10.10, with new register file and > > necessary hw control, decoder, encoder and structural changes. > > > > CC: Rob Herring > > CC: devicetree@vger.kernel.org > > Signed-off-by: Smitha T Murthy > > --- > > .../devicetree/bindings/media/s5p-mfc.txt | 1 + > > drivers/media/platform/s5p-mfc/regs-mfc-v10.h | 36 ++++++++++++++++ > > drivers/media/platform/s5p-mfc/s5p_mfc.c | 30 +++++++++++++ > > drivers/media/platform/s5p-mfc/s5p_mfc_common.h | 4 +- > > drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c | 4 ++ > > drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 44 +++++++++++--------- > > drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 21 +++++---- > > drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c | 9 +++- > > drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.h | 2 + > > 9 files changed, 118 insertions(+), 33 deletions(-) > > create mode 100644 drivers/media/platform/s5p-mfc/regs-mfc-v10.h > > > > diff --git a/Documentation/devicetree/bindings/media/s5p-mfc.txt b/Documentation/devicetree/bindings/media/s5p-mfc.txt > > index 2c90128..b70c613 100644 > > --- a/Documentation/devicetree/bindings/media/s5p-mfc.txt > > +++ b/Documentation/devicetree/bindings/media/s5p-mfc.txt > > @@ -13,6 +13,7 @@ Required properties: > > (c) "samsung,mfc-v7" for MFC v7 present in Exynos5420 SoC > > (d) "samsung,mfc-v8" for MFC v8 present in Exynos5800 SoC > > (e) "samsung,exynos5433-mfc" for MFC v8 present in Exynos5433 SoC > > + (f) "samsung,mfc-v10" for MFC v10 present in a variant of Exynos7 SoC > > You are up to v10 in how many SoCs? Please stop with versions and use > SoC numbers. It's one thing to use versions when you have many SoCs per > version, but that doesn't seem to be happening here. > > Rob MFCv10.10 is used in Exynos7880. There are other variants of MFCv10 used in Exynos8890 and Exynos7870. I will mention in the next version of patches the SoC name Exynos7880 using MFCv10 on which I have tested. Thank you for the review. Regards, Smitha > >