From: Johannes Berg <johannes@sipsolutions.net>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Dmitry Osipenko <digetx@gmail.com>,
Chaoming Li <chaoming_li@realsil.com.cn>
Cc: linux-wireless@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: rtlwifi: rtl8192c_common: "BUG: KASAN: slab-out-of-bounds"
Date: Mon, 06 Feb 2017 11:29:39 +0100 [thread overview]
Message-ID: <1486376979.14226.9.camel@sipsolutions.net> (raw)
In-Reply-To: <edbcbe3f-9b5d-cead-5885-27bc55ef550b@lwfinger.net> (sfid-20170204_194158_652576_51C325FF)
On Sat, 2017-02-04 at 12:41 -0600, Larry Finger wrote:
> On 02/04/2017 10:58 AM, Dmitry Osipenko wrote:
> > Seems the problem is caused by rtl92c_dm_*() casting .priv to
> > "struct
> > rtl_pci_priv", while it is "struct rtl_usb_priv".
>
> Those routines are shared by rtl8192ce and rtl8192cu, thus we need to
> make that
> difference in cast to be immaterial. I think we need to move "struct
> bt_coexist_info" to the beginning of both rtlpci_priv and
> rtl_usb_priv. Then it
> should not matter.
I think you really should consider putting a struct rtl_common into
that or something, and getting rid of all the casting that causes this
problem to start with?
johannes
next prev parent reply other threads:[~2017-02-06 10:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-04 15:29 rtlwifi: rtl8192c_common: "BUG: KASAN: slab-out-of-bounds" Dmitry Osipenko
2017-02-04 16:58 ` Dmitry Osipenko
2017-02-04 18:41 ` Larry Finger
2017-02-04 19:32 ` Dmitry Osipenko
2017-02-05 1:05 ` Larry Finger
2017-02-05 11:34 ` Dmitry Osipenko
2017-02-05 17:30 ` Larry Finger
2017-02-05 18:15 ` Dmitry Osipenko
2017-02-07 17:22 ` Tobias Guggenmos
2017-02-07 17:42 ` Dmitry Osipenko
2017-02-06 10:29 ` Johannes Berg [this message]
2017-02-06 15:45 ` Larry Finger
2017-02-07 16:45 ` Tobias Guggenmos
2017-02-07 17:14 ` Dmitry Osipenko
2017-02-08 0:45 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486376979.14226.9.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Larry.Finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=digetx@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox