From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752117AbdBFNFa (ORCPT <rfc822;w@1wt.eu>);
        Mon, 6 Feb 2017 08:05:30 -0500
Received: from foss.arm.com ([217.140.101.70]:57208 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750994AbdBFNF2 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 6 Feb 2017 08:05:28 -0500
Message-ID: <1486386325.2929.23.camel@arm.com>
Subject: Re: [PATCH] bus: arm-ccn: Fix module autoload
From: Pawel Moll <pawel.moll@arm.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>,
        linux-kernel@vger.kernel.org
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Mark Rutland <mark.rutland@arm.com>
Date: Mon, 06 Feb 2017 13:05:25 +0000
In-Reply-To: <03b73d0e-d2f6-f06a-82c7-cece8c8112b8@osg.samsung.com>
References: <1483362149-3771-1-git-send-email-javier@osg.samsung.com>
         <03b73d0e-d2f6-f06a-82c7-cece8c8112b8@osg.samsung.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.18.5.2-0ubuntu3.1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2017-02-03 at 18:31 -0300, Javier Martinez Canillas wrote:
> On 01/02/2017 10:02 AM, Javier Martinez Canillas wrote:
> > 
> > If the driver is built as a module, autoload won't work because the module
> > alias information is not filled. So user-space can't match the registered
> > device with the corresponding module.
> > 
> > Export the module alias information using the MODULE_DEVICE_TABLE()
> > macro.
> > 
> > Before this patch:
> > 
> > $ modinfo drivers/bus/arm-ccn.ko | grep alias
> > $
> > 
> > After this patch:
> > 
> > $ modinfo drivers/bus/arm-ccn.ko | grep alias
> > alias:          of:N*T*Carm,ccn-504C*
> > alias:          of:N*T*Carm,ccn-504
> > 
> > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> > ---
> Any comments about this patch?

Sorry, I clearly missed that in my mailbox at the beginning of the
year.

It all makes sense to me. I'll try to test it out soon and will make
sure to include it next time I send out CCN update.

Thanks!

Paweł