[PATCH] bus: arm-ccn: Fix module autoload

[PATCH] bus: arm-ccn: Fix module autoload

[Javier Martinez Canillas]

If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.

Export the module alias information using the MODULE_DEVICE_TABLE() macro.

Before this patch:

$ modinfo drivers/bus/arm-ccn.ko | grep alias
$

After this patch:

$ modinfo drivers/bus/arm-ccn.ko | grep alias
alias:          of:N*T*Carm,ccn-504C*
alias:          of:N*T*Carm,ccn-504

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/bus/arm-ccn.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bus/arm-ccn.c b/drivers/bus/arm-ccn.c
index 4d6a2b7e4d3f..80758f6fdaa5 100644
--- a/drivers/bus/arm-ccn.c
+++ b/drivers/bus/arm-ccn.c
@@ -1547,6 +1547,7 @@ static const struct of_device_id arm_ccn_match[] = {
 	{ .compatible = "arm,ccn-504", },
 	{},
 };
+MODULE_DEVICE_TABLE(of, arm_ccn_match);
 
 static struct platform_driver arm_ccn_driver = {
 	.driver = {
-- 
2.7.4

Re: [PATCH] bus: arm-ccn: Fix module autoload

[Javier Martinez Canillas]

Hello,

On 01/02/2017 10:02 AM, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
> 
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> 
> Before this patch:
> 
> $ modinfo drivers/bus/arm-ccn.ko | grep alias
> $
> 
> After this patch:
> 
> $ modinfo drivers/bus/arm-ccn.ko | grep alias
> alias:          of:N*T*Carm,ccn-504C*
> alias:          of:N*T*Carm,ccn-504
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---

Any comments about this patch?

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Re: [PATCH] bus: arm-ccn: Fix module autoload

[Pawel Moll]

On Fri, 2017-02-03 at 18:31 -0300, Javier Martinez Canillas wrote:
> On 01/02/2017 10:02 AM, Javier Martinez Canillas wrote:
> >
> > If the driver is built as a module, autoload won't work because the module
> > alias information is not filled. So user-space can't match the registered
> > device with the corresponding module.
> >
> > Export the module alias information using the MODULE_DEVICE_TABLE()
> > macro.
> >
> > Before this patch:
> >
> > $ modinfo drivers/bus/arm-ccn.ko | grep alias
> > $
> >
> > After this patch:
> >
> > $ modinfo drivers/bus/arm-ccn.ko | grep alias
> > alias:          of:N*T*Carm,ccn-504C*
> > alias:          of:N*T*Carm,ccn-504
> >
> > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> > ---
> Any comments about this patch?

Sorry, I clearly missed that in my mailbox at the beginning of the
year.

It all makes sense to me. I'll try to test it out soon and will make
sure to include it next time I send out CCN update.

Thanks!

Paweł
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Re: [PATCH] bus: arm-ccn: Fix module autoload

[Pawel Moll]

On Fri, 2017-02-03 at 18:31 -0300, Javier Martinez Canillas wrote:
> On 01/02/2017 10:02 AM, Javier Martinez Canillas wrote:
> > 
> > If the driver is built as a module, autoload won't work because the module
> > alias information is not filled. So user-space can't match the registered
> > device with the corresponding module.
> > 
> > Export the module alias information using the MODULE_DEVICE_TABLE()
> > macro.
> > 
> > Before this patch:
> > 
> > $ modinfo drivers/bus/arm-ccn.ko | grep alias
> > $
> > 
> > After this patch:
> > 
> > $ modinfo drivers/bus/arm-ccn.ko | grep alias
> > alias:          of:N*T*Carm,ccn-504C*
> > alias:          of:N*T*Carm,ccn-504
> > 
> > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> > ---
> Any comments about this patch?

Sorry, I clearly missed that in my mailbox at the beginning of the
year.

It all makes sense to me. I'll try to test it out soon and will make
sure to include it next time I send out CCN update.

Thanks!

Paweł

Re: [PATCH] bus: arm-ccn: Fix module autoload

[Javier Martinez Canillas]

Hello Pawel,

On 02/06/2017 10:05 AM, Pawel Moll wrote:
> On Fri, 2017-02-03 at 18:31 -0300, Javier Martinez Canillas wrote:
>> On 01/02/2017 10:02 AM, Javier Martinez Canillas wrote:
>>>
>>> If the driver is built as a module, autoload won't work because the module
>>> alias information is not filled. So user-space can't match the registered
>>> device with the corresponding module.
>>>
>>> Export the module alias information using the MODULE_DEVICE_TABLE()
>>> macro.
>>>
>>> Before this patch:
>>>
>>> $ modinfo drivers/bus/arm-ccn.ko | grep alias
>>> $
>>>
>>> After this patch:
>>>
>>> $ modinfo drivers/bus/arm-ccn.ko | grep alias
>>> alias:          of:N*T*Carm,ccn-504C*
>>> alias:          of:N*T*Carm,ccn-504
>>>
>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>> ---
>> Any comments about this patch?
> 
> Sorry, I clearly missed that in my mailbox at the beginning of the
> year.
> 
> It all makes sense to me. I'll try to test it out soon and will make
> sure to include it next time I send out CCN update.
>

Ok, thanks a lot!
 
> Thanks!
> 
> Paweł
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America