From: Sachin Prabhu <sprabhu@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>, Steve French <sfrench@samba.org>
Cc: Pavel Shilovsky <pshilov@microsoft.com>,
Aurelien Aptel <aaptel@suse.com>,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] CIFS: use correct format string for size_t
Date: Mon, 06 Feb 2017 19:27:35 +0530 [thread overview]
Message-ID: <1486389455.2576.14.camel@redhat.com> (raw)
In-Reply-To: <20170202122117.1404479-1-arnd@arndb.de>
On Thu, 2017-02-02 at 13:21 +0100, Arnd Bergmann wrote:
> This warning is harmless as size_t is always as wide as 'unsigned
> long':
>
> fs/cifs/smb2ops.c:2008:245: error: format '%lu' expects argument of
> type 'long unsigned int', but argument 5 has type 'size_t {aka
> unsigned int}' [-Werror=format=]
>
> Using %zu however is the correct format string that we don't get a
> warning for.
>
> Fixes: c9d651a5a2fe ("CIFS: Decrypt and process small encrypted
> packets")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Sachin Prabhu <sprabhu@redhat.com>
> ---
> fs/cifs/smb2ops.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
> index 0764c32754b0..ac6e10adf000 100644
> --- a/fs/cifs/smb2ops.c
> +++ b/fs/cifs/smb2ops.c
> @@ -2005,7 +2005,7 @@ handle_read_data(struct TCP_Server_Info
> *server, struct mid_q_entry *mid,
> rdata->iov[0].iov_len = 4;
> rdata->iov[1].iov_base = buf + 4;
> rdata->iov[1].iov_len = server->vals->read_rsp_size - 4;
> - cifs_dbg(FYI, "0: iov_base=%p iov_len=%lu\n",
> + cifs_dbg(FYI, "0: iov_base=%p iov_len=%zu\n",
> rdata->iov[0].iov_base, server->vals-
> >read_rsp_size);
>
> length = rdata->copy_into_pages(server, rdata, &iter);
prev parent reply other threads:[~2017-02-06 13:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 12:21 [PATCH] CIFS: use correct format string for size_t Arnd Bergmann
2017-02-02 18:03 ` Pavel Shilovsky
2017-02-06 13:57 ` Sachin Prabhu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486389455.2576.14.camel@redhat.com \
--to=sprabhu@redhat.com \
--cc=aaptel@suse.com \
--cc=arnd@arndb.de \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pshilov@microsoft.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox