From: Joe Perches <joe@perches.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Maksymilian Piechota <maksymilianpiechota@gmail.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH v3] staging: lustre: align else if statement to coding standard
Date: Mon, 06 Feb 2017 06:50:29 -0800 [thread overview]
Message-ID: <1486392629.3616.4.camel@perches.com> (raw)
In-Reply-To: <20170206130359.GB5504@kroah.com>
On Mon, 2017-02-06 at 14:03 +0100, Greg Kroah-Hartman wrote:
> On Mon, Feb 06, 2017 at 07:56:39AM -0500, Maksymilian Piechota wrote:
> > On Mon, Feb 06, 2017 at 01:50:02PM +0100, Greg Kroah-Hartman wrote:
> > > On Mon, Feb 06, 2017 at 07:26:56AM -0500, Maksymilian Piechota wrote:
> > > > - move logical continuations at the end of line
> > > > - move else if statement to a single line
> > > > - Replace spaces with tabstop.
> > >
> > > That's a lot of different things, happening all at once. Please break
> > > this up into multiple patches, each one only doing one thing, and send a
> > > patch series.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > Fixing two lines of code in three patches?
>
> Yes.
Greg is also sometimes completely crazy.
I think he's only doing this because you are a
relatively new patch submitter and he wants you
to go through some linux-kernel process hazing.
It'd be more efficient as a single patch and better
overall to avoid descriptions with multiple
characteristics that elicit Greg's somewhat OCD
reflexes.
If this commit log was merely described as "use a
normal kernel style" for the else if and nothing
else was mentioned, this would likely have been
accepted.
prev parent reply other threads:[~2017-02-06 14:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 12:26 [PATCH v3] staging: lustre: align else if statement to coding standard Maksymilian Piechota
2017-02-06 12:50 ` Greg Kroah-Hartman
2017-02-06 12:56 ` Maksymilian Piechota
2017-02-06 13:03 ` Greg Kroah-Hartman
2017-02-06 14:50 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486392629.3616.4.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maksymilianpiechota@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox