Re: [PATCH 09/10] iommu/exynos: Make use of iommu_device_register interface

Joerg Roedel
2017-02-08T14:54:05Z

Hi Marek,

On Tue, Feb 07, 2017 at 01:36:15PM +0100, Marek Szyprowski wrote:
> >+ ret = iommu_device_sysfs_add(&data->iommu, &pdev->dev, NULL,
> >+ "sysmmu.%pa", &ioaddr);
>
> Can we stick to the common name across the /sysfs and use
> dev_name(data->sysmmu)
> or even dev_name(dev) here?
>
> ret = iommu_device_sysfs_add(&data->iommu, &pdev->dev, NULL,
> dev_name(dev));

That means that we have multiple 'struct device' with the same name,
no? I think will lead to confusion when using dev_printk, as its not
clear anymore which device is refered to in the message.

Joerg